Add dynamic metric alert api #5677

meday89 · 2019-04-17T15:26:53Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-04-17T15:27:30Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#2600

AutorestCI · 2019-04-17T15:27:32Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4563

AutorestCI · 2019-04-17T15:27:44Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4711

AutorestCI · 2019-04-17T15:28:29Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

azuresdkci · 2019-04-17T15:29:23Z

Can one of the admins verify this patch?

…eOrUpdateDynamicMetricAlertMultipleResource.json

AutorestCI · 2019-04-17T17:34:54Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2993

REST Spec PR 'Azure/azure-rest-api-specs#5677' REST Spec PR Author 'meday89' REST Spec PR Last commit

adxsdknet · 2019-04-18T09:36:34Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5861
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@2c7a862
adxsdknet/azure-sdk-for-net@1ecba25

shahabhijeet · 2019-04-21T22:20:04Z

...ification/monitor/resource-manager/Microsoft.Insights/stable/2018-03-01/metricAlert_API.json

@@ -537,14 +541,14 @@
        "allOf": {
          "type": "array",
          "items": {
-            "$ref": "#/definitions/MetricCriteria"
+            "$ref": "#/definitions/StaticMetricCriteria"


Breaking change in stable API.
Any reason you would like to change your models in a stable version?

Fixed, please see updates.

shahabhijeet · 2019-04-23T22:02:03Z

...soft.Insights/stable/2018-03-01/examples/createOrUpdateDynamicMetricAlertSingleResource.json

+          "severity": 3,
+          "enabled": true,
+          "scopes": [
+            "/subscriptions/14ddf0c5-77c5-4b53-84f6-e1fa43ad68f7/resourceGroups/gigtest/providers/Microsoft.Compute/virtualMachines/gigwadme"


@meday89 if you are using real subscriptionId, use a fake subscriptionId.
We recommend (000000-0000-00000...…..)

Fixed, please see updates.

REST Spec PR 'Azure/azure-rest-api-specs#5677' REST Spec PR Author 'meday89' REST Spec PR Last commit

* Add dynamic metric alert api * add new line at end of flie * Fix file name * Rename CreateOrUpdateDynamicMetricAlertMultipleResource.json to createOrUpdateDynamicMetricAlertMultipleResource.json * Remove failing dependency * Add back example dependency * Rename microsoft.insight * Update dynamic threshold criteria descriptions * Fix PR comments: Revert name change + Use fake subscriptionId

* .NET SDK Resource Provider:'Monitor' REST Spec PR 'Azure/azure-rest-api-specs#5677' REST Spec PR Author 'meday89' REST Spec PR Last commit * .NET SDK Resource Provider:'Monitor' REST Spec PR 'Azure/azure-rest-api-specs#5677' REST Spec PR Author 'meday89' REST Spec PR Last commit

* Added regultory compliance to package-composite-v3 (#5786) * Added regultory compliance to package-composite-v3 * Added regultory compliance to package-composite-v3 * Improve documentation of sql database & elastic pool skus (#5756) * Improve documentation of db and pool skus * Update documentation for database 2017-10-01-preview * Update documentation for elastic pool 2017-10-01-preview * Fixed syntax error in databases 2017-10-01 * Fixed syntax error in elasticPools 2017-10-01 * Remove CreateVCoreDatabase example that is no longer referenced * Remove DW DTU capacity example due to feedback * Fixed broken Sku reference * Fixed model validation issues * Fixed another model validation error * Additional doc tweaks * Create new resource type: Microsoft.ResourceGraph/queries (#5478) * Adding Workbooks resource type. * Rename workbookDelete.json to WorkbookDelete.json * Fixed undefiend parameter issue with Delete verb. * Update swagger to add subscriptionId * Fixed duplicated operation id issue * Removed links endpoint * Removed unused samples * Revert "Removed unused samples" This reverts commit bed6bc3. * Revert "Removed links endpoint" This reverts commit c245a85. * Removed link logic and added get by resourceid * Applied PR comments * Added Resource Group parameter for GET. Removed get by sourceId since we are not using sourceId anymore * Resolved the merge conflicts with readme.md * Remove a location parameter since ARM routes it as we are using an tracted resource type * Created newer version (2018-04-01-preview) for workbook resource type. * Added Microsoft/Insights/Operations * Added Microsoft/Insights/Operations * Corrected the api version. * Made properties of PATCH operation as not required. Updated the version number to reflect the actual production one. * Updated Resource properties with the correct fields. Created new definition for PATCH operation since location is not required field * Update readme file * Uses plural for operation group name * Removed x-ms-mutability settings * Removed the location settings for PATCH * Added Microsoft.ResourceGraph/SavedQuery resource type * Fixed various validation errors * Updated ARG/resources to add a saved query support along with examples * Updated ARM/resources based on the feedback * Prepared for Swagger submittion * Added saved query entry in readme.md * Changed HTTP status code of 201 to 200 for DELETE * Removed a name from payload since it is already specified in url * Removed location since it is a global resource and added eTag * Moved savedquery.json along with all examples into 2018-09-01-preview folder * Update saved query metadata in OperationsList.json * Updated readme.md file to address a version * Fixed a version for saved query * Fixed indentation of -input-file in readme * Renamed Saved => Graph * Applied PR comments * Restored extended enum value in ResultKind since we are using it * Removed the extended enum value again * Apply ARM API team comments * Fix examples * Fix examples * Added nextLinkName * add Go SDK build * make descriptions match * Added nextLink definition in OperationListResult * Removed a duplicated OperationListResult and reference to resourcegraph.json * Added nextLinkName: nextLink for x-ms-pageable in operations * fix formatting and description * Removed extended from enum * Updating Profile format (#5768) * Updating Profile format Updating profile spec format to include actual path for resource spec * Update 2019-03-01-hybrid.json updating resourceName to resourceType * [Azure Search] New GA data-plane API spec for version 2019-05-06 (#5782) * [Azure Search] Copy 2017-11-11-Preview specs to 2019-05-06 * [Azure Search] Update 2019-05-06 spec to reflect new GA API Made the following changes to specs and examples: 1. Changed version number from 2017-11-11-Preview to 2019-05-06. 2. Removed encryptionKey from Index and SynonymMap, as well as supporting types and examples. Encryption with customer-managed keys is still in preview. 3. Added statusCode to IndexError since this was added to the 2019-05-06 API. 4. Made DataSourceCredentials.connectionString an optional property to suppress generation of client-side validation code. This will make it easier for customers to write correct code that updates their data sources. This is especially important now that Create and CreateOrUpdate do not return the connection string. No further changes are required because all other features from 2017-11-11-Preview are now GA in 2019-05-06. * [SRP] Expose lease container in Apr19 API. (#5733) * [SRP] Expose lease container in Apr19 API. * Fix lease container example files; fix casing in Lease Container URL * Update CODEOWNERS (#5794) assigning as one of the owners of profile directory * [Microsoft.ResourceGraph] Returning null for nextLink in example to preserve the existing scenario (#5792) * Adding Workbooks resource type. * Rename workbookDelete.json to WorkbookDelete.json * Fixed undefiend parameter issue with Delete verb. * Update swagger to add subscriptionId * Fixed duplicated operation id issue * Removed links endpoint * Removed unused samples * Revert "Removed unused samples" This reverts commit bed6bc3. * Revert "Removed links endpoint" This reverts commit c245a85. * Removed link logic and added get by resourceid * Applied PR comments * Added Resource Group parameter for GET. Removed get by sourceId since we are not using sourceId anymore * Resolved the merge conflicts with readme.md * Remove a location parameter since ARM routes it as we are using an tracted resource type * Created newer version (2018-04-01-preview) for workbook resource type. * Added Microsoft/Insights/Operations * Added Microsoft/Insights/Operations * Corrected the api version. * Made properties of PATCH operation as not required. Updated the version number to reflect the actual production one. * Updated Resource properties with the correct fields. Created new definition for PATCH operation since location is not required field * Update readme file * Uses plural for operation group name * Removed x-ms-mutability settings * Removed the location settings for PATCH * Added Microsoft.ResourceGraph/SavedQuery resource type * Fixed various validation errors * Updated ARG/resources to add a saved query support along with examples * Updated ARM/resources based on the feedback * Prepared for Swagger submittion * Added saved query entry in readme.md * Changed HTTP status code of 201 to 200 for DELETE * Removed a name from payload since it is already specified in url * Removed location since it is a global resource and added eTag * Moved savedquery.json along with all examples into 2018-09-01-preview folder * Update saved query metadata in OperationsList.json * Updated readme.md file to address a version * Fixed a version for saved query * Fixed indentation of -input-file in readme * Renamed Saved => Graph * Applied PR comments * Restored extended enum value in ResultKind since we are using it * Removed the extended enum value again * Apply ARM API team comments * Fix examples * Fix examples * Added nextLinkName * add Go SDK build * make descriptions match * Added nextLink definition in OperationListResult * Removed a duplicated OperationListResult and reference to resourcegraph.json * Added nextLinkName: nextLink for x-ms-pageable in operations * fix formatting and description * Removed extended from enum * Remove nextLink from the example * Returning null for nextLink in the example so that we can preserve the existing scenario. * Removed nextLink entirely per PR comment * Update the default tag for LUIS Runtime (#5793) * typo: cognitiveservices/data-plane/LUIS/Runtime (#5798) - analaysis -> analysis - perdicted -> predicted * Add TypeScript readme for Serial Console (#5806) * chore: jsonfmt adhybridhealthservice (#5799) * Add Swagger and Examples for custom resource provider to Azure (#5808) * Add Swagger and Examples for custom resource provider to Azure * Apply suggestions from code review Fix typos in strings for RP. Co-Authored-By: jjbfour <jobreen@microsoft.com> * Add dynamic metric alert api (#5677) * Add dynamic metric alert api * add new line at end of flie * Fix file name * Rename CreateOrUpdateDynamicMetricAlertMultipleResource.json to createOrUpdateDynamicMetricAlertMultipleResource.json * Remove failing dependency * Add back example dependency * Rename microsoft.insight * Update dynamic threshold criteria descriptions * Fix PR comments: Revert name change + Use fake subscriptionId * removed unused profiles * regenerated multiapi readmes * regenerated latest profile

Add dynamic metric alert api

8321de2

azuresdkci assigned shahabhijeet Apr 17, 2019

azuresdkci requested a review from shahabhijeet April 17, 2019 15:27

meday89 and others added 5 commits April 17, 2019 18:31

add new line at end of flie

a09a53b

Fix file name

f62d817

Rename CreateOrUpdateDynamicMetricAlertMultipleResource.json to creat…

c6f2b37

…eOrUpdateDynamicMetricAlertMultipleResource.json

Remove failing dependency

dd7d242

Add back example dependency

2b8310a

Rename microsoft.insight

74bb59c

Update dynamic threshold criteria descriptions

1f77397

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 18, 2019

.NET SDK Resource Provider:'Monitor'

2c7a862

REST Spec PR 'Azure/azure-rest-api-specs#5677' REST Spec PR Author 'meday89' REST Spec PR Last commit

shahabhijeet mentioned this pull request Apr 19, 2019

OAV doesnt proper validate nested discriminated types with an a property called "allOf" Azure/oav#421

Closed

shahabhijeet requested changes Apr 21, 2019

View reviewed changes

shahabhijeet requested changes Apr 23, 2019

View reviewed changes

shahabhijeet added the potential-sdk-breaking-change label Apr 23, 2019

Fix PR comments: Revert name change + Use fake subscriptionId

31ef899

This was referenced Apr 28, 2019

[AutoPR monitor/resource-manager] Add dynamic metric alert api Azure/azure-sdk-for-js#2543

Closed

[AutoPR monitor/resource-manager] Add dynamic metric alert api Azure/azure-sdk-for-go#4691

Merged

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 28, 2019

.NET SDK Resource Provider:'Monitor'

1ecba25

REST Spec PR 'Azure/azure-rest-api-specs#5677' REST Spec PR Author 'meday89' REST Spec PR Last commit

asafst requested a review from shahabhijeet April 28, 2019 11:34

shahabhijeet approved these changes Apr 30, 2019

View reviewed changes

shahabhijeet merged commit 1198700 into Azure:master Apr 30, 2019

AutorestCI mentioned this pull request Apr 30, 2019

[AutoPR monitor/resource-manager] Add dynamic metric alert api Azure/azure-sdk-for-js#2599

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dynamic metric alert api #5677

Add dynamic metric alert api #5677

meday89 commented Apr 17, 2019 •

edited

Loading

AutorestCI commented Apr 17, 2019 •

edited

Loading

AutorestCI commented Apr 17, 2019 •

edited

Loading

AutorestCI commented Apr 17, 2019 •

edited

Loading

AutorestCI commented Apr 17, 2019 •

edited

Loading

azuresdkci commented Apr 17, 2019

AutorestCI commented Apr 17, 2019 •

edited

Loading

adxsdknet commented Apr 18, 2019 •

edited

Loading

shahabhijeet Apr 21, 2019

meday89 Apr 28, 2019

shahabhijeet Apr 23, 2019

meday89 Apr 28, 2019

Add dynamic metric alert api #5677

Add dynamic metric alert api #5677

Conversation

meday89 commented Apr 17, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Apr 17, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Apr 17, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 17, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Apr 17, 2019 • edited Loading

Automation for azure-sdk-for-ruby

azuresdkci commented Apr 17, 2019

AutorestCI commented Apr 17, 2019 • edited Loading

Automation for azure-sdk-for-java

adxsdknet commented Apr 18, 2019 • edited Loading

Automation for azure-sdk-for-net

shahabhijeet Apr 21, 2019

Choose a reason for hiding this comment

meday89 Apr 28, 2019

Choose a reason for hiding this comment

shahabhijeet Apr 23, 2019

Choose a reason for hiding this comment

meday89 Apr 28, 2019

Choose a reason for hiding this comment

meday89 commented Apr 17, 2019 •

edited

Loading

AutorestCI commented Apr 17, 2019 •

edited

Loading

AutorestCI commented Apr 17, 2019 •

edited

Loading

AutorestCI commented Apr 17, 2019 •

edited

Loading

AutorestCI commented Apr 17, 2019 •

edited

Loading

AutorestCI commented Apr 17, 2019 •

edited

Loading

adxsdknet commented Apr 18, 2019 •

edited

Loading