Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoPR graphrbac/data-plane] Add service principals by app id microsoft.graph rbac #4605

Merged
merged 6 commits into from
Mar 20, 2019
Merged

[AutoPR graphrbac/data-plane] Add service principals by app id microsoft.graph rbac #4605

merged 6 commits into from
Mar 20, 2019

Conversation

AutorestCI
Copy link
Contributor

@AutorestCI
Generated from 9f615cc6b8f1dd194512f725b3e6655314c95e1e
19ce5fd 
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs into add-servicePrincipalsByAppId-Microsoft.GraphRbac
@AutorestCI AutorestCI requested a review from lmazuel as a code owner March 18, 2019 19:12
@AutorestCI AutorestCI mentioned this pull request Mar 18, 2019
Merged
5 tasks
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Mar 18, 2019 •
edited
Loading

(message created by the CI based on PR content)

Installation instruction

Package azure-graphrbac

You can install the package azure-graphrbac of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5417#egg=azure-graphrbac&subdirectory=azure-graphrbac"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5417#egg=azure-graphrbac&subdirectory=azure-graphrbac"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_5417
  • pip install -e ./azure-graphrbac

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_5417
  • pip wheel --no-deps ./azure-graphrbac

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

Codecov Report

Merging #4605 into restapi_auto_graphrbac/data-plane will decrease coverage by <.01%.
The diff coverage is 27.58%.

Impacted file tree graph

@@                          Coverage Diff                          @@
##           restapi_auto_graphrbac/data-plane    #4605      +/-   ##
=====================================================================
- Coverage                               49.5%    49.5%   -0.01%     
=====================================================================
  Files                                   6332     6333       +1     
  Lines                                 177160   177188      +28     
=====================================================================
+ Hits                                   87710    87717       +7     
- Misses                                 89450    89471      +21
Impacted Files Coverage Δ
...re/graphrbac/operations/applications_operations.py 34.1% <10.52%> (-1.88%) ⬇️
...phrbac/models/application_create_parameters_py3.py 100% <100%> (ø) ⬆️
azure-graphrbac/azure/graphrbac/models/__init__.py 56.12% <50%> (-0.13%) ⬇️
...rbac/models/service_principal_object_result_py3.py 57.14% <57.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecaf7af...a681282. Read the comment docs.

@AutorestCI AutorestCI merged commit 276c03d into restapi_auto_graphrbac/data-plane Mar 20, 2019
@AutorestCI AutorestCI deleted the restapi_auto_5417 branch March 20, 2019 00:23
@AutorestCI
Copy link
Contributor Author

This PR has been merged into #4574

lmazuel pushed a commit that referenced this pull request Mar 20, 2019
@AutorestCI @lmazuel
[AutoPR] graphrbac/data-plane (#4574)
a5f9f13 
* Generated from 3629fae01bc487f4fc43de1182b86f20eafdc81d (#4573)

typo: graphrbac/data-plane/Microsoft.GraphRbac/stable/1.6

- requied -> required
- authorizaed -> authorized
- Organizatio -> Organization
- Allorganizations -> AllOrganizations
- Microsof -> Microsoft
- perperties -> prorperties
- servie -> service
- altenative -> alternative
- thubmbprint -> thumbprint

* Generated from 5335c9316f894ab4060d031632b8fdd168386829 (#4613)

graph: identifierUris should not be required

* [AutoPR graphrbac/data-plane] Add service principals by app id microsoft.graph rbac (#4605)

* Generated from 9f615cc6b8f1dd194512f725b3e6655314c95e1e

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs into add-servicePrincipalsByAppId-Microsoft.GraphRbac

* Generated from cec3f8a6bcad7e1b69f227281eb1a984180a4090

Update graphrbac.json

* Generated from 1ba20d49c738fb00f7e75e227c3ab92d9c7be54d

Update graphrbac.json

* Generated from 42b9031222de601bb4b5fb67995b60a64712f81b

Update graphrbac.json

* Generated from 6afb048f96472417e5cadf45df930eb381f4ad3b

Update graphrbac.json

* Adding tests for get_service_principals_id_by_app_id

* 0.61.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees
No one assigned
Labels
RestPRMerged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AutorestCI @codecov-io @lmazuel