Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service principals by app id microsoft.graph rbac #5417

Merged
merged 6 commits into from
Mar 20, 2019
Merged

Add service principals by app id microsoft.graph rbac #5417

merged 6 commits into from
Mar 20, 2019

Conversation

ankushbindlish2
Copy link
Member

@ankushbindlish2 ankushbindlish2 commented Mar 18, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Previous PR: #5387
Why we are doing this ?
This service already exposed this method and it should be safe to add into swagger.
We are trying to get Application Object for a guest user with default privileges.

Example : GET /72f988bf-86f1-41af-91ab-2d7cd011db47/servicePrincipalsByAppId/9469b9f5-6722-4481-a2b2-14ed560b706f/objectId?api-version=1.6 HTTP/1.1
{"odata.metadata":"https://graph.windows.net/72f988bf-86f1-41af-91ab-2d7cd011db47/$metadata#Edm.String","value":"3eb9d9f3-371c-4d24-a60a-d7681c48c071"}

https://docs.microsoft.com/en-us/previous-versions/azure/ad/graph/api/functions-and-actions#serviceprincipalsbyappid-get-service-principal-object-id-by-application-id--

Example : GET /72f988bf-86f1-41af-91ab-2d7cd011db47/servicePrincipalsByAppId/9469b9f5-6722-4481-a2b2-14ed560b706f/objectId?api-version=1.6 HTTP/1.1
{"odata.metadata":"https://graph.windows.net/72f988bf-86f1-41af-91ab-2d7cd011db47/$metadata#Edm.String","value":"3eb9d9f3-371c-4d24-a60a-d7681c48c071"}
…into add-servicePrincipalsByAppId-Microsoft.GraphRbac
@AutorestCI
Copy link

AutorestCI commented Mar 18, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4574

@AutorestCI
Copy link

AutorestCI commented Mar 18, 2019

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#1651

@AutorestCI
Copy link

AutorestCI commented Mar 18, 2019

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2319

@AutorestCI
Copy link

AutorestCI commented Mar 18, 2019

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Mar 18, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Mar 18, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@ankushbindlish2 ankushbindlish2 requested a review from grlin March 18, 2019 19:14
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 18, 2019
REST Spec PR 'Azure/azure-rest-api-specs#5417'
REST Spec PR Author 'ankushbindlish2'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented Mar 18, 2019

@dsgouda dsgouda added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 18, 2019
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@sergey-shandar sergey-shandar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 18, 2019
@sergey-shandar
Copy link
Contributor

@darshanhs90 are you ok with the changes?

@sergey-shandar sergey-shandar mentioned this pull request Mar 19, 2019
5 tasks
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 19, 2019
REST Spec PR 'Azure/azure-rest-api-specs#5417'
REST Spec PR Author 'ankushbindlish2'
REST Spec PR Last commit
@sergey-shandar
Copy link
Contributor

@lmazuel Are you ok with the changes?

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually tested the Python code from this, and it works

@lmazuel lmazuel merged commit 86b3031 into Azure:master Mar 20, 2019
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 20, 2019
REST Spec PR 'Azure/azure-rest-api-specs#5417'
REST Spec PR Author 'ankushbindlish2'
REST Spec PR Last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.