[AutoPR web/resource-manager] Update UserAssignedIdentities spec in Web #4448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update UserAssignedIdentities spec in Web Microsoft.Web recently added support for UserAssigned managed service identities (in preview), but the swagger spec is incorrect for the identity payload as it follows the old construct of sending an array of identityIds as opposed to the updated spec which instead sends a dictionary object called userAssignedIdentities. Spec + history outlined here: http://sharepoint/sites/AzureUX/Sparta/_layouts/15/WopiFrame2.aspx?sourcedoc=%7b633632B4-02E4-4DE2-92A9-EDCAF9BE73D4%7d&file=ARM%2BMSI.docx&action=default Our swagger contains identityids[] because of previous work to future support UserAssigned identities, but never released the feature in that state, rather we opted to wait for the new spec to be supported and then integrated with that on our end. Our MSI implementation reflects Microsoft.Compute's spec for user assigned. https://github.com/Azure/azure-rest-api-specs/blob/78e1feab142c605839aa3cec23442ca26b8ef04d/specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json
5 tasks
|
(message created by the CI based on PR content) Installation instructionPackage azure-mgmt-webYou can install the package You can build a wheel to distribute for test using the following command: If you have a local clone of this repository, you can also do:
Or build a wheel file to distribute for testing:
Direct downloadYour files can be directly downloaded here: |
Codecov Report
@@ Coverage Diff @@
## restapi_auto_web/resource-manager #4448 +/- ##
=====================================================================
+ Coverage 49.53% 53.38% +3.84%
=====================================================================
Files 6227 10460 +4233
Lines 174600 219487 +44887
=====================================================================
+ Hits 86491 117166 +30675
- Misses 88109 102321 +14212
Continue to review full report at Codecov.
|
|
This PR has been merged into #4429 |
lmazuel
pushed a commit
that referenced
this pull request
May 24, 2019
* Generated from b358cc2d9448ec292d6d67de69f587080731c85e (#4428) Add examples of 201 response to AppServicePlans_CreateOrUpdate. * Generated from c2d7ae74564edf027d2baa5d39864ba26a4f593a (#4448) Update UserAssignedIdentities spec in Web Microsoft.Web recently added support for UserAssigned managed service identities (in preview), but the swagger spec is incorrect for the identity payload as it follows the old construct of sending an array of identityIds as opposed to the updated spec which instead sends a dictionary object called userAssignedIdentities. Spec + history outlined here: http://sharepoint/sites/AzureUX/Sparta/_layouts/15/WopiFrame2.aspx?sourcedoc=%7b633632B4-02E4-4DE2-92A9-EDCAF9BE73D4%7d&file=ARM%2BMSI.docx&action=default Our swagger contains identityids[] because of previous work to future support UserAssigned identities, but never released the feature in that state, rather we opted to wait for the new spec to be supported and then integrated with that on our end. Our MSI implementation reflects Microsoft.Compute's spec for user assigned. https://github.com/Azure/azure-rest-api-specs/blob/78e1feab142c605839aa3cec23442ca26b8ef04d/specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json * Packaging update of azure-mgmt-web * [AutoPR web/resource-manager] [Hub Generated] Review request for Microsoft.Web to add version 2018-02-01 (#4436) * Generated from b772c09b4e8132be83594f0a834cf7b363445a3c Address PR description feedback * Generated from 61d39f048374e3c8dd07112e7d9e8554e8664ea5 Fix casing * Packaging update of azure-mgmt-web * Generated from 66114e58530dd7027b63182defcf1c8f73d1d502 Remove incorrect pagination from examples. * Generated from 13b235cccbe934e60dba491a2a49edcae9c7f275 (#4481) Fix Hosting Environment Network Dependencies pagination * [AutoPR web/resource-manager] Update managedserviceidentity type enum (#4761) * Generated from d605882bdcb7e402badbf4aeca8d66f20a9d197e Update managedserviceidentity type enum Enum is currently missing the ua + sa combination + "none" type. We do support those values in our API and as such need the swagger to reflect that. * Packaging update of azure-mgmt-web * Generated from 215b006997fc053d43337cd0455d8bdfdbe18898 (#4768) Add Managed Identity envelope to SitePatchResource Add Managed Identity envelope to SitePatchResource object to allow PATCH identity operations to a site through Swagger * [AutoPR web/resource-manager] VnetInfo CertBlob format changed to string (#4860) * Generated from d0b3b0dc2238ba14b6a41ced8e7ce66e3755f279 VnetInfo CertBlob format changed to string * Packaging update of azure-mgmt-web * Generated from 310b5ada2616fb0b8f5808d6d1422df350d459e6 (#5169) Add examples * Generated from ca964030410907fee5bc6c2e08d6e5dd934e49a3 (#5190) Add Source Web App Location * Generated from 96295fc95567dcd52215bafad85d53dc931adc32 (#5212) Add Api-version 2018-11-01 for WebApps Collection Add package Tag Fix path to common definitions * Web in new folder * Generated from ac4cdaf9da165cd1951ce8e10cdd63c78ff04612 (#5472) Web new path * ChangeLog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to sync Azure/azure-rest-api-specs#5288