Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR] web/resource-manager #4429

Merged
merged 15 commits into from
May 24, 2019
Merged

Conversation

AutorestCI
Copy link
Contributor

Created to accumulate context: web/resource-manager

Add examples of 201 response to AppServicePlans_CreateOrUpdate.
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Feb 26, 2019

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-web

You can install the package azure-mgmt-web of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_web/resource-manager#egg=azure-mgmt-web&subdirectory=azure-mgmt-web"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_web/resource-manager#egg=azure-mgmt-web&subdirectory=azure-mgmt-web"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_web/resource-manager
  • pip install -e ./azure-mgmt-web

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_web/resource-manager
  • pip wheel --no-deps ./azure-mgmt-web

Direct download

Your files can be directly downloaded here:

Update UserAssignedIdentities spec in Web

Microsoft.Web recently added support for UserAssigned managed service identities (in preview), but the swagger spec is incorrect for the identity payload as it follows the old construct of sending an array of identityIds as opposed to the updated spec which instead sends a dictionary object called userAssignedIdentities. 

Spec + history outlined here:
http://sharepoint/sites/AzureUX/Sparta/_layouts/15/WopiFrame2.aspx?sourcedoc=%7b633632B4-02E4-4DE2-92A9-EDCAF9BE73D4%7d&file=ARM%2BMSI.docx&action=default 

Our swagger contains identityids[] because of previous work to future support UserAssigned identities, but never released the feature in that state, rather we opted to wait for the new spec to be supported and then integrated with that on our end. 

Our MSI implementation reflects Microsoft.Compute's spec for user assigned.

https://github.com/Azure/azure-rest-api-specs/blob/78e1feab142c605839aa3cec23442ca26b8ef04d/specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json
azuresdkci and others added 2 commits March 4, 2019 16:16
…osoft.Web to add version 2018-02-01 (#4436)

* Generated from b772c09b4e8132be83594f0a834cf7b363445a3c

Address PR description feedback

* Generated from 61d39f048374e3c8dd07112e7d9e8554e8664ea5

Fix casing

* Packaging update of azure-mgmt-web

* Generated from 66114e58530dd7027b63182defcf1c8f73d1d502

Remove incorrect pagination from examples.
Fix Hosting Environment Network Dependencies pagination
…#4761)

* Generated from d605882bdcb7e402badbf4aeca8d66f20a9d197e

Update managedserviceidentity type enum

Enum is currently missing the ua + sa combination + "none" type. We do support those values in our API and as such need the swagger to reflect that.

* Packaging update of azure-mgmt-web
Add Managed Identity envelope to SitePatchResource

Add Managed Identity envelope to SitePatchResource object to allow PATCH identity operations to a site through Swagger
…ing (#4860)

* Generated from d0b3b0dc2238ba14b6a41ced8e7ce66e3755f279

VnetInfo CertBlob format changed to string

* Packaging update of azure-mgmt-web
Add Api-version 2018-11-01 for WebApps Collection

Add package Tag

Fix path to common definitions
@panchagnula
Copy link

@yugangw-msft can we merge these changes & release a new Python SDK?

@panchagnula
Copy link

BTW the released version of Python SDK is azure-mgmt-web-0.41.0, however, this version is azure_mgmt_web-0.36.0, any reason the version is downgraded?

@panchagnula
Copy link

@lmazuel can you help with this SDK release please?

@lmazuel lmazuel merged commit d98b4cc into master May 24, 2019
@lmazuel lmazuel deleted the restapi_auto_web/resource-manager branch May 24, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants