Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cosmos] Resiliency and Documentation Improvements #36514

Merged
merged 44 commits into from
Oct 7, 2024
Merged

[Cosmos] Resiliency and Documentation Improvements #36514

merged 44 commits into from
Oct 7, 2024

Conversation

simorenoh
Copy link
Member

@simorenoh simorenoh commented Jul 18, 2024 •
edited
Loading

This PR improves and fixes some functionality that was missing in the SDK. Namely, this PR includes:

  • New logic to retry ServiceRequestErrors up to three times before failing the request, ensuring that requests that were not reaching the service can attempt to run more than once.
  • Bugfix on a client hang that would happen when switching write regions in an account (running into 403/3 write forbidden error). SDK no longer hangs attempting to resolve the locational endpoint and now properly routes requests. This also adds write failover logic to the SDK.
  • Adding retry mechanisms for 403/1008 database account not found errors.
  • Small enhancements to our session retry logic and global endpoint manager refreshes, namely updating the locking logic to the same as async (slightly faster in deciding whether lock is needed) and adding locational routing to 404/1002 retries.
  • Documentation updates on our client configurations, becoming more specific on what each setting does.
  • Fixes bug introduced in PR 31096 which removed 503 retries from the SDK.
  • Adds logic to properly refresh the location cache information in the SDK every 5 minutes.

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-cosmos

@simorenoh simorenoh marked this pull request as ready for review July 18, 2024 15:54
@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

xinlian12
xinlian12 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh simorenoh mentioned this pull request Oct 4, 2024
Closed
@simorenoh simorenoh merged commit f8ab118 into Azure:main Oct 7, 2024
27 checks passed
@simorenoh simorenoh deleted the retry_validations branch October 7, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bambriz bambriz bambriz left review comments

@annatisch annatisch annatisch left review comments

@jeet1995 jeet1995 jeet1995 approved these changes

@xinlian12 xinlian12 xinlian12 approved these changes

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
Cosmos
Projects
CosmosDB Python Eco-System
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@simorenoh @azure-sdk @bambriz @annatisch @jeet1995 @xinlian12