[Cosmos] Next-Pylint support

sdk/cosmos/azure-cosmos/azure/cosmos/_auth_policy.py

@@ -105,8 +105,10 @@ def send(self, request):
         # type: (PipelineRequest) -> PipelineResponse
         """Authorize request with a bearer token and send it to the next policy
 
-        :param request: The pipeline request object
+        :param request: The pipeline request object.
         :type request: ~azure.core.pipeline.PipelineRequest
+        :returns: The pipeline response object.
+        :rtype: ~azure.core.pipeline.PipelineResponse
         """
         self.on_request(request)
         try:
@@ -138,9 +140,10 @@ def on_challenge(self, request, response):
 
         :param ~azure.core.pipeline.PipelineRequest request: the request which elicited an authentication challenge
         :param ~azure.core.pipeline.PipelineResponse response: the resource provider's response
-        :returns: a bool indicating whether the policy should send the request
+        :returns: a boolean indicating whether the policy should send the request
+        :rtype: bool
         """
-        # pylint:disable=unused-argument,no-self-use
+        # pylint:disable=unused-argument
         return False
 
     def on_response(self, request, response):
@@ -162,5 +165,5 @@ def on_exception(self, request):
         :param request: The Pipeline request object
         :type request: ~azure.core.pipeline.PipelineRequest
         """
-        # pylint: disable=no-self-use,unused-argument
+        # pylint: disable=unused-argument
         return

sdk/cosmos/azure-cosmos/azure/cosmos/_base.py

@@ -110,7 +110,7 @@ def GetHeaders(  # pylint: disable=too-many-statements,too-many-branches
 ):
     """Gets HTTP request headers.
 
-    :param cosmos_client_connection.CosmosClient cosmos_client:
+    :param _cosmos_client_connection.CosmosClientConnection cosmos_client_connection:
     :param dict default_headers:
     :param str verb:
     :param str path:
@@ -229,10 +229,11 @@ def GetHeaders(  # pylint: disable=too-many-statements,too-many-branches
         headers[http_constants.HttpHeaders.PopulateQueryMetrics] = options["populateQueryMetrics"]
 
     if options.get("responseContinuationTokenLimitInKb"):
-        headers[http_constants.HttpHeaders.ResponseContinuationTokenLimitInKb] = options["responseContinuationTokenLimitInKb"]  # pylint: disable=line-too-long
+        headers[http_constants.HttpHeaders.ResponseContinuationTokenLimitInKb] = options[
+            "responseContinuationTokenLimitInKb"]
 
     if cosmos_client_connection.master_key:
-        #formatedate guarantees RFC 1123 date format regardless of current locale
+        # formatedate guarantees RFC 1123 date format regardless of current locale
         headers[http_constants.HttpHeaders.XDate] = formatdate(timeval=None, localtime=False, usegmt=True)
 
     if cosmos_client_connection.master_key or cosmos_client_connection.resource_tokens:
@@ -491,7 +492,7 @@ def IsItemContainerLink(link):  # pylint: disable=too-many-return-statements
     return True
 
 
-def GetItemContainerInfo(self_link, alt_content_path, id_from_response):
+def GetItemContainerInfo(self_link, alt_content_path, resource_id):
     """Given the self link and alt_content_path from the response header and
     result extract the collection name and collection id.
 
@@ -521,13 +522,13 @@ def GetItemContainerInfo(self_link, alt_content_path, id_from_response):
             # this is a collection request
             index_second_slash = IndexOfNth(alt_content_path, "/", 2)
             if index_second_slash == -1:
-                collection_name = alt_content_path + "/colls/" + urllib_quote(id_from_response)
+                collection_name = alt_content_path + "/colls/" + urllib_quote(resource_id)
                 return collection_id, collection_name
             collection_name = alt_content_path
             return collection_id, collection_name
         raise ValueError(
             "Response Not from Server Partition, self_link: {0}, alt_content_path: {1}, id: {2}".format(
-                self_link, alt_content_path, id_from_response
+                self_link, alt_content_path, resource_id
             )
         )
 
@@ -700,11 +701,11 @@ def _set_throughput_options(offer: Union[int, ThroughputProperties], request_opt
             if offer.offer_throughput:
                 request_options["offerThroughput"] = offer.offer_throughput
 
-        except AttributeError:
+        except AttributeError as e:
             if isinstance(offer, int):
                 request_options["offerThroughput"] = offer
             else:
-                raise TypeError("offer_throughput must be int or an instance of ThroughputProperties")
+                raise TypeError("offer_throughput must be int or an instance of ThroughputProperties") from e
 
 
 def _deserialize_throughput(throughput: list) -> Any:
@@ -739,18 +740,21 @@ def _replace_throughput(throughput: Union[int, ThroughputProperties], new_throug
             if throughput.offer_throughput:
                 new_throughput_properties["content"]["offerThroughput"] = throughput.offer_throughput
 
-    except AttributeError:
+    except AttributeError as e:
         if isinstance(throughput, int):
             new_throughput_properties["content"]["offerThroughput"] = throughput
         else:
-            raise TypeError("offer_throughput must be int or an instance of ThroughputProperties")
+            raise TypeError("offer_throughput must be int or an instance of ThroughputProperties") from e
 
 
 def _internal_resourcetype(resource_type: str) -> str:
-    """Partitionkey is used as the resource type for deleting all items by partition key in
-    other SDKs, but the colls resource type needs to be sent for the feature to work. In order to keep it consistent
+    """Partition key is used as the resource type for deleting all items by partition key in other SDKs,
+    but the colls (collection) resource type needs to be sent for the feature to work. In order to keep it consistent
     with other SDKs, we switch it here.
+    :param str resource_type: the resource type
+    :return: the resource type after checking if we're doing partition key delete.
+    :rtype: str
     """
-    if resource_type.lower() ==  "partitionkey":
+    if resource_type.lower() == "partitionkey":
         return "colls"
     return resource_type