Regenerate baseline because last one break. #16415
Conversation
sima-zhu
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
| "demobaseline": { | ||
| "name": "demobaseline", | ||
| "createdDate": "2021-01-29 00:29:11Z", | ||
| "lastUpdatedDate": "2021-01-29 00:29:11Z" | ||
| } | ||
| }, | ||
| "results": { |
There was a problem hiding this comment.
Can we wait and update these baseline files once we get better suppression rules? I don't want these baseline files to constantly need updated based on any change and I'd like them to be much smaller if we get good placeholder values.
There was a problem hiding this comment.
We changed this because guardian team introduced some breaking changes which they do not recognize the errors in baseline file.
The baseline file does not affect how we do the suppression. It is better to merge the baseline file first, and come up with the suppression strategy in the meanwhile
There was a problem hiding this comment.
My expectation is that this baseline file will be much smaller once we do the suppressions. If we plan to update it then that is fine but I want to be careful that we don't have to have lots of folks updating this baseline file all the time.
There was a problem hiding this comment.
Currently, we have two purposes for putting baseline file here:
- Leave time for owner to address the existing errors.
- Catch new issue introduced to packages.
I think #2 is more crucial for our cred scan steps right now. The baseline file help us achieve the purpose, so it is necessary to check in now.
As for #1, I plan to do some suppression on some obvious fake ones. Then we indeed need help from language owner.
eng/pipelines/aggregate-reports.yml
Outdated
| @@ -53,8 +34,32 @@ jobs: | |||
| pwsh: true | |||
| workingDirectory: $(Build.SourcesDirectory) | |||
| filePath: eng/common/scripts/Verify-Resource-Ref.ps1 | |||
|
|
|||
| - template: /eng/pipelines/templates/steps/analyze_dependency.yml | |||
There was a problem hiding this comment.
What was this order changed? I think this needs to be moved back.
There was a problem hiding this comment.
Yes, copy paste more than I need. Will move it backl
| # GdnBreakOutputBaseline: baseline | ||
| - task: securedevelopmentteam.vss-secure-development-tools.build-task-publishsecurityanalysislogs.PublishSecurityAnalysisLogs@3 | ||
| displayName: 'Publish Security Analysis Logs' | ||
| continueOnError: true |
There was a problem hiding this comment.
We should remove this now that the baseline is updated.
…into analyze_redesign * 'master' of https://github.com/Azure/azure-sdk-for-python: (35 commits) Sync eng/common directory with azure-sdk-tools for PR 1353 (Azure#16465) Normalize the package name for Doc.Ms readme (Azure#16401) fix changelog and version (Azure#16445) we should always run integration to publish from our artifacts. if the build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down (Azure#15058) Fix DateTime bug (Azure#16456) Resolve Regression Failures (Azure#16455) [text analytics] Expose 'string_index_type' parameter in all service client methods where applicable (Azure#16412) adding devtools to the appconfig dev_reqs to solve python core issue (Azure#16381) Copy job matrix functionality (Azure#16450) Add APIView KV variable group to prepare pipelines bot (Azure#16451) [Datalake] Added support for PurePosixPath (Azure#16400) Regenerate baseline because last one break. (Azure#16415) adding step to test for crlf line endings (Azure#16398) [Datalake] Removed list_paths manual paging and deserialization (Azure#16309) Sync eng/common directory with azure-sdk-tools for PR 1351 (Azure#16448) Update auto_codegen.py (Azure#16443) First release purview (Azure#16440) 1ES pools update for release pipeline. (Azure#16419) Add Cloud environment for Teams user (Azure#16359) Sync eng/common directory with azure-sdk-tools for PR 1345 (Azure#16404) ...
…into enum-meta * 'master' of https://github.com/Azure/azure-sdk-for-python: (128 commits) Communication identity api redesign (Azure#16420) fix EH samples and docs (Azure#16457) T2 redisenterprise 2021 02 02 (Azure#16472) Update automation_generate.sh (Azure#16470) Sync eng/common directory with azure-sdk-tools for PR 1353 (Azure#16465) Normalize the package name for Doc.Ms readme (Azure#16401) fix changelog and version (Azure#16445) we should always run integration to publish from our artifacts. if the build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down (Azure#15058) Fix DateTime bug (Azure#16456) Resolve Regression Failures (Azure#16455) [text analytics] Expose 'string_index_type' parameter in all service client methods where applicable (Azure#16412) adding devtools to the appconfig dev_reqs to solve python core issue (Azure#16381) Copy job matrix functionality (Azure#16450) Add APIView KV variable group to prepare pipelines bot (Azure#16451) [Datalake] Added support for PurePosixPath (Azure#16400) Regenerate baseline because last one break. (Azure#16415) adding step to test for crlf line endings (Azure#16398) [Datalake] Removed list_paths manual paging and deserialization (Azure#16309) Sync eng/common directory with azure-sdk-tools for PR 1351 (Azure#16448) Update auto_codegen.py (Azure#16443) ...
Regenerate baseline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=708546&view=results