Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly publish to dev feed should run regardless of test outcome #15058

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Nov 6, 2020

We should always run integration to publish from our artifacts. If the build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down.

While this doesn't address the chicken/egg problem caused from checking in a version bump of azure-core + a dependency version bump in the same day, it will definitely enable the pipeline to self-mitigate that problem. It'll fail for a night, then resume normal operations the next day.

…e build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this change although it is a little odd so it is probably worth adding a comment about why this condition is this way.

@scbedd scbedd merged commit a1a3969 into Azure:master Feb 2, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Feb 2, 2021
…into analyze_redesign

* 'master' of https://github.com/Azure/azure-sdk-for-python: (35 commits)
  Sync eng/common directory with azure-sdk-tools for PR 1353 (Azure#16465)
  Normalize the package name for Doc.Ms readme (Azure#16401)
  fix changelog and version (Azure#16445)
  we should always run integration to publish from our artifacts. if the build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down (Azure#15058)
  Fix DateTime bug (Azure#16456)
  Resolve Regression Failures (Azure#16455)
  [text analytics] Expose 'string_index_type' parameter in all service client methods where applicable (Azure#16412)
  adding devtools to the appconfig dev_reqs to solve python core issue (Azure#16381)
  Copy job matrix functionality (Azure#16450)
  Add APIView KV variable group to prepare pipelines bot (Azure#16451)
  [Datalake] Added support for PurePosixPath (Azure#16400)
  Regenerate baseline because last one break. (Azure#16415)
  adding step to test for crlf line endings (Azure#16398)
  [Datalake] Removed list_paths manual paging and deserialization (Azure#16309)
  Sync eng/common directory with azure-sdk-tools for PR 1351 (Azure#16448)
  Update auto_codegen.py (Azure#16443)
  First release purview (Azure#16440)
  1ES pools update for release pipeline. (Azure#16419)
  Add Cloud environment for Teams user (Azure#16359)
  Sync eng/common directory with azure-sdk-tools for PR 1345 (Azure#16404)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Feb 2, 2021
…into enum-meta

* 'master' of https://github.com/Azure/azure-sdk-for-python: (128 commits)
  Communication identity api redesign (Azure#16420)
  fix EH samples and docs (Azure#16457)
  T2 redisenterprise 2021 02 02 (Azure#16472)
  Update automation_generate.sh (Azure#16470)
  Sync eng/common directory with azure-sdk-tools for PR 1353 (Azure#16465)
  Normalize the package name for Doc.Ms readme (Azure#16401)
  fix changelog and version (Azure#16445)
  we should always run integration to publish from our artifacts. if the build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down (Azure#15058)
  Fix DateTime bug (Azure#16456)
  Resolve Regression Failures (Azure#16455)
  [text analytics] Expose 'string_index_type' parameter in all service client methods where applicable (Azure#16412)
  adding devtools to the appconfig dev_reqs to solve python core issue (Azure#16381)
  Copy job matrix functionality (Azure#16450)
  Add APIView KV variable group to prepare pipelines bot (Azure#16451)
  [Datalake] Added support for PurePosixPath (Azure#16400)
  Regenerate baseline because last one break. (Azure#16415)
  adding step to test for crlf line endings (Azure#16398)
  [Datalake] Removed list_paths manual paging and deserialization (Azure#16309)
  Sync eng/common directory with azure-sdk-tools for PR 1351 (Azure#16448)
  Update auto_codegen.py (Azure#16443)
  ...
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Jul 15, 2021
Adding compute 2021-04-01 version (Azure#15100)

* initial copy of old files to new folder 2021-04-01

* api version update

* Add SpotRestorePolicy to CRP's VM Scale Set Resource (Azure#14692)

* Resolve merge conflicts after branch recreation

* Fix Lint error

* update with changes mae in 2021-03-01

* Update compute.json

* Update CreateAVmWithNetworkInterfaceConfiguration.json

update example file also to fix breaking change naming issue.

* Feature/cplat 2021 04 01 - Capacity Reservation related changes (Azure#15058)

* updated code

* updated swagger with cr changes

* updated swagger with cr changes

* updated swagger with cr changes

* updated swagger

* updated swagger

* updated swagger

* Feature/cplat 2021 04 01 (Azure#15070)

* 2021-04 initial

* 2021-04 examples and readme

* adding CR VMSS changes

* updating api version in example and description of CR profile

Co-authored-by: Adam Sandor <adsandor@microsoft.com>
Co-authored-by: Theodore Chang <thchan@microsoft.com>

* Update compute.json

* syncronizing 2021-04-01 swagger with changes made in 2021-03-01

Co-authored-by: Sandeep Vishnu <sandeepkv93@gmail.com>
Co-authored-by: hari-bodicherla <43284966+hari-bodicherla@users.noreply.github.com>
Co-authored-by: micahjo <69926788+micahjo@users.noreply.github.com>
Co-authored-by: Adam Sandor <adsandor@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants