Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip automatic API review for management packages #15987

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Skip automatic API review for management packages #15987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions eng/scripts/Language-Settings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,13 @@ function Find-python-Artifacts-For-Apireview($artifactDir, $artifactName)
{
# Find wheel file in given artifact directory
# Make sure to pick only package with given artifact name
# Skip auto API review creation for management packages
if ($artifactName -match "mgmt")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please get confirmation from some one on the mgmt team so they are aware this is happening and can confirm this is what they want?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have discussed this with Anna and Johan about this and making this change as per their request. Will definitely send a note to mgmt team also. I have a call with management team tomorrow. But I would like to disable auto reviews for the time being for management plane until they agree to approve reviews.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to be sure we are including them in the conversation and not just making decisions on their behalf. If it is easier to disable them for now that is fine just be sure to start the conversation with them.

{
Write-Host "Skipping automatic API review for management artifact $($artifactName)"
return $null
}

$packageName = $artifactName + "-"
Write-Host "Searching for $($packageName) wheel in artifact path $($artifactDir)"
$files = Get-ChildItem "${artifactDir}" | Where-Object -FilterScript {$_.Name.StartsWith($packageName) -and $_.Name.EndsWith(".whl")}
Expand Down