Skip automatic API review for management packages #15987
Conversation
praveenkuttappan
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
|
/azp run python - template |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -185,6 +185,13 @@ function Find-python-Artifacts-For-Apireview($artifactDir, $artifactName) | |||
| { | |||
| # Find wheel file in given artifact directory | |||
| # Make sure to pick only package with given artifact name | |||
| # Skip auto API review creation for management packages | |||
| if ($artifactName -match "mgmt") | |||
There was a problem hiding this comment.
Can we please get confirmation from some one on the mgmt team so they are aware this is happening and can confirm this is what they want?
There was a problem hiding this comment.
I have discussed this with Anna and Johan about this and making this change as per their request. Will definitely send a note to mgmt team also. I have a call with management team tomorrow. But I would like to disable auto reviews for the time being for management plane until they agree to approve reviews.
There was a problem hiding this comment.
I just want to be sure we are including them in the conversation and not just making decisions on their behalf. If it is easier to disable them for now that is fine just be sure to start the conversation with them.
|
/check-enforcer override |
api management events schema (Azure#15987) * add swagger * align * rephrase * resolvemergeconflict * comments * examples * prettier * comments * pascal Co-authored-by: Kacie Kang <jikang@microsoft.com>
Skip automatic review creation for management packages since these are not currently reviewed by architects