Align recent changes with Swagger #7016
Conversation
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
@tomersh26 , could you please:
- Provide the swagger spec PR link related to
- Follow the process to regenerate source code
| - Add Partition settings for Oracle, SapTable | ||
| - Add dedicated source and dataset for several relational sources including ODBC, MySql | ||
| - Add Azure Data Explorer Command activity, which allows users executing Kusto Control Commands | ||
| ### Breaking Changes |
There was a problem hiding this comment.
This is not a breaking change - you are adding new parameters to the constructor that have default values at the end, so it won't break existing customers. Remove this line.
There was a problem hiding this comment.
This PR contains both my change and Wenbo's changes. The note under the Breaking Changes is Wenbo's note which is related to her changes in PostgreSql.
You can have a look at her original PR which I took and integrated into my PR: 10fec6d.
| @@ -3,6 +3,15 @@ | |||
| ## Current version | |||
| ### Feature Additions | |||
|
|
|||
| ## Version 4.1.1 | |||
| ### Feature Additions | |||
There was a problem hiding this comment.
Copy this whole section to csproj file for Datafactory, and update the version there to 4.1.1.
Also update AssemblyFileVersion to 4.1.1.0 in Properties
There was a problem hiding this comment.
I guess you meant changing both the AssemblyFileVersion and the AssemblyVersion under the AssemblyInfo.cs file. I changed them both to 4.1.1.0.
.../Microsoft.Azure.Management.DataFactory/src/Generated/SdkInfo_DataFactoryManagementClient.cs
Outdated
Show resolved
Hide resolved
@erich-wang - It seems that i don't have permissions to that link. I'm getting an error 400 - Page not found. In general, I've followed the process as I was guided by ADMS folks. I used autorest providing a path to the recent changes for the public swagger, and wrote all the required tests. |
|
@tomersh26, are you from Microsoft? If yes, you should first link your github account with microsoft email and join Azure organization, then you should be able to see the link since it is in private repo.
|
|
@tomersh26, I did not see eng\mgmt\mgmtmetadata<rpName>.txt which should be in PR if you follow the latest process. |
No description provided.