Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory]Add AzurePostgreSql Sink and Oracle/SapTable/Netezza Partitions and Several Relational sets #6617

Merged
merged 8 commits into from
Jul 19, 2019

Conversation

wenbof-zz
Copy link

@wenbof-zz wenbof-zz commented Jul 15, 2019

…titoins and dedicated datasets for relational

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

…titoins and dedicated datasets for relational
@wenbof-zz
Copy link
Author

The local SDK building and testing looks good. Details can be referred from https://github.com/wenbof/azure-sdk-for-net/tree/b0715

@AutorestCI
Copy link

AutorestCI commented Jul 15, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5747

@AutorestCI
Copy link

AutorestCI commented Jul 15, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5309

@AutorestCI
Copy link

AutorestCI commented Jul 15, 2019

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#3084

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@praries880 praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 16, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2019

SDK Automation [Logs] (Generated from 7f632e8, Iteration 4)

Failed Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • Failed sdk/datafactory/azure-mgmt-datafactory [Logs]
In-Progress Java: Azure/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: Azure/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: Azure/azure-sdk-for-js [Logs]
  • Package generation in progress.

@wenbof-zz
Copy link
Author

@praries880 Ping... could you please review? thanks.

@praries880
Copy link

@KrisBash can you kindly review this?

@wenbof-zz
Copy link
Author

SDK Automation [Logs] (Generated from 8b1eb70, Iteration 1)

Failed Python: Azure/azure-sdk-for-python [Logs]
Failed Java: Azure/azure-sdk-for-java [Logs]
Failed Go: Azure/azure-sdk-for-go [Logs]
Failed JavaScript: Azure/azure-sdk-for-js [Logs]

I executed AUTOREST locally while it seems there is no error. the targeted line 1489:4, 1472:4 looks good as well. I also built local SDK which can be built successfully. if there are any changes needed from my side, could you please advise? thanks

Line 1472 "SybaseTableDataset": {
"x-ms-discriminator-value": "SybaseTable",
"description": "The Sybase table dataset.",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/Dataset"
}
],
"properties": {
"typeProperties": {
"description": "Sybase table dataset properties.",
"x-ms-client-flatten": true,
"$ref": "#/definitions/SybaseTableDatasetTypeProperties"
}
}
},
Line 1489 "SybaseTableDatasetTypeProperties": {
"description": "Sybase table dataset properties.",
"properties": {

@wenbof-zz
Copy link
Author

+@hvermis

@wenbof-zz
Copy link
Author

@hvermis , @praries880 , @KrisBash Ping... could you please kindly review and merge? thanks.

@hvermis
Copy link
Contributor

hvermis commented Jul 19, 2019

@KrisBash Waiting for you review to unblock our SDK release, please help.
This is very similar to other one you reviewed couple days ago.

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed potential-sdk-breaking-change labels Jul 19, 2019
@praries880 praries880 merged commit 05a52c5 into Azure:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants