-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FrontDoor WAF API to 2019-03-01-preview #5556
Update FrontDoor WAF API to 2019-03-01-preview #5556
Conversation
REST Spec PR 'Azure/azure-rest-api-specs#5437' REST Spec PR Author 'eschwabe' REST Spec PR Last commit
REST Spec PR 'Azure/azure-rest-api-specs#5437' REST Spec PR Author 'eschwabe' REST Spec PR Last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use generate.ps1 to generate the code and commit all changes
@@ -7,7 +7,7 @@ | |||
<PackageId>Microsoft.Azure.Management.FrontDoor</PackageId> | |||
<Description>Provides management capabilities for Front Door services.</Description> | |||
<AssemblyName>Microsoft.Azure.Management.FrontDoor</AssemblyName> | |||
<Version>0.11.0-preview</Version> | |||
<Version>0.12.0-preview</Version> | |||
<PackageTags>Microsoft Azure Front Door management;FrontDoor;Front Door management;</PackageTags> | |||
<PackageReleaseNotes> | |||
Fixed a regression in enable/disable https for custom domain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update packagereleasenotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* .NET SDK Resource Provider:'FrontDoor' REST Spec PR 'Azure/azure-rest-api-specs#5437' REST Spec PR Author 'eschwabe' REST Spec PR Last commit * .NET SDK Resource Provider:'FrontDoor' REST Spec PR 'Azure/azure-rest-api-specs#5437' REST Spec PR Author 'eschwabe' REST Spec PR Last commit * Fix unit tests to work with 2019-03-01-preview API * Update package version * Regenerate FrontDoor SDK and update unit tests
This PR supersedes the automated PR 5527.