Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FrontDoor WAF API with new preview features (2019-03-01) #5437

Merged
merged 3 commits into from
Mar 21, 2019
Merged

Update FrontDoor WAF API with new preview features (2019-03-01) #5437

merged 3 commits into from
Mar 21, 2019

Conversation

eschwabe
Copy link
Contributor

Review Status

The new WAF API version has already been reviewed in the private repo (PR 690).

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci azuresdkci requested a review from dsgouda March 20, 2019 17:47
@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Mar 20, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4643

@AutorestCI AutorestCI mentioned this pull request Mar 20, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1707

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Mar 20, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#5021

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 20, 2019
@adxsdknet
.NET SDK Resource Provider:'FrontDoor'
0a5332d 
REST Spec PR 'Azure/azure-rest-api-specs#5437'
REST Spec PR Author 'eschwabe'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5527
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@0a5332d
adxsdknet/azure-sdk-for-net@5c7fe2c

@dsgouda
Copy link
Contributor

dsgouda commented Mar 20, 2019

Got some other deliverables, reassigning this one.

@azuresdkci azuresdkci assigned sergey-shandar and unassigned dsgouda Mar 20, 2019
This was referenced Mar 20, 2019
Closed
Closed
@eschwabe
Copy link
Contributor Author

API changes have already been reviewed in the private repo (PR 690).

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 20, 2019
@adxsdknet
.NET SDK Resource Provider:'FrontDoor'
5c7fe2c 
REST Spec PR 'Azure/azure-rest-api-specs#5437'
REST Spec PR Author 'eschwabe'
REST Spec PR Last commit
@sergey-shandar sergey-shandar merged commit ee3e1a1 into Azure:master Mar 21, 2019
@AutorestCI AutorestCI mentioned this pull request Mar 21, 2019
Merged
@AutorestCI AutorestCI mentioned this pull request Mar 21, 2019
Merged
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 25, 2019
@eschwabe @dsgouda
Update FrontDoor WAF API to 2019-03-01-preview (#5556)
0b205af 
* .NET SDK Resource Provider:'FrontDoor'
REST Spec PR 'Azure/azure-rest-api-specs#5437'
REST Spec PR Author 'eschwabe'
REST Spec PR Last commit

* .NET SDK Resource Provider:'FrontDoor'
REST Spec PR 'Azure/azure-rest-api-specs#5437'
REST Spec PR Author 'eschwabe'
REST Spec PR Last commit

* Fix unit tests to work with 2019-03-01-preview API

* Update package version

* Regenerate FrontDoor SDK and update unit tests
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@eschwabe @mentat9
Update FrontDoor WAF API to 2019-03-01-preview (Azure#5556)
0ee1100 
* .NET SDK Resource Provider:'FrontDoor'
REST Spec PR 'Azure/azure-rest-api-specs#5437'
REST Spec PR Author 'eschwabe'
REST Spec PR Last commit

* .NET SDK Resource Provider:'FrontDoor'
REST Spec PR 'Azure/azure-rest-api-specs#5437'
REST Spec PR Author 'eschwabe'
REST Spec PR Last commit

* Fix unit tests to work with 2019-03-01-preview API

* Update package version

* Regenerate FrontDoor SDK and update unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@dsgouda dsgouda Awaiting requested review from dsgouda

Assignees

@sergey-shandar sergey-shandar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eschwabe @AutorestCI @azuresdkci @adxsdknet @dsgouda @sergey-shandar