-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a props file used to include Azure.Base in the project. #5342
Merged
AlexGhiondea
merged 4 commits into
Azure:master
from
AlexGhiondea:CreatePropsFileForImportingBase
Mar 13, 2019
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9919315
Create a props file used to include Azure.Base in the project.
AlexGhiondea 41913cd
Rebased on top of latest master
AlexGhiondea 00cbd22
Rebase on top of master
AlexGhiondea e976165
Make sure to use the latest version of the package as well as fixing …
AlexGhiondea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
src/SDKs/Azure.Base/data-plane/Azure.Base/Azure.Base.props
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <!-- Project references --> | ||
| <ItemGroup Condition="'$(UseProjectReferenceToAzureBase)'=='true'"> | ||
| <ProjectReference Include="$(MSBuildThisFileDirectory)Azure.Base.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Package references --> | ||
| <ItemGroup Condition="'$(UseProjectReferenceToAzureBase)'!='true'"> | ||
| <PackageReference Include="Azure.Base" Version="1.0.0-preview.3" /> | ||
| </ItemGroup> | ||
| </Project> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason you added the
$(MSBuildThisFileDirectory)? While it doesn't hurt anything relative paths also resolve correctly so was curious why prompted you to use it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing in particular, just that I've been hurt in the past with relative paths so I wanted to be explicit about them