Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a props file used to include Azure.Base in the project. #5342

Merged
merged 4 commits into from
Mar 13, 2019
Merged

Create a props file used to include Azure.Base in the project. #5342

merged 4 commits into from
Mar 13, 2019

Conversation

AlexGhiondea
Copy link
Contributor

weshaggard
weshaggard reviewed Mar 12, 2019
View reviewed changes
...ation/data-plane/Azure.ApplicationModel.Configuration.Tests/Azure.Configuration.Tests.csproj
@@ -9,20 +9,13 @@
<PackageReference Include="System.Memory" Version="4.5.1" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Azure.ApplicationModel.Configuration\Azure.Configuration.csproj" />
<ProjectReference Include="$(MSBuildThisFileDirectory)..\Azure.ApplicationModel.Configuration\Azure.Configuration.csproj" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason you added the $(MSBuildThisFileDirectory)? While it doesn't hurt anything relative paths also resolve correctly so was curious why prompted you to use it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in particular, just that I've been hurt in the past with relative paths so I wanted to be explicit about them

@AlexGhiondea AlexGhiondea force-pushed the CreatePropsFileForImportingBase branch from 603a62c to 00cbd22 Compare March 13, 2019 20:16
@AlexGhiondea AlexGhiondea merged commit ff8cdb9 into Azure:master Mar 13, 2019
@AlexGhiondea AlexGhiondea deleted the CreatePropsFileForImportingBase branch March 13, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexGhiondea @weshaggard