Add SQL ShortTermRetention, VulnerabilityAssessment, and Elastic jobs #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h Instance Failover Group APIs (Azure#4259) * adding generated files and tests for Cloud Lifter work * updating the SDK version in .csproj and AssemblyInfo.cs files * adding Managed Instance test recording * addressing some comments * changing tabs into spaces * Regen from swagger * Updating the release note with the current changes
Short Term Retention SDK regen and tests
…o grab subscription id from env variable
… Updated tests based on feedback
Turn ON database threat detection as a preprequite to use VA
…s ran msbuild build.proj /t:build /p:Scope=SDs\SqlManagement
This brings in the ShortTermRetention code and tests.
|
Swagger PR: Azure/azure-rest-api-specs#2860 I merged from SqlMgmt-CloudLifter branch, updated tests, then regenerated Swagger from commit f943cdccabceca5467712cf1788cbeb52cbfb25b which is the newest commit that does not contain VA (see #4327) or jobs (see #4340) |
jaredmoo
changed the title
9 tasks
|
Blocking issues:
|
jaredmoo
changed the title
dsgouda
suggested changes
May 22, 2018
|
|
||
| 2) AutoRest information | ||
| Requested version: latest | ||
| Bootstrapper version: C:\Users\jugeorge\AppData\Roaming\npm `-- autorest@2.0.4262 | ||
| Latest installed version: |
There was a problem hiding this comment.
Please generate the code using this script instead
ShortTermRetentionPolicy -> BackupShortTermRetentionPolicy
|
Now I am just waiting for Azure/azure-rest-api-specs#3125 to be merged so I can do the final regen. |
jaredmoo
changed the title
|
Ready to merge |
dsgouda
approved these changes
May 24, 2018
| @@ -23,7 +23,7 @@ | |||
| <PackageReference Include="WindowsAzure.Storage" Version="8.1.4" /> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <!--<PackageReference Include="Microsoft.Azure.Management.Sql" Version="1.15.0-preview" />--> | |||
There was a problem hiding this comment.
You don't really need this line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.