Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New for swagger update #3125

Merged
merged 19 commits into from
May 23, 2018
Merged

New for swagger update #3125

merged 19 commits into from
May 23, 2018

Conversation

yaakoviyun
Copy link
Member

@yaakoviyun yaakoviyun commented May 23, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

yaakoviyun and others added 19 commits May 15, 2018 08:56
@yaakoviyun
Adding Vulnerability Assessment APIs on managed instance
9830af8 
Adding Vulnerability Assessment APIs on managed instance
@yaakoviyun
fixed scan operation id
4cbeeeb
@yaakoviyun
character mismatch fix
4e6e533
@yaakoviyun
Added needed changes to Swagger and exampels
c9142fe 
Added needed changes to Swagger
Azure/azure-sdk-for-net#4327 (review)
@yaakoviyun
Delete managedDatabaseVulnerabilityAssessmentBaselines.json
38b920f
@yaakoviyun
Delete managedDatabaseVulnerabilityAssessmentScans.json
e3caf47
@yaakoviyun
Delete managedDatabaseVulnerabilityAssessments.json
c86bab2
@yaakoviyun
Delete ManagedDatabaseVulnerabilityAssessmentCreateMax.json
caaac4a
@yaakoviyun
Delete ManagedDatabaseVulnerabilityAssessmentCreateMin.json
1ebe82b
@yaakoviyun
Delete ManagedDatabaseVulnerabilityAssessmentDelete.json
ccce3c2
@yaakoviyun
Delete ManagedDatabaseVulnerabilityAssessmentGet.json
f1e6320
@yaakoviyun
Delete ManagedDatabaseVulnerabilityAssessmentRuleBaselineCreate.json
ffc7251
@yaakoviyun
Delete ManagedDatabaseVulnerabilityAssessmentRuleBaselineDelete.json
5f85874
@yaakoviyun
Delete ManagedDatabaseVulnerabilityAssessmentRuleBaselineGet.json
fdbca71
@yaakoviyun
Delete ManagedDatabaseVulnerabilityAssessmentScanExport.json
478f3d6
@yaakoviyun
Delete ManagedDatabaseVulnerabilityAssessmentScanRecordsGet.json
1798f9d
@yaakoviyun
Delete ManagedDatabaseVulnerabilityAssessmentScanRecordsListByDatabas…
016729b 
…e.json
@yaakoviyun
Delete ManagedDatabaseVulnerabilityAssessmentScansExecute.json
501d0f9
@yaakoviyun
Update readme.md
839446d
@yaakoviyun
Copy link
Member Author

@jaredmoo

@azuresdkci azuresdkci requested a review from anuchandy May 23, 2018 05:33
jaredmoo
jaredmoo approved these changes May 23, 2018
View reviewed changes
Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AutorestCI AutorestCI mentioned this pull request May 23, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented May 23, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2285

@AutorestCI AutorestCI mentioned this pull request May 23, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 23, 2018 •
edited
Loading

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#9

@AutorestCI AutorestCI mentioned this pull request May 23, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 23, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1902

@AutorestCI AutorestCI mentioned this pull request May 23, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented May 23, 2018 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2715

@jaredmoo jaredmoo mentioned this pull request May 23, 2018
Merged
9 tasks
anuchandy
anuchandy approved these changes May 23, 2018
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had chat with @jaredmoo, the service already requires the parameters storageContainerPath and storageContainerSasKey, this PR is simply correcting the swagger. There is no SDK released so far for this api.

@anuchandy anuchandy merged commit 3ea886e into Azure:master May 23, 2018
@AutorestCI
Copy link

AutorestCI commented May 23, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredmoo jaredmoo jaredmoo approved these changes

@anuchandy anuchandy anuchandy approved these changes

Assignees

@anuchandy anuchandy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaakoviyun @AutorestCI @anuchandy @jaredmoo