BlobLeaseClient Avoid Log 409 response #33695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added failing test to confirm bad behavior intended to be fixed with new api
ghost
added
the
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
tg-msft
reviewed
Jan 31, 2023
sdk/storage/Azure.Storage.Blobs/api/Azure.Storage.Blobs.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
jaschrep-msft
requested review from
KrzysztofCwalina,
seanmcc-msft and
amnguye
as code owners
amnguye
approved these changes
Feb 13, 2023
…o lease-already-present-fix
tg-msft
approved these changes
Feb 24, 2023
amnguye
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to acquire a lease on a blob or container where one already exists, the service returns a 409. An application may wish to consider this attempt as part of the normal flow of operation and schedule a retry at a later time, rather than consider it an error upfront and log it as such.
Error suppression on this operation is necessary to address #21511.
This introduces an overload to
AcquireLease()that accepts aResponseClassifierthat can use a predicate to determine whether a response should be let through as a non-error. The mentioned issue can then construct the appropriate predicate for its scenario.