-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Lease already present after upgrading to Microsoft.Azure.WebJobs.Extensions.Storage 5.0.0-beta.3 #21511
Comments
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage. Issue DetailsDescribe the bug
Expected behavior No warning Actual behavior (include Exception or Stack Trace) To Reproduce
Environment:
All project dependencies: <Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<AzureFunctionsVersion>V3</AzureFunctionsVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Azure.Identity" Version="1.4.0" />
<PackageReference Include="Azure.Messaging.ServiceBus" Version="7.2.0-beta.3" />
<PackageReference Include="Azure.Security.KeyVault.Secrets" Version="4.1.1" />
<PackageReference Include="Azure.Storage.Blobs" Version="12.9.0-beta.4" />
<PackageReference Include="Microsoft.Azure.Cosmos" Version="3.19.0" />
<PackageReference Include="Microsoft.Azure.Devices" Version="1.34.0" />
<PackageReference Include="Microsoft.Azure.Functions.Extensions" Version="1.1.0" />
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.DurableTask" Version="2.4.3" />
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Storage.Blobs" Version="5.0.0-beta.3" />
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.ServiceBus" Version="5.0.0-beta.3" />
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions" Version="4.0.1" />
<PackageReference Include="Microsoft.Azure.WebJobs.Logging.ApplicationInsights" Version="3.0.27" />
<PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.27" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="3.1.11" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="3.1.11" />
<PackageReference Include="Microsoft.NET.Sdk.Functions" Version="3.0.12" />
<PackageReference Include="Microsoft.ApplicationInsights" Version="2.17.0" />
</ItemGroup>
<ItemGroup>
<None Update="host.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="local.settings.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<CopyToPublishDirectory>Never</CopyToPublishDirectory>
</None>
</ItemGroup>
</Project>
|
What version of Microsoft.Azure.WebJobs.Extensions.Storage are you upgrading from? Also what code snippet causes the |
This is most likely coming from Lines 125 to 144 in 0e7a91c
|
Relabeling as bug |
This is still happening in the 5.0 release. |
In case it helps, I have one Consumption Function App with 3 functions: (simplified)
This function app has a dedicated storage account to which all functions refer to through the AzureWebJobsStorage App Settings variable. This warning log is being generated ~70K times a day. This not only impacts the $$$ and the adaptive sampling features of my App Insight component, but since they are warning, they make it pretty hard to review the logs. |
Yes, also seeing it |
Just updated to the new .NET 6.0 with latest (non-prerelease) libraries and ~4 runtime (in-proc C# library), and this issue still occurs. If you want to stem the AI log spam, setting {
"version": "2.0",
"logging": {
"logLevel": {
"default": "Information",
"Azure.Core": "Error"
}
}
} This unfortunately turns off all of the For in-process function apps at least, there's a name deduplication that happens so that |
FYI, I am using version 4.0.5 of Microsoft.Azure.WebJobs.Extensions.Storage, and I am seeing the same issue. Between the 7 and 20 lines per minute. |
@jaschrep-msft can you please pick this up. |
We'd like the fix for this to align with #25626 which we hope will be a common solution to this class of problems. |
I'm hitting this as well, here in the first week of Jan |
This bug is a spam cannon for my logs |
Our log is flooded as well, any news on this? |
We're also seeing this. Any update? This is coming from our durable functions app, in a container in AKS. .net 6, functions v4
Project file
|
I'd like to add and raise awareness why these issues should be taken quite seriously by product group. The impact is two-fold:
I've been hit by this twice now - once for non-durable functions with blob triggers that went on spiral trying to understand if retriggering is necessary and causes both insane blob storage usage growth and trace logging. This happened while migration from v3 to v4 and to .net 6. The second one is the durable function and the "Skipping ownership lease aquiring for somefunctionapp-control-". Its not merely an info message, your storage is being hit here as well (at least mine is). About 1.2 million transactions/day on the most used storage account linked to function app. I've yet to understand what is causing this, since the particular durable function for us is not in active usage - but it started after .net 6 / v4 migration. |
@kasobol-msft and @jaschrep-msft are you looking at this ? Many customers are facing this. |
@kasobol-msft @jaschrep-msft |
The required APIs should be available now in Azure.Core to be able to implement this feature. In order to suppress distributed tracing for a given status code, Please reach out with any remaining questions on implementation. |
When can we expect this to be fixed? |
@xmak the PR linked above your comment is the key to fixing this. We plan to get this out in our next release cycle. Once that API is available, the webjobs extension package will need to be updated to use the new API instead of the old one, passing in the appropriate error classification to avoid logging the response. |
Describe the bug
Expected behavior
No warning
Actual behavior (include Exception or Stack Trace)
To Reproduce
Environment:
All project dependencies:
The text was updated successfully, but these errors were encountered: