Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Storage extensions should leverage RequestContext.ErrorOptions #29132

Closed
lmolkova opened this issue Jun 6, 2022 · 7 comments
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) Storage Storage Service (Queues, Blobs, Files)

Comments

@lmolkova
Copy link
Member

lmolkova commented Jun 6, 2022

Library name

Microsoft.Azure.WebJobs.Extensions.Storage.*

Please describe the feature.

Template Azure Functions with Storage bindings report a lot of log warnings at startup and in every trigger call for 404 requests. Such logs should probably have info severity.

MicrosoftTeams-image

Tracing calls for Exists that end up with 404 are also represented as failures

image

Once RequestContext.ErrorOptions are implemented in Storage SDKs, WebJob extensions should leverage it to indicate when such errors should have lower log severity and no error on the tracing side.

Related: #21511, #27645, #27792, #26327, #9934, #9908, #8320, and many other including 404/409/412 responses on blob locks, etag checks and exists calls

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 6, 2022
@azure-sdk azure-sdk added Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. Storage Storage Service (Queues, Blobs, Files) labels Jun 6, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 6, 2022
@lmolkova
Copy link
Member Author

lmolkova commented Jun 6, 2022

Related:
#27792, #26327, #9934, #9908, Azure/azure-functions-host#8320

and many other including 404/409/412 responses on blob locks, etag checks and exists calls

@jsquire jsquire added Service Attention Workflow: This issue is responsible by Azure service team. and removed needs-team-triage Workflow: This issue needs the team to triage. labels Jun 6, 2022
@ghost
Copy link

ghost commented Jun 6, 2022

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

Issue Details

Library name

Microsoft.Azure.WebJobs.Extensions.Storage.*

Please describe the feature.

Template Azure Functions with Storage bindings report a lot of log warnings at startup and in every trigger call for 404 requests. Such logs should probably have info severity.

MicrosoftTeams-image

Tracing calls for Exists that end up with 404 are also represented as failures

image

Once RequestContext.ErrorOptions are implemented in Storage SDKs, WebJob extensions should leverage it to indicate when such errors should have lower log severity and no error on the tracing side.

Author: lmolkova
Assignees: -
Labels:

Storage, Service Attention, Client

Milestone: -

@jsquire
Copy link
Member

jsquire commented Jun 6, 2022

//cc: @kasobol-msft

@jsquire jsquire removed the Service Attention Workflow: This issue is responsible by Azure service team. label Jun 6, 2022
@kasobol-msft
Copy link
Contributor

Related:
#21511
#27645

@SeanFeldman
Copy link
Contributor

Just a suggestion: to have a "Related issues" section under the issue description and keep all the related items right there, along with the main description of the problem.

Copy link

github-actions bot commented Jun 7, 2024

Hi @lmolkova, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

1 similar comment
Copy link

github-actions bot commented Jul 8, 2024

Hi @lmolkova, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

7 participants