[synapse] Convert samples to markdown format #17657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chamons
commented
Dec 21, 2020
•
chamons
commented
- [synapse] Convert samples to markdown and first pass of documentation #17632 redone after f0519b4 landed
jsquire
approved these changes
Dec 21, 2020
| @@ -19,14 +19,4 @@ public class SampleFixture: SamplesBase<SynapseTestEnvironment> | |||
| [TearDown] | |||
| public void TearDown() => _listener?.Dispose(); | |||
| } | |||
|
|
|||
| #pragma warning disable SA1402 // File may only contain a single type | |||
jsquire
reviewed
Dec 21, 2020
| @@ -0,0 +1,64 @@ | |||
| # Create, Retrieve and Delete a Synapse Role Assignment | |||
|
|
|||
| This sample demonstrates basic operations with two core classes in this library: `AccessControlClient` and `RoleAssignmentDetails`. `AccessControlClient` is used to call the Azure Synapse service - each method call sends a request to the service's REST API. `RoleAssignmentDetails` is an entity that represents a role assignment within Synapse. The sample walks through the basics of adding, retrieving, and deleting role assignment. To get started, you'll need a connection endpoint to Azure Synapse. See the README for links and instructions. | |||
There was a problem hiding this comment.
It would be helpful to link back to the README since we're asking folks to "see" it...
There was a problem hiding this comment.
Dang it, I did all of your comments but this one...
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
- Converted all synapse samples (both per-existing and those that I wrote) to markdown + cs snippet format - First pass at documenting the 4-5 that are champion scenarios - Found and deleting some duplicate snippet + scenarios I found along the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.