Skip to content

Commit

Permalink
[synapse] Re-enable many disabled tests by bumping to swagger with nu…
Browse files Browse the repository at this point in the history
…llability fix (#17645)

- This fixes almost all of #17455
- Two tests remain: A managed private endpoint issue that's been raised w\ the service team and a pipeline test that I'm rewriting in another PR
  • Loading branch information
chamons authored Dec 21, 2020
1 parent 7600467 commit f0519b4
Show file tree
Hide file tree
Showing 21 changed files with 46 additions and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Run `dotnet build /t:GenerateCode` to generate code.
> see https://aka.ms/autorest
```yaml
repo: https://github.com/Azure/azure-rest-api-specs/blob/eea7c0141c0b7ad9f66f8ba06560b549c6b3b014
repo: https://github.com/Azure/azure-rest-api-specs/blob/ca0ac888f84b97feaef05fad6632f41ef1a399e6
```
``` yaml
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Run `dotnet build /t:GenerateCode` to generate code.
> see https://aka.ms/autorest
```yaml
repo: https://github.com/Azure/azure-rest-api-specs/tree/eea7c0141c0b7ad9f66f8ba06560b549c6b3b014
repo: https://github.com/Azure/azure-rest-api-specs/tree/ca0ac888f84b97feaef05fad6632f41ef1a399e6
```
``` yaml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ public NotebookClientLiveTests(bool isAsync) : base(isAsync)
{
}

[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
[Test]
public async Task TestGetNotebook()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ namespace Azure.Analytics.Synapse.Artifacts.Samples
{
public partial class NotebookSnippets : SampleFixture
{
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
[Test]
public async Task NotebookSample()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ namespace Azure.Analytics.Synapse.Samples
/// </summary>
public partial class NotebookSample
{
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
[Test]
public async Task CreateAndUploadNotebook()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Run `dotnet msbuild /t:GenerateCode` to generate code.
> see https://aka.ms/autorest
```yaml
repo: https://github.com/Azure/azure-rest-api-specs/blob/eea7c0141c0b7ad9f66f8ba06560b549c6b3b014
repo: https://github.com/Azure/azure-rest-api-specs/blob/ca0ac888f84b97feaef05fad6632f41ef1a399e6
```
``` yaml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ public ManagedPrivateEndpointsClientLiveTests(bool isAsync) : base(isAsync)
{
}

[Test]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
[Test]
public async Task TestManagedPrivateEndpoints()
{
// Create a managed private endpoint
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ namespace Azure.Analytics.Synapse.ManagedPrivateEndpoints.Samples
public partial class Snippets : SampleFixture
{
[Test]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
public void TestManagedPrivateEndpoint()
{
#region Snippet:CreateClient
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Run `dotnet msbuild /t:GenerateCode` to generate code.
> see https://aka.ms/autorest
```yaml
repo: https://github.com/Azure/azure-rest-api-specs/tree/eea7c0141c0b7ad9f66f8ba06560b549c6b3b014
repo: https://github.com/Azure/azure-rest-api-specs/tree/ca0ac888f84b97feaef05fad6632f41ef1a399e6
```
``` yaml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ public MonitoringClientLiveTests(bool isAsync) : base(isAsync)
}

[Test]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
public async Task TestListSparkApplications()
{
SparkJobListViewResponse sparkJobList = await MonitoringClient.GetSparkJobListAsync();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ namespace Azure.Analytics.Synapse.Samples
/// </summary>
public partial class PipelineMonitoring
{
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
[Test]
public void MonitorPipelineRuns()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ namespace Azure.Analytics.Synapse.Monitoring.Samples
public partial class Snippets : SampleFixture
{
[Test]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
public void MonitoringSample()
{
#region Snippet:CreateMonitoringClient
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/synapse/Azure.Analytics.Synapse.Spark/src/autorest.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Run `dotnet build /t:GenerateCode` to generate code.
> see https://aka.ms/autorest
```yaml
repo: https://github.com/Azure/azure-rest-api-specs/blob/eea7c0141c0b7ad9f66f8ba06560b549c6b3b014
repo: https://github.com/Azure/azure-rest-api-specs/blob/ca0ac888f84b97feaef05fad6632f41ef1a399e6
```
``` yaml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ namespace Azure.Analytics.Synapse.Samples
public partial class ExecuteSparkStatement
{
[Test]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
public void ExecuteSparkStatementSync()
{
// Environment variable with the Synapse workspace endpoint.
Expand Down

0 comments on commit f0519b4

Please sign in to comment.