Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Bus Migration Guide improvements #14166

Merged
merged 18 commits into from
Sep 10, 2020
Merged

Service Bus Migration Guide improvements #14166

merged 18 commits into from
Sep 10, 2020

Commits on Aug 12, 2020

  1. Service Bus Migration Guide improvements

    @ramya-rao-a
    ramya-rao-a committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    506d587 View commit details
    Browse the repository at this point in the history

  2. Add session parts

    @ramya-rao-a
    ramya-rao-a committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    a6ffca9 View commit details
    Browse the repository at this point in the history

  3. Apply code snippet edits from code review 

    Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
    @ramya-rao-a @JoshLove-msft
    ramya-rao-a and JoshLove-msft authored Aug 12, 2020
    Configuration menu
    Copy the full SHA
    e4dc8af View commit details
    Browse the repository at this point in the history

  4. Minor tweaks to words based on Jesse's feedback

    @ramya-rao-a
    ramya-rao-a committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    a02534f View commit details
    Browse the repository at this point in the history

  5. More code snippet edits from code review 

    Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
    @ramya-rao-a @JoshLove-msft
    ramya-rao-a and JoshLove-msft authored Aug 12, 2020
    Configuration menu
    Copy the full SHA
    44529ac View commit details
    Browse the repository at this point in the history

  6. Update sdk/servicebus/Azure.Messaging.ServiceBus/MigrationGuide.md 

    Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
    @ramya-rao-a @JoshLove-msft
    ramya-rao-a and JoshLove-msft authored Aug 12, 2020
    Configuration menu
    Copy the full SHA
    32c4ae6 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. Specify the name of Track 1 SDK to avoid confusion with Track 0

    @ramya-rao-a
    ramya-rao-a committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    26be38e View commit details
    Browse the repository at this point in the history

  2. More replacesments of version numbers with package names

    @ramya-rao-a
    ramya-rao-a committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    eddaeae View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Use single line for single paragraph

    @ramya-rao-a
    ramya-rao-a committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    eac4cfc View commit details
    Browse the repository at this point in the history

  2. Improve sample for create batch

    @ramya-rao-a
    ramya-rao-a committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    301dfec View commit details
    Browse the repository at this point in the history

  3. i-- instead of i=i-1 

    Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
    @ramya-rao-a @JoshLove-msft
    ramya-rao-a and JoshLove-msft authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    14c8567 View commit details
    Browse the repository at this point in the history

  4. Josh says else if needs its own line 

    Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
    @ramya-rao-a @JoshLove-msft
    ramya-rao-a and JoshLove-msft authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    cb5e91f View commit details
    Browse the repository at this point in the history

  5. Josh says { needs its own line :( 

    Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
    @ramya-rao-a @JoshLove-msft
    ramya-rao-a and JoshLove-msft authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    cef8db1 View commit details
    Browse the repository at this point in the history

  6. Sean says we should hyphenate certain words 

    Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com>
    @ramya-rao-a @SeanFeldman
    ramya-rao-a and SeanFeldman authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    261fa8e View commit details
    Browse the repository at this point in the history

  7. Improve messaging around processors 

    Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com>
    @ramya-rao-a @SeanFeldman
    ramya-rao-a and SeanFeldman authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    2436e82 View commit details
    Browse the repository at this point in the history

  8. Reduce confusion around sessions for individual/specific sessions

    @ramya-rao-a
    ramya-rao-a authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    5125bc9 View commit details
    Browse the repository at this point in the history

  9. Avoid the quotes

    @ramya-rao-a
    ramya-rao-a committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    2b52664 View commit details
    Browse the repository at this point in the history

  10. Use ServiceBusSessionProcessor for sessions

    @ramya-rao-a
    ramya-rao-a committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    2499db0 View commit details
    Browse the repository at this point in the history