Service Bus Migration Guide improvements #14166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ramya-rao-a
requested review from
JoshLove-msft,
jsquire,
MiYanni and
ShivangiReja
as code owners
jsquire
reviewed
Aug 12, 2020
| @@ -30,7 +26,7 @@ To try and improve the development experience across Azure services, including S | |||
|
|
|||
| The modern Service Bus client library provides the ability to share in some of the cross-service improvements made to the Azure development experience, such as using the new `Azure.Identity` library to share a single authentication between clients and a unified diagnostics pipeline offering a common view of the activities across each of the client libraries. | |||
|
|
|||
| While we believe that there is significant benefit to adopting the modern version of the Service Bus library, it is important to be aware that the legacy version has not been officially deprecated. It will continue to be supported with security and bug fixes as well as receiving some minor refinements. However, in the near future it will not be under active development and new features are unlikely to be added. There is no guarantee of feature parity between the modern and legacy client library versions. | |||
| While we believe that there is significant benefit to adopting the modern version of the Service Bus library, it is important to be aware that the legacy version has not been officially deprecated. It will continue to be supported with security and bug fixes as well as receiving some minor refinements. However, in the near future it will not be under active development and new features are unlikely to be added. | |||
There was a problem hiding this comment.
Not sure that I agree with the removal in this paragraph. Would you be kind enough to share the rationale behind this change?
There was a problem hiding this comment.
I see this statement giving a knee jerk reaction to someone reading it.
Am guessing the intention here was that moving forward, the modern library would have features that are not guaranteed to be in the legacy version?
My concern is that this can be misunderstood to be the other way around i.e. the modern library will not have the same features as the legacy one
There was a problem hiding this comment.
Two points to consider. When you say "legacy client" there are two of those. Be specific or elaborate. The statement should be there to warn about breaking changes. If someone relies on the pipelines, they won't be able to move to track 2 SDK as it has no support for message pipelines. At no point it should be a surprise.
There was a problem hiding this comment.
Improved in 26be38e by referencing the SDKs by name
| Having similar methods to create senders, receivers and receivers for individual sessions on the same client provides consistency and predictability on the various features of the library. We have attempted to have the session/non-session usage be as seamless as possible. This allows users to make less changes to their code when they want to move from sessions to non-sessions or the other way around. | ||
|
|
||
| #### Resource usage | ||
| By using a single top-level client, we can implicitly share a single AMQP connection for all operations that an application performs. In the previous library, connection sharing was implicit when using the `SessionClient`, but when using other clients, users would need to explicitly pass in a `ServiceBusConnection` object in order to share a connection. By making this sharing be implicit to a ServiceBusClient instance, we can help ensure that applications will not use multiple connections unless they explicitly opt in by creating multiple `ServiceBusClient` instances. |
There was a problem hiding this comment.
nit: I'd suggest removing AMQP here; it doesn't add value as the protocol is irrelevant.
| ### Creating sender and receiver | ||
| ```cs | ||
| // Create a ServiceBusClient that will authenticate through Active Directory | ||
| string fullyQualifiedNamespace = "yournamespace.servicebus.windows.net"; |
There was a problem hiding this comment.
These should probably be driven off of snippets.
There was a problem hiding this comment.
@JoshLove-msft will add the code snippets in a separate PR
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
SeanFeldman
reviewed
Aug 13, 2020
| | `new QueueClient()` or `new TopicClient()` or `new SubscriptionClient()` or `new SessionClient()` | `new ServiceBusClient()` | [Authenticate with connection string](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/servicebus/Azure.Messaging.ServiceBus/tests/Samples/Sample01_HelloWorld.cs#L177) | | ||
| | `new QueueClient(..., ITokenProvider)` or `new TopicClient(..., ITokenProvider)` or `new SubscriptionClient(..., ITokenProvider)` or `new SessionClient(..., ITokenProvider)` | `new ServiceBusClient(..., TokenCredential)` | [Authenticate with client secret credential](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/servicebus/Azure.Messaging.ServiceBus/tests/Samples/Sample01_HelloWorld.cs#L165) | ||
| While we continue to support connection strings when constructing a client, the main difference is in using Azure Active Directory. | ||
| We now use the new `Azure.Identity` library to share a single authentication solution between clients of different Azure services. |
MiYanni
suggested changes
Aug 18, 2020
JoshLove-msft
approved these changes
Sep 8, 2020
SeanFeldman
reviewed
Sep 10, 2020
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com>
Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com>
|
Thanks for the feedback @SeanFeldman, @JoshLove-msft, @jsquire and @MiYanni We will merge this PR to get the release for the next preview going. |
MiYanni
approved these changes
Sep 10, 2020
annelo-msft
added a commit
that referenced
this pull request
Oct 13, 2020
) * Fix for failing long running operations (#14663) Co-authored-by: Meha Kaushik <mekaushi@microsoft.com> * Implement ctor accepting a connection string (#14674) * Implement ctor accepting a connection string * change version * formatting * pr comments * export api * connectionstring tests * [TA] SDK now targets 3.1-preview.2 (#14633) * new features generated + CI enabled + recordings * update changelog * Azure Monitor Exporter - Add Connection String (#14621) * Add release preparation script (#14680) * feat(samples): Twin configurations sample (#14683) * Release script fixes (#14686) * Amqp updates (#14681) * Azure Monitor Exporter - Adopt OpenTelemetry .NET beta2 changes (#14687) * Add Microsoft.Extensions.Azure.WebJobs package (#14589) * Add SubQueue option and remove locktoken overloads (#14692) * Restructure Changelog Logic (#13783) * Restructure Changelog Logic * reset eng/common directory * move test to individual classes (#14684) * Add service version and remove public ctors for output only types (#14690) * Feature/storage/stream position deadlock bug (#14301) * Adding SNI support to ClientCertificateCredential (#14636) * Adding SNI support to ClientCertificateCredential * updating API ref * redame content and some additional samples (#14713) * redame content and some additional samples * typos * add Delete perms * Feature/storage/open write page blob bug (#14716) * Update code owners for ADT (#14722) * Preparing for Storage release (#14721) * Increment version for storage releases (#14725) * Add Azure AD Only Authentication for Managed Instance (#14717) * Add support for Managed Instance Azure AD Only Auth. * Fix folder path. * Fix sqlManagementClient * Add res-manager, update the api version to 1.44.1-preview * Fix assembly file version. * Add LocalCryptographyClient for Key Vault (#14677) * Initial LocalCryptographyClient * Add tests for LocalCryptographyClient * Fix build break from CI using older SDK * Resolve PR feedback * Shorten polling intervals for test playback Fixes #14557 * Mark tests inconclusive if indexer status times out (#14727) * Change Key Vault package versions to 4.2.0-beta.1 (#14678) * Change Key Vault package versions to 4.2.0-beta.1 * Change .Administration to 4.0.0-beta.1 * Generate code for package-2020-07-01 for Azure Kubernetes Service (#14541) * Generate code for package-2020-07-01 for Azure Kubernetes Service * Upgrade tests for AKS 2020-07-01 * [KeyVault] Support new resource: managed HSM (#14569) * mhsm * mhsm2 * exclude from test * mhsm3 * bump up version * all new api versions * generate from merged spec * include tests * [DataFactory]Added logLevel/enableReliableLogging to LogStorageSettings (#14597) * Added logLevel/enableReliableLogging to LogStorageSettings * Update Tar GZip * [Synapse] Add test cases for Artifacts and update generator version & rerecord tests (#14575) * add test cases for artifacts * solve LRO and add test cases * update generator version and rerecord tests * update version * update changelog * update readme * generate export API * update changelog * update release date Co-authored-by: Wan Yang <t-wayang@microsoft.com> * [Identity] add RedirectUri option to InteractiveBrowserCredentialOptions (#14720) * [Identity] add RedirectUri option to InteractiveBrowserCredentialOptions * updating API reference * Update CODEOWNERS (#14759) From observation. Looks like nesting is winning and @tg-msft is no longer added to our PRs. Fixing that here. * [TA] Add encoding support and length and offset (#14719) * add encoding and length and offset * Pr feedback * export-api * Clarify KeyClientBuilderExtension methods params (#14737) * Clarify KeyClientBuilderExtension methods params Fixes #14695 * Resolve PR feedback * Retire Net core installer (#14567) * Specify SDK version in b=global.json * Retire Dotnet Installer Task * Retire UseDotNet task * Remove DownloadPipelineArtifact in analyze stage * [Storage] Make OpenWrite work with using keyword (#14758) * Prepare Storage for release * pr feedback. * PR feedback. * pr feedback. * make open write work with using. * move recordings to right place * pr feedback. * Fix ADT Patch APIs to return Response rather than Response<String> (#14729) updateComponent and updateDigital twin will never get an HTTP response payload by design, but our custom code mistakenly assumed they would. This fixes the customization code so that they return Response rather than Response<String> * Update mgmt.yml for Azure Pipelines * [Storage] Update changelog. (#14772) * Prepare Storage for release * pr feedback. * PR feedback. * pr feedback. * make open write work with using. * move recordings to right place * pr feedback. * update changelog * [Identity] Add IdentityModelFactory to facilitate mocking (#14769) * [Identity] Add IdentityModelFactory to facilitate mocking * update API spec and changelog * refactor sdkversion (#14774) * Updating to latest swagger and regenerating code. (#14762) * Lifecycle updates (#14773) * [TA] Add flags enum for Opinion mining (#14624) * add flags enum for OM * PR feedback * export-api * Sync eng/common directory with azure-sdk-tools repository for Tools PR 935 (#14693) * Remove use UseDotNetCore Task (#14771) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 916 (#14616) * Support reading existing DataProtection KeyVault keys (#14778) * Updating README and Samples for Event Grid (#14568) * Updated README * Created samples README and sample files * Small edits, updated system event types Edited test for CloudEvents publishing raw JSON Added StorageLifecyclePolicyCompletedEvent to list of system event types * Updating session records * Sync eng/common directory with azure-sdk-tools repository for Tools PR 930 (#14628) * Dispose processor in tests (#14784) * Properly segment StorageEndpointSuffix and CosmosEndpointSuffix (#14754) * Create backup and restore samples, various other updates (#14756) * samples - pre-recordings * use CodeGenModel Usage * take latest swagger spec and remove hacks * renaming * version change * fix readme nuget version * remove test auth * fix tests * update generator and re-record * links * thanks, link validation :) * readme fixes * prc * make errors internal * keep lowercase readme.md until this merges * regen * Store release notes into Notes custom property of the issue (#14782) * [NetAppFiles]Anf 6504 net app files bump to 2020 02 01 (#14591) * Update to 2020-02-01 api verison * mgmt * Update test recordings * Update api version number Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com> * Remove hard-coded .NET Sdk version for mgmt pipelines (#14799) * [Identity] Throw CredentialUnavailableException from credentials not supporting ADFS (#14763) * [Identity] Throw CredentialUnavailableException from credentials not supporting ADFS * moving tenantId check to after it's read from settings * fix check to use local variable * Generate Anomaly Detector for Preview-2 (#14791) Generate Anomaly Detector for Preview-2 * Incorporate tables readme feedback (#14795) * Added inbound security rule. Fixed Netwatchers (#14728) * Readme and sample tweaks (#14801) * Readme and sample tweaks * Update sdk/keyvault/Azure.Security.KeyVault.Administration/readme.md Co-authored-by: Heath Stewart <heaths@outlook.com> * Update sdk/keyvault/Azure.Security.KeyVault.Administration/readme.md Co-authored-by: Heath Stewart <heaths@outlook.com> * Update sdk/keyvault/Azure.Security.KeyVault.Administration/readme.md Co-authored-by: Heath Stewart <heaths@outlook.com> Co-authored-by: Heath Stewart <heaths@outlook.com> * add bingEntitySearchApiId (#14805) * Change optional Guid name to Guid? (#14827) * Fix Key Vault Administration README * Change optional Guid name to Guid? Fixes #14823 * Change prerelease versioning (#14780) - Use alpha instead of dev - Use beta instead of preview * [TA] Add PII back (#14794) * all pii code * tests * recordings * samples * pr feedback * add mocking * PR feedback * Fixed samples (#14835) Parse method doesn't allow trailing commas in JSON * [Azure Cognitive Search][Management plane] Fix typos from swagger (#14787) * pull in the docs update * regenerate from master Co-authored-by: Arvind Krishnaa Jagannathan <arjagann@microsoft.com> * SDK refresh to support new API version 2020-04-01 (#14708) * SDK refresh to support new API version 2020-04-01 * databox_resource-manager.txt update * Sync eng/common directory with azure-sdk-tools repository for Tools PR 946 (#14831) * Update changelog, csproj, and readme for Event Grid (#14838) * Update changelog, csproj, and readme Updating version name to 4.0.0-beta.1 * Fixed changelog date * Add known issues section to README (#14812) * Minor Tables readme improvements (#14846) * Minor Tables readme improvements * Update readme.md * [ReleasePR Microsoft.Azure.Management.Automanage] Microsoft.Automanage SDK for 2020 06 30 preview (#14486) * Includes Generated Files And Half Of Unit Test Coverage * tests completed * updated readme * updated versions, included AssemblyInfo * removed unneeded package references * updated assemblyname to properCasing * Rename Microsoft.Azure.Management.Automanage.sln to Microsoft.Azure.Management.AutoManage.sln * casing fixes * added metadata file * lineending+ * newline-- * changed hardcoded reference to dotnet coreapp31 * PR feedback, fixed csproj hard coded versions, added required properties to csproj * fixing ambiguous package name error * fixed version number * fix wrong reference in generate * PRfeedback, fixed incorrect tag references, version numbers, and remove unneeded dotnet version * pr feedback, fixing missing session records * renamed missing test * fixed old test Co-authored-by: Stephen Owen <stephen.owen@microsoft.com> * Create pull_request_assignment.yml (#14748) * Create pull_request_assignment.yml * Update pull_request_assignment.yml * [Service Bus Client] Connection String SAS Support (#14806) The focus of these changes is to add support for a precomputed shared access signature token to be used as part of the connection string. * [Anomaly detector] Fix readme links and changelog release date for preview-2 (#14854) [Anomaly detector] Fix readme links and changelog release date for preview2 * [Storage] OpenRead - fail fast if blob doesn't exist. (#14863) * Prepare Storage for release * pr feedback. * PR feedback. * pr feedback. * make open write work with using. * move recordings to right place * pr feedback. * fail fast if blob doesn't exist at OpenRead. * Update required net core sdk version (#14804) * [TA] Samples and documentation for Opinion Mining and Pii (#14829) * samples, readme + fix version * update links * update samples * Fixed bug where Listing Blobs with BlobTraits.Metadata would return B… (#14861) * Fixed bug where DataLakeFileClient.Upload() could not upload read-only files. (#14864) * Fix .Net SDK Version (#14875) * [TA] Update links to point to master (#14871) * update links to point to master * english * Switch to using pipeline resource (#14877) * Update versions for August release (#14868) Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Azure Monitor Exporter - Match HTTP URL retrieval to OpenTelemetry specification (#14834) * Add remaining test cases from track one DNS SDK to track two (#14766) * WIP: Initial CRUD and List test for record and zone * WIP: Port of cloud issues * WIP: OneTimeTearDown and setup working. No double test runs * WIP: don't make zone twice * WIP: Commit test * WIP: Fix changelog and readme * WIP: Fix yaml * WIP: Fix yml 2 * WIP: Remove unused function * Remove .swp file * Remove SWP file * Update DNS Track 2 test * Add Tests Recordings * Fix Class name * WIP: Update tests * WIP: Make exception test clearner * WIP: Update live test records * Revert json change Co-authored-by: bqauntump <bqauntump@DESKTOP-B63NOF4.localdomain> * Add support for both .Net Core 2.1 and .Net Core 3.1 (#14884) * Add support for both .Net Core 2.1 and .Net Core 3.1 * Install runtime instead of SDK * Sync eng/common directory with azure-sdk-tools repository for Tools PR 955 (#14873) * Support calculating and setting release date (#14876) * Support calculating and setting release date * FB * More FB * Tuesday * Add release notes collect script (#14879) * Allow preview label for until they all ship GA (#14881) * Update contributing document (#14870) * [Event Hubs Client] Connection String SAS Support (#14858) The focus of these changes is to add support for a precomputed shared access signature token to be used as part of the connection string. * [Event Hubs Client] Documentation Updates The focus of these changes is to sync the release documentation for v5.2.0 with the release branch. The version stamps and references have not been changed, as those will be covered under a dedicated pre-release set of changes. * Sync eng/common directory with azure-sdk-tools repository for Tools PR 926 (#14610) * Move Microsoft.Extensions.Azure into extensions directory (#14715) * Bump the template version. (#14908) * Adding additional team member to PR and codeowner for management SDK code path (#14880) * Feature/storage/blob access policy bug (#14872) * Increment version for core releases (#14907) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 823 (#14656) * Remove reminants of dotnet core versions (#14783) * [Azure.Core TestFramework] Fix Required Optional Environment Variable (#14906) The focus of these changes is to bypass the attempt to santitize an optional environment variable when no value was present. Previously, if the variable was not read, sanitizing would result in an exception. * Fix bug when sanitizing empty body (#14885) * Missed line in DataLakeFileClient.Upload() readonly fix (#14910) * [Identity] Fix environment variable mismatch for live CI tests (#14865) * Identity fix environment variable missmatch for live CI tests * updating container image for live tests * updating test container image * Add release note for new AddConfigurationClient extension. (#14903) * Add release note for new AddConfigurationClient extension. * Bump library version. * Update Microsoft.Azure.Management.KeyVault.csproj (#14898) * Support WebJobs configuration fallback logic (#14825) * Update Azure.Core.* versions (#14923) * Update Azure.Core.* versions * order * Event Grid: Updating Readme and Samples (#14889) * Revising readme and samples based on arch board feedback * Update Langauage Settings File (#14922) * Override ContentType header when sending multipart/form-data type request (#14925) * Fix #14408: [BUG] ChainedTokenCredential throws an exception when VisualStudioCodeCredential is present (#14882) * Tests added * Fix #14408: [BUG] ChainedTokenCredential throws an exception when VisualStudioCodeCredential is present * Fixed change log (#14916) * Fix #13687: Move to latest App Services MSI API version (#14770) * Fix #13687: Move to latest App Services MSI API version * Delete unused type * Move request builders creation into factory methods * Move maximum of code into IManagedIdentitySource implementations * Fix formatting * Update sdk/identity/Azure.Identity/src/ManagedIdentityCredential.cs Typo fix Co-authored-by: Charles Lowell <chlowe@microsoft.com> Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Improve integration of configuration based clients with other features (#14859) * Improve integration of configuration based clients with other features * Fixes * Increment package version after release of Azure.Extensions.AspNetCore.DataProtection.Keys (#14932) * New SDK - SchemaRegistry (#13657) * Generated the SchemaRegistry SDK. Set up project and custom client. Fixed original swagger and made a separate PR for it. * Update to latest swagger with description fixes. * Fixed changlog. Regen surface. * Regen with correct swagger. * Started adding client methods. * Update SchemaId to be struct. Regen api. * Initial attempt of serializer. * Update swagger version. Regenerate rest client. Update public surface. Created first working test. * Added happy path tests for each client method. Added recordings. * Move serialization stuff into the Azure.Data.SchemaRegistry.Avro project. Created project, test project, and tool (to test Avro). * Modify SchemaProperties to have smaller set of properties. Rerun and rename tests. Update api. * Still attempting to get Avro library usable functionality. Some reflection-based usage is working. Unfortunately, we're encoding the avro file incorrectly (it includes schema). * Initial serializer implementation. Only does specific records. * Fixed issues with specific record schema de/serialization. * Got GenericRecord working. Needs cleanup. * Code cleanup begins! * :-) Cleaned up code for serializers. Wrote proper async implementation. * Renamed classes to be more accurate. Removal of commented code. * Moved serializer over to main project. Removed other project and solution. * Added 1 test for the serializer. * Update api. * Added back the separate solution. Named it appropriately. * Addressing some changes from API view comments. * Added some negative tests. Updated public surface descriptions. * In progress writing readmes. * Fixed position reset in deserialization stream. * Made constants for wire format lengths/positions. * Updated property description. Made static field for UTF8 encoding. * Removed unused Directory.Build.props. * Removed unused description. * Continuing readme. Started adding snippets. * First readme completed. * Finally! Created readmes and snippets. * Put credential scope string into a constant. * Addressing a couple documentation PR comments and removed a code comment. * Added global suppressions for namespace name. * Forgot using for memory streams in tests and snippets. * Fixed bugged diagnostic scope names. Put scope names into constants. * Updated ci configuration. Removed resources template since resources cannot be provisioned currently. * Added the other package to CI. * Updated sample file names to match convention. * Added missing readme links. * Fixed the readme snippets so they don't format oddly. * Updated schema components descriptions. * Fixed command to acquire packages. * Rename Atom client (#14931) * [SchemaRegistry] Fix broken test recordings (#14935) * Update tests to use single-line strings. Recording encoding was keeping the /r/n from Windows and breaking everything. * Ignoring tests since I cannot figure out the encoding issue. * Added missing readme sections. * Ignored the other tests as they suffer from the same issue. * Fix readme link. * Really... it needs to say that exact phrase. * Sync eng/common directory with azure-sdk-tools repository for Tools PR 969 (#14928) * stub project for api design activity * swagger updates * Azure SDK updates for Microsoft.Sql (#14844) * Update clients for Microsoft.Sql and update tests for ImportExport * Add SessionRecords for new IE APIs * Undo change done for local testing * Include Alicia's client changes * Add missing models * Update session record for TestImportExistingDatabase * adding in updated test/session for create database test (includes storageAccountType check) * Fix the new ImportExportScenarioTests * trying out another set of generated clients * switch back generated clients, updated database create test * reinstate deleted model, add updated test session * Undo ManagedInstanceOperation model change due to failing pipeline check - will follow up with MI team to do this update separately * Update sql_resource-manager.txt * Checkout Generated before re-generate * Regenerate clients * Update Generated after deleting old Generated folder * Adding coverage for new IE scenarios * Update SDK version and release notes * Re-record existing IE tests after changing test resource name pattern Co-authored-by: xaliciayang <ayang@microsoft.com> * [Storage] OpenRead/Write test recordings are back. (#14963) * Prepare Storage for release * pr feedback. * PR feedback. * pr feedback. * make open write work with using. * move recordings to right place * pr feedback. * record open write tests. * Fix starvation issue with session processor when MaxCallsPerSession > 1 (#14937) * Bump template to the one not used. (#14964) * Unblock Core build by fixing snippet error (#14966) * Re-Generate EventHubs and re-record (#14946) * Re-Generate EventHub and re-record * Update record * new sdk 25.2 (#14948) * Re-generate test common and AppConfiguration. (#14902) * Fix keyvault Readme issues (#14839) * Fix key vault readme issues * modify * Add getcert sample for Key Vault (#14971) Resolves part of #12742 * set release date in changelog (#14972) * set release date in changelog * content * [Event Hubs Client] September Release Updates (#14965) The focus of these changes is to update versions and supporting assets to reflect the September release of the Event Hubs client packages. * Added CassandraTest (#14886) * Increment package version after release of Azure.Data.Tables (#14977) * Update CODEOWNERS (#14979) * Reomve locale links and fix anchor links (#14987) * Reomve locale links and fix anchor links * fixup relative links * move auth section under getting started * fb from different pr * Revert "Re-generate test common and AppConfiguration. (#14902)" (#14978) * Revert "Re-generate test common and AppConfiguration. (#14902)" This reverts commit 35df31a. * Revert testcommon change that broke builds * Added more information to the readme that should be generalized text across languages. Added aka.ms link. (#14990) * Fix issue that homeAccountId string is not parsed correctly into AccountId (#13932) * add .net samples (#14579) add .net samples * [Anomaly Detector] Move sample code under the right snippet (#15003) [Anomaly Detector] Move code under the right snippet * Update CHANGELOGs for Key Vault 4.2.0-beta.1 (#14992) * Add link to sample on KeyVaultCertificate.Cer Resolves #12742 * Update CHANGELOGs for Key Vault 4.2.0-beta.1 * Azure Monitor Exporter - Update codegen (#14895) * Update codegen * Addressing PR Comments * Add Key Vault Administration package to release (#15024) * Update AutoRest C# version to https://github.com/Azure/autorest.csharp/releases/download/3.0.0-dev.20200909.1/autorest-csharp-v3-3.0.0-dev.20200909.1.tgz (#15026) * [Messaging Clients] Microsoft.Azure.Amqp Package Update (#15019) The focus of these changes is to update the version of the `Microsoft.Azure.Amqp` package used by the messaging clients to v2.4.6, which was recently released. This new version contains a fix for a hard crash on .NET v5 and no other changes. * Increment version for schemaregistry releases (#15027) * Increment package version after release of Azure.Data.SchemaRegistry * Increment package version after release of Microsoft.Azure.Data.SchemaRegistry.ApacheAvro * [Storage] OpenWrite - support for metadata, tags and headers (#15023) * Prepare Storage for release * pr feedback. * PR feedback. * pr feedback. * make open write work with using. * move recordings to right place * pr feedback. * Ability to specify metadata tags and headers when opening write stream on block blob. * include metadata in initial request. * EventSourceEventFormatting - catch FormatException (#14697) * EventSourceEventFormatting - catch FormatException * revision 2 * revision 3 * revision 4 * revision 5 * revision 6 Co-authored-by: Pavel Krymets <pavel@krymets.com> * Test Framework - Don't serialize string Json element directly to session (#15007) * [CosmosDB] Add tableResourcesOperations scenario test (#14991) * Add table resources operations scenario test * Add live record file * Update recordings * Update recordings * Remove extra casting * Remove re-initialize CosmosDBClient in test file * Add test for delete table and update the recording file * Increment version for keyvault releases (#15030) * Increment package version after release of Azure.Security.KeyVault.Secrets * Increment package version after release of Azure.Security.KeyVault.Certificates * Increment package version after release of Azure.Security.KeyVault.Keys * Increment package version after release of Azure.Security.KeyVault.Administration * Fix typo (#15038) * Add parameters to function (#14999) * [Anomaly Detector] Fix links in the samples README (#15042) * Renamed Package RegionMove to ResourceMover (#15044) * Changed Package RegionMove to ResourceMover * Updated resource-manager filename for regionmove to resourcemover. Co-authored-by: Ajay Gupta <ajgupt@microsoft.com> * update version to beta (#15045) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 982 (#15050) * Reoving required parameters (#15039) * Enable a way to Unregister Message Handler and Session Handler (#14021) * add UnregisterMessageHandler method * Update sdk/servicebus/Microsoft.Azure.ServiceBus/src/Core/IReceiverClient.cs Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com> * Update sdk/servicebus/Microsoft.Azure.ServiceBus/src/Core/MessageReceiver.cs Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com> * Update the unregister method to be async and await for inflight operations to finish * Update sdk/servicebus/Microsoft.Azure.ServiceBus/src/SubscriptionClient.cs Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com> * Update sdk/servicebus/Microsoft.Azure.ServiceBus/src/Core/MessageReceiver.cs Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com> * Update sdk/servicebus/Microsoft.Azure.ServiceBus/src/QueueClient.cs Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com> * Change name to have async suffix and add to existing onMessageQueueTests * Add UnregisterSessionHandlerAsync and corresponding tests * nit * nit * Add a new cancellation type to not cancel inflight message handling operations when unregister is called. * Add another type of cancellation token to session handler path * nit * Add a timeout parameter to unregister functions and add according unit tests * nit * cancel runningTaskCancellationTokenSource after unregister is done * change public API * update the API header * update the API definition * fix spacing * fix ApproveAzureServiceBus CIT test Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com> * [AppConfig] Adding new parameter 'PublicNetworkAccess' for ConfigurationStoreUpdateParameters (#14682) * Update autorest commit ID & generate code files * Update changelog and readme * Fix unit test and update test recordings * Update generated code after running eng\scripts\Export-API.ps1 * Service Bus Migration Guide improvements (#14166) * Enable master link replacement feature in .NET (#15040) * Update changelog (#15060) * [SchemaRegistry] Fix core build (#14968) * Made snippet names unique. * Fix readme links. * Rerecorded tests and enabled them. * Increment package version after release of Azure.Messaging.ServiceBus (#15080) * Add release date (#15084) * [Event Hubs Client] Idempotent Producer Client (#15034) The focus of these changes is implementing the idempotent publishing feature infrastructure into the `EventHubProducerClient` and associated types, refactoring the current structure to support idempotent and non-idempotent publishing as unique code paths. Not included in these changes is the addition of the `ReadPartitionPublishingProperties` member and live tests; those will be covered in dedicated work streams. * Fixed test recording mode (#15100) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 965 (#14909) * Added Close and RetainUncommitedData to DataLakeFileUploadOptions (#15046) * Add changelog to SDK version 5.0.0 (#15073) * add changelog to version 5.0.0 * nit * update changelog and add release date * targeting 2.1 (#15079) * Update AutoRest C# version to https://github.com/Azure/autorest.csharp/releases/download/3.0.0-dev.20200911.1/autorest-csharp-v3-3.0.0-dev.20200911.1.tgz (#15107) * Fixed bug where DataLakeFileClient.Rename(), DataLakePathClient.Rename(), and DataLakeDirectoryClient.Rename() couldn't handle source paths with special characters (#15106) * [Storage] Make Specialized Blob Clients retrieval mockable. (#15105) * Prepare Storage for release * pr feedback. * PR feedback. * pr feedback. * make open write work with using. * move recordings to right place * pr feedback. * make specialized clients retrieval mockable. * pr feedback. * export api. * record mode... * Fix #14974: [BUG] DefaultAzureCredential improperly catches AuthenticationFailedException (#15057) * Fix #14974: [BUG] DefaultAzureCredential improperly catches AuthenticationFailedExcpetion * Check for cancellationToken * - Update Changelog - Add workaround for test playback * Addressed PR comments * Addressed Error for Events Missing Required Fields (#15076) * Handled deserialization of events with missing fields Should throw an error if required fields for EventGridEvent are missing when Parse is called * Added tests for this error * Added a similar constructor in CloudEvent that checks if Id (a required field) is null * Sync eng/common directory with azure-sdk-tools for PR 973 (#14995) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 973 * Update update-docs-metadata.ps1 * Update update-docs-metadata.ps1 Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com> * Treat service directory as single scope (#15114) * Treat service directory as single scope Relates to #14969 * Resolve PR feedback * Add the option to have UserAssignedMsi when authentication uses KeyVault certificate. Previously, the code would only use the system assigned MSI if any. (#14676) Co-authored-by: dnicolescu <dnicolescu@hotmail.com> * Probe IMDS /metadata/instance endpoint during discovery in MsiAccessTokenProvider (#14631) * Call imds instance endpoint instead of token endpoint to probe for imds, extend timeout * Update msi token tests to distinguish between which imds endpoint is being called * Fix comment and visibility in test * Change per stpetrov * re-trigger checks * Add migration guide for Key Vault secrets (#15118) * Add migration guide for Key Vault secrets Relates to #12108 * Update mgmt.yml for Azure Pipelines Updating the casing AutoManage to Automanage * [Event Hubs Client] Idempotent Producer Client (#15125) The focus of these changes is to enable the `EventDataBatch` to reserve appropriate space for publishing sequence numbers, when required by the active producer configuration and to complete the client API surface by implementing the `ReadPartitionPublishingProperties` method. * Add EventGrid WebJobs extension (#15058) * Consume generator as a package (#15133) Generator, Autorest shared soure and targets are all packed into a single nuget package now. * Use node 13 for CodeGeneration and merge pipelines (#14989) * Stowen/automanage fix casing (#15136) * Includes Generated Files And Half Of Unit Test Coverage * tests completed * updated readme * updated versions, included AssemblyInfo * removed unneeded package references * updated assemblyname to properCasing * Rename Microsoft.Azure.Management.Automanage.sln to Microsoft.Azure.Management.AutoManage.sln * casing fixes * added metadata file * lineending+ * newline-- * changed hardcoded reference to dotnet coreapp31 * PR feedback, fixed csproj hard coded versions, added required properties to csproj * fixing ambiguous package name error * fixed version number * fix wrong reference in generate * PRfeedback, fixed incorrect tag references, version numbers, and remove unneeded dotnet version * pr feedback, fixing missing session records * renamed missing test * fixed old test * changed casing to match RP * bulk rename Co-authored-by: Stephen Owen <stephen.owen@microsoft.com> * Update mgmt.yml for Azure Pipelines to include MySQL (#15150) * Update CODEOWNERS (#15037) Update the AzConfig label * Generate the MySQL SDKs 0.1.0 public preview (#15116) * Add MySQL SDKs and tests * Change to 0.1.0 version * commit to trigger the pipelines * updating release notes Co-authored-by: Raj Sellappan <rajsell@microsoft.com> * Generate PostgreSQL SDKs 0.9.5 public preview (#15115) * Generate PostgreSQL SDKs and tests * updating release notes for PostgreSQL Co-authored-by: Raj Sellappan <rajsell@microsoft.com> * Increment package version after release of Azure.Messaging.EventGrid (#14980) * Added Close to DataLakeOpenWriteOptions, removed RetainedUncommittedData from DataLakeUploadOptions (#15140) * Updated hybrid compute project (#14797) * initial-updates * working tests * remove ctor * new tests * feedback * json files * updated session files * update to 2020-08-02 Co-authored-by: Tyler Leonhardt (POWERSHELL) <tyleonha@microsoft.com> * Add migration guides for KV certs and keys (#15147) * Add migration guides for KV certs and secrets Resolves #12108 * Add README links to MigrationGuide.md docs For all services that currently have them. * Update AutoRest C# version (#15145) * Expose select query option on GetEntity (#15161) * Expose select query option on GetEntity * Introduce an exponential retry for service timing issue causing flakey Live tests (#15159) see https://dev.azure.com/azure-sdk/internal/_build/results?buildId=537514&view=results * Added skipPublishDocMs and github io for each artifact (#15119) * Update code owners file for azure template (#14767) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 999 (#15165) * Update verbiage of changelog (#15177) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 1000 (#15166) * Add sql test for cosmosdb (#15055) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 974 (#14997) * Update FromObjectAsync return type (#15192) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 895 (#14996) * [Event Hubs Client] Integrate v5.3.0-beta.1 Release Branch (#15162) (#15181) The focus of these changes is to integrate the release branch for Event Hubs v5.3.0-beta.1. The release introduces an option for the various event consumers allowing the prefetch cache to be filled based on a size-based heuristic rather than a count of events. This feature is considered a special case, helpful in scenarios where the size of events being read is not able to be known or predicted upfront and limiting resource use is valued over consistent and predictable performance. * remove dev endpoint for testing (#15208) * Update AutoRest C# version (#15209) * Reorder backup and restore operation ctor args and add sample (#15205) fixes #15065 * [Storage] Queues one message receive (#15180) * Prepare Storage for release * pr feedback. * PR feedback. * pr feedback. * make open write work with using. * move recordings to right place * pr feedback. * receive one message. * peek one message * api * remove redundant scope. * pr feedback. * Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#15216) * Organize published artifacts (#14832) * Begin rearranging published packages * Add step to arrange artifacts * Remove steps for testing * Swtich output directory * Remove analyze and test pipeline * Remove artifact staging from release stages * Fix Doc Upload * Bump Template version, remove test and analyze job * Uncomment deployment steps * ReAdd release stage * Remove stage artifacts file * Bump up template version * Update archetype-net-release.yml and copy-docs-to-blobstorage.ps1 * Make use of VerifyPackages to retrieve pkg properties * Update template version to test release * Bump Azure Template * Update dotnet upload docs code (#15218) * Update CHANGELOG.md (#15234) * Deserialize custom dimensions from application insights API response (#14917) * Deserialize custom dimensions from application insights API response. Fixes #13042 * Test non-empty CustomDimensions from application insights API response Co-authored-by: Oleg Deribas <olegd@superoffice.com> * Increment package version after release of Azure.AI.TextAnalytics (#15239) * Update AutoRest C# version (#15238) * [CosmosDB] Add database account operations tests (#15189) * Fix error in directions in Key Vault READMEs (#15213) * Switch ApiCompat to use PackageDownload (#15250) Turns out instead of using the apicompat project workaround we can use a PackageDownload reference to get the last shipped package. This allows us to do the apicompat check completely inside the project we are checking. * Replaced relative link with absolute links and remove locale (#15223) Replaced relative link with absolute links and remove locale * Add MongoDB operations tests and it's recordings (#15254) * Enable the link check on aggregate-report (#15257) * Increase diagnostics-id overhead in EventDataBatch (#15193) * Increment package version after release of Microsoft.Azure.ServiceBus (#15111) * Increment package version after release of Microsoft.Azure.HDInsight.Job (#14291) * Update EventTypes.cs (#13569) * Fix nullability on Search models (#15240) Fixes #15108 * Update CODEOWNERS (#15244) * Added azure monitor entry. * Change label entry * New label * Increment version for synapse releases (#14751) * Increment package version after release of Azure.Analytics.Synapse.Spark * Increment package version after release of Azure.Analytics.Synapse.Artifacts * Increment package version after release of Azure.Analytics.Synapse.AccessControl * Increment version for identity releases (#15113) Increment package version after release of Azure.Identity * [Azure Messaging] README Updates (Troubleshooting + Logging) (#15237) The focus of these changes is to enhance the troubleshooting section of the README documentation with information about logging and distributed tracing, calling out to the existing Azure.Core resource for details. * Fixed link to Azure SDK Design Guidelines for .NET (#15210) * Increase connection pool size limit automatically (#15263) * updated .NetSDK version for Websites to 2020-06-01 (#15230) * updated .NetSDK version for Websites to 2020-06-01 * Updated API version targetting to 2020-06-01 * Fix potential deadlock in checking database account name existence (#15255) * Dns ZoneType Change (#15236) * WIP: Initial CRUD and List test for record and zone * WIP: Port of cloud issues * WIP: OneTimeTearDown and setup working. No double test runs * WIP: don't make zone twice * WIP: Commit test * WIP: Fix changelog and readme * WIP: Fix yaml * WIP: Fix yml 2 * WIP: Remove unused function * Remove .swp file * Remove SWP file * Update DNS Track 2 test * Add Tests Recordings * Fix Class name * WIP: Update tests * WIP: Make exception test clearner * WIP: Update live test records * Revert json change * Small fixes * WIP: Update SLN * WIP: Dns gen update * Revert "WIP: Dns gen update" This reverts commit 2c0317c. * WIP: make zonetype obsolete * WIP: make zone type readonly * WIP: update test * WIP: Make all private relate fields obsolete * WIP: only change things we want to change * WIP: Update test * WIP: Update test * WIP: update test correctly Co-authored-by: bqauntump <bqauntump@DESKTOP-B63NOF4.localdomain> * Remove obsolete conditions from Search (#15268) Fixes #14096 to simplify the code for upcoming changes. * pr fb * Revert "Merge remote-tracking branch 'upstream/master' into api-learn-api-activity" This reverts commit e483353, reversing changes made to 8b7b2d6. Co-authored-by: Meha Kaushik <kaushik.meha@gmail.com> Co-authored-by: Meha Kaushik <mekaushi@microsoft.com> Co-authored-by: Christopher Scott <chriss@microsoft.com> Co-authored-by: Mariana Rios Flores <mariari@microsoft.com> Co-authored-by: Timothy Mothra <tilee@microsoft.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> Co-authored-by: bikamani <41314966+bikamani@users.noreply.github.com> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com> Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: Sean McCullough <44180881+seanmcc-msft@users.noreply.github.com> Co-authored-by: Scott Schaab <sschaab@microsoft.com> Co-authored-by: David R. Williamson <drwill@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: strehan1993 <70013163+strehan1993@users.noreply.github.com> Co-authored-by: Heath Stewart <heaths@microsoft.com> Co-authored-by: Chou Hu <abelch@microsoft.com> Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com> Co-authored-by: Jingshu923 <52914166+Jingshu923@users.noreply.github.com> Co-authored-by: wonner <yw1997yw@126.com> Co-authored-by: Wan Yang <t-wayang@microsoft.com> Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com> Co-authored-by: timtay-microsoft <timtay@microsoft.com> Co-authored-by: Allen Zhang <allenzhang@live.com> Co-authored-by: vinagesh <vinagesh@outlook.com> Co-authored-by: Kerri Lee <52222716+kerri-lee@users.noreply.github.com> Co-authored-by: Auðunn <audunnb@gmail.com> Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Mikhail <mitryakh@microsoft.com> Co-authored-by: Christopher Scott <chriscott@hotmail.com> Co-authored-by: Heath Stewart <heaths@outlook.com> Co-authored-by: Arvind Krishnaa J <arv100.kri@gmail.com> Co-authored-by: Arvind Krishnaa Jagannathan <arjagann@microsoft.com> Co-authored-by: Dhawal Jain <41853104+dhawal777@users.noreply.github.com> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: Stephen Owen <69686895+stowen-msft@users.noreply.github.com> Co-authored-by: Stephen Owen <stephen.owen@microsoft.com> Co-authored-by: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com> Co-authored-by: Jesse Squire <jsquire@microsoft.com> Co-authored-by: Alexander Sher <AlexanderSher@users.noreply.github.com> Co-authored-by: bquantump <53361486+bquantump@users.noreply.github.com> Co-authored-by: bqauntump <bqauntump@DESKTOP-B63NOF4.localdomain> Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com> Co-authored-by: Mitch Denny <midenn@microsoft.com> Co-authored-by: Charles Lowell <chlowe@microsoft.com> Co-authored-by: Michael Yanni <MiYanni@microsoft.com> Co-authored-by: brandong-ms <44618010+brandong-ms@users.noreply.github.com> Co-authored-by: xaliciayang <ayang@microsoft.com> Co-authored-by: Minghao Chen <30464227+HarveyLink@users.noreply.github.com> Co-authored-by: hutzleo <8101994+hutzleo@users.noreply.github.com> Co-authored-by: Tianyun Gao (MSFT) <65581162+Tianyun-G@users.noreply.github.com> Co-authored-by: nisha-bhatia <67986960+nisha-bhatia@users.noreply.github.com> Co-authored-by: erich-wang <eriwan@microsoft.com> Co-authored-by: Congrui <43364740+conhua@users.noreply.github.com> Co-authored-by: asrosent <36705352+asrosent@users.noreply.github.com> Co-authored-by: Yalin Li <yall@microsoft.com> Co-authored-by: ajaygit158 <61898818+ajaygit158@users.noreply.github.com> Co-authored-by: Ajay Gupta <ajgupt@microsoft.com> Co-authored-by: navysingla <47647464+navysingla@users.noreply.github.com> Co-authored-by: DorothySun216 <55454966+DorothySun216@users.noreply.github.com> Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com> Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com> Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> Co-authored-by: Dan Nicolescu <dan.nicolescu@microsoft.com> Co-authored-by: dnicolescu <dnicolescu@hotmail.com> Co-authored-by: Isaac Sarek Banner <70341725+isaacbanner@users.noreply.github.com> Co-authored-by: Alex Ghiondea <AlexGhiondea@users.noreply.github.com> Co-authored-by: gechris <69321460+gechris@users.noreply.github.com> Co-authored-by: Raj Sellappan <rajsell@microsoft.com> Co-authored-by: Tyler James Leonhardt <tylerl0706@gmail.com> Co-authored-by: Tyler Leonhardt (POWERSHELL) <tyleonha@microsoft.com> Co-authored-by: Gene Hazan <geneh@users.noreply.github.com> Co-authored-by: Oleg Deribas <olegd@superoffice.com> Co-authored-by: Serkant Karaca <serkantkaraca@users.noreply.github.com> Co-authored-by: xioyi <63267723+xioyi@users.noreply.github.com> Co-authored-by: Alexander Batishchev <abatishchev@gmail.com> Co-authored-by: Kota Sudhakar Reddy <60102891+Kotasudhakarreddy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve the Migration Guide for Service Bus along the below lines:
Please note, I am no C# expert. I have copied some of the code snippets and made up most of the others :)
Relying on @JoshLove-msft to catch my mistakes