Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Azure.Identity has a dependency to Windows.Forms (due to older MSAL) for all Windows builds #44232

Closed
pedrolupin opened this issue May 24, 2024 · 3 comments
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@pedrolupin
Copy link

Library name and version

Azure.Identity

Describe the bug

This is related to this MSAL bug which has been fixed:
AzureAD/microsoft-authentication-library-for-dotnet#4468

MSAL fixed it and released a new version, 4.61.0 a couple of weeks ago.

It seems that it's not yet being picked up by Azure.Identity 1.12 beta 3 yet.
Could you include MSAL 4.61.0 in your next release please?

Expected behavior

Reference to MSAL 4.61.0 to avoid Desktop SDK in server installs.

Actual behavior

Server build requires desktop SDK to run.

Reproduction Steps

Azure.Identity 1.9.0 -> Microsoft.Identity.Client 4.49.1 did not have a dependency on System.Windows.Forms, but when updating to newer Azure.Identity 1.10.4 -> Microsoft.Identity.Client 4.56.0 the dependency to Windows.Forms appeared, this is a problem.

Azure.Identity should be able to run headless, on servers and many situations that don't have access to System.Windows.Forms because the .NET desktop runtime is not present.

Environment

No response

@github-actions github-actions bot added Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 24, 2024
Copy link

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@Ramo-Y
Copy link
Contributor

Ramo-Y commented May 30, 2024

We also had the same issue after updating Azure.Identity. The pipelines for the integration tests no longer ran because the .NET Desktop Runtime is not installed on the agents. The application did not run either, as the runtime is not available on the web server either.

We solved the problem by manually installing Microsoft.Identity.Client with version 4.61.1, the WindowsForms references were then gone.

It took us time to find and fix the error, the dev environment was down during this time. It would have been helpful if this breaking change was described in the changelogs, I read through them before I made the updates.

@christothes
Copy link
Member

These changes were not intentional, so unfortunately, we never knew to document them as breaking. This will be fixed in the next release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
Development

No branches or pull requests

3 participants