Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Exposing the selected credential on ChainedTokenCredential #16683

Merged
4 commits merged into from
Aug 6, 2021

Conversation

sadasant
Copy link
Contributor

@sadasant sadasant commented Jul 30, 2021

ChainedTokenCredential and DefaultAzureCredential now expose a property named selectedCredential, which will store the selected credential once any of the available credentials succeeds.

Related to #15803

@sadasant sadasant self-assigned this Jul 30, 2021
@ghost ghost added the Azure.Identity label Jul 30, 2021
@KarishmaGhiya
Copy link
Member

Do we need to do this for Application Credential too? @sadasant

@sadasant
Copy link
Contributor Author

sadasant commented Aug 6, 2021

@KarishmaGhiya ApplicationCredential should automatically pick this up after this is merged :)

@ghost
Copy link

ghost commented Aug 6, 2021

Hello @sadasant!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 535e026 into Azure:main Aug 6, 2021
@sadasant sadasant deleted the identity/fix15803-expose-credential branch August 6, 2021 23:24
sadasant added a commit to sadasant/azure-sdk-for-js that referenced this pull request Aug 27, 2021
sadasant added a commit that referenced this pull request Aug 31, 2021
* Revert "[Identity] Exposing the selected credential on ChainedTokenCredential (#16683)"

This reverts commit 535e026.

* changelog update
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants