-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Identity] Exposing the selected credential on ChainedTokenCredential #16683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
schaabs
approved these changes
Aug 6, 2021
Do we need to do this for Application Credential too? @sadasant |
KarishmaGhiya
approved these changes
Aug 6, 2021
@KarishmaGhiya ApplicationCredential should automatically pick this up after this is merged :) |
Hello @sadasant! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
xirzec
reviewed
Aug 6, 2021
sadasant
added a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Aug 27, 2021
…edential (Azure#16683)" This reverts commit 535e026.
sadasant
added a commit
that referenced
this pull request
Aug 31, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChainedTokenCredential
andDefaultAzureCredential
now expose a property namedselectedCredential
, which will store the selected credential once any of the available credentials succeeds.Related to #15803