Nickel Community Feature Requests related to StaticTokenCredential / token helper methods

[joshfree]

Tracking Item to review the top customer-requested enhancements from the previous semester. We will prioritize this list and fit in as many as possible in the final coding milestone of this semester (After all must-have features are completed first). See @g2vinay and @jongio

Ex unordered short list:

• Feature: Expose Credential type for DefaultAzureCredential and ChainedTokenCredential
  • Enables users know which credential type is being used. #8948.
    Resolved via logging approach.
  • JS PR: [Identity] Exposing the selected credential on ChainedTokenCredential #16683 (Note: This PR should be reverted).
• Enable MSAL Logging
• ** Enable PII Logs [FEATURE REQ]Enable MSAL log and MSAL PII Logs #17281 Moved to next milestone.~ We’ve decided to not do this for JS.
• ** Log the username that Shared Token Cached Credential loads Log the username that gets loaded from Shared Token Cache credential #17280. Blocked on [Identity] Implement the SharedTokenCacheCredential #17284 We’ve decided to not do this for JS.
• ** Improve Azure Identity SDK Error Messages and logging details Improve The Azure Identity Error messages and logging details #17337
• ** Add Support for Client Id Env Var support in Managed Identity Credential. [FEATURE REQ] Add support for AZURE_CLIENT_ID environment variable to ManagedIdentityCredential #8436
• ** Add Samples Explaining How to use Chained Token Credential Add Samples explaining how to use Chained Token credential #17282
• ** Add Samples demonstrating implementing Token Credential directly with MSAL / ADAL Add Samples demonstrating implementing Token Credential directly with MSAL / ADAL #17283
• Request: provide the functionality of setting tenant id for AzureCliCredential (request)
  • See comment: Nickel Community Feature Requests related to StaticTokenCredential / token helper methods #15803 (comment)

[sadasant]

This is already supported Request: provide the functionality of setting tenant id for AzureCliCredential: https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/identity/identity/src/credentials/azureCliCredential.ts#L93

[sadasant]

Regarding: Expose Credential type for DefaultAzureCredential and ChainedTokenCredential,

We merged this: #16683

However, the customer that wanted this feature was ok with logging, so we’ll revert this PR.

[sadasant]

@g2vinay is this issue up to date? I don’t think every item here is still in the plans. I could be wrong!

[sadasant]

@g2vinay we didn’t talk about these during our meeting yesterday:

• Request: Add support for fetching an access token from a refresh token
• Request: provide the functionality of building a token credential from (a: existing credential, b: tenant id) for refresh token based credentials: InteractiveBrowserCredential and DeviceCodeCredential, VisualStudioCodeCredential (request)
• Request: provide a valid token in VisualStudioCodeCredentialBuilder without tenant id, use this token we can list the tenants (request)
• Request: provide the functionality of listing cached account(azure environment, tenant id, user name, client id) for SharedTokenCacheCredential (request)

Are these out of our current schedule?

[joshfree]

@g2vinay can you please update (Edit the text) this tracking issue to reflect the actual approved list of improvements we're tracking for this release month

[sadasant]

For context, I met with @g2vinay on Friday to discuss the community tasks scoped for JS’s GA and he created the following issues: https://github.com/Azure/azure-sdk-for-js/issues?q=is%3Aopen+is%3Aissue+assignee%3Asadasant+milestone%3A%22%5B2021%5D+September%22+author%3Ag2vinay

I’ve added them to the current milestone since we have answers for them.

If I’m missing anything, I’ll follow up during next milestone.

[sadasant]

The only remaining issue in this milestone from the list at the top is: #8436

All of the others have been moved to the next milestone by this point.

[sadasant]

Moved to October for the last two issues remaining on this list.

[joshfree]

** Improve Azure Identity SDK Error Messages and logging details Improve The Azure Identity Error messages and logging details #17337
** Add Support for Client Id Env Var support in Managed Identity Credential. [FEATURE REQ] Add support for AZURE_CLIENT_ID environment variable to ManagedIdentityCredential #8436

@sadasant / @KarishmaGhiya can you give an update on the last 2 open items?

[sadasant]

@joshfree yes!

1. Karishma will be working on improving the error messages. First, she’ll write the troubleshooting guide similar to Java’s proposal. Then, she’ll copy Java’s approach on error handling, the one that includes a link to the troubleshooting guide.
2. There are still emails back and forward regarding what name is correct for this env variable, so I’m waiting on those emails to reach to a conclusion before we add this feature.

[sadasant]

I’ve marked the AZURE_CLIENT_ID change as done since, based on our emails, we’ve decided not to include this change.

[joshfree]

Can this issue be closed out now?

[sadasant]

@joshfree not yet, this PR is still open: #17734