Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] [Identity] CAE support. #13388

Closed
wants to merge 16 commits into from

Conversation

sadasant
Copy link
Contributor

@sadasant sadasant commented Jan 26, 2021

Draft for the CAE support.

Done so far:

  • Translate the challenge code from other languages.
  • Implement the onBeforeRequest method and the onChallenge method.
  • Move Key Vault from the custom challenge authentication code to this core challenge authentication.
  • Ensure existing tests pass for Key Vault.
  • Add tests to the parsing of the challenges.

TODOs:

  • Separate the changes on the BearerTokenAuthenticationPolicy into a new class, BearerChallengeAuthenticationPolicy.
  • Hide CAE challenge details from the public API. Keep it generic.
  • Test values with commas on the parsing of the challenges.
  • Get Jeff's feedback ('cause core-http changes).
  • Get Identity's feature crew's feedback.
  • Write mocked tests for the CAE requests.
  • Test this on the CAE champion scenarios.

Once approved (eventually):
Fixes #13156

@check-enforcer

This comment has been minimized.

@sadasant sadasant changed the title [Identity] CAE support. [DO NOT MERGE] [Identity] CAE support. Feb 3, 2021
@sadasant
Copy link
Contributor Author

sadasant commented Feb 3, 2021

Adding [DO NOT MERGE] since we're pondering to release a patch first from a stable master, then include CAE and MSAL 2.0 in a beta release.

@sadasant sadasant force-pushed the feature/13156-identity-cae branch from 84eefda to 76f6f4e Compare February 4, 2021 23:17
@sadasant
Copy link
Contributor Author

sadasant commented Mar 1, 2021

Closed on favor of #13888

@sadasant sadasant closed this Mar 1, 2021
@sadasant sadasant deleted the feature/13156-identity-cae branch March 1, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Identity] Implement Continuous Access Evaluation
1 participant