Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Key Vault] Use the CAE feature. #14306

Closed
sadasant opened this issue Mar 16, 2021 · 0 comments · Fixed by #15881
Closed

[Key Vault] Use the CAE feature. #14306

sadasant opened this issue Mar 16, 2021 · 0 comments · Fixed by #15881
Assignees
@maorleger
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] July

Comments

@sadasant
Copy link
Contributor

sadasant commented Mar 16, 2021 •
edited
Loading

Once CAE is merged to the new core, Key Vault should use it.

Let's sync on when we get there. The changes should be small, I have already done a similar set of changes in a previous PR (that I did when I did CAE in the old core).

The reason we want to move Key Vault to the new core is to use CAE. Here's the PR where I did that with the old core (we decided to close it since we decided to have the feature on the new core): #13388
@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. KeyVault labels Mar 16, 2021
@sadasant sadasant added this to the [2021] April milestone Mar 16, 2021
@maorleger maorleger modified the milestones: [2021] April, [2021] May Mar 29, 2021
@maorleger maorleger modified the milestones: [2021] May, [2021] June Apr 6, 2021
@maorleger maorleger modified the milestones: [2021] June, [2021] July May 3, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue May 8, 2021
CodeGen from PR 14306 in Azure/azure-rest-api-specs
696ec22 
Adding incremental changes to update extension apis (Azure#14306)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue May 14, 2021
CodeGen from PR 14306 in Azure/azure-rest-api-specs
c752475 
Adding incremental changes to update extension apis (Azure#14306)
@maorleger maorleger modified the milestones: [2021] July, [2021] August Jun 8, 2021
@maorleger maorleger assigned sadasant and unassigned maorleger Jun 8, 2021
@maorleger maorleger modified the milestones: [2021] August, [2021] July Jun 8, 2021
@sadasant sadasant assigned maorleger and unassigned sadasant Jun 15, 2021
@maorleger maorleger mentioned this issue Jun 22, 2021
Merged
maorleger added a commit that referenced this issue Jun 23, 2021
@maorleger
[KeyVault] - Migrate Key Vault Admin package to Core V2 (#15881)
b499bfb 
## What

- Migrate @azure/keyvault-admin to core V2
- Migrate `KeyVaultBackupClient` and `KeyVaultAccessControlClient` to core CAE
- Bump our minimum `@azure/core-lro` version to 1.0.6

## Why

This PR proves out two important things: it demonstrates that core continuous access evaluation works for both container 
registry (already done) and Key Vault (this PR). It also demonstrates the migration path for Core V2 for Key Vault.

The change to core-lro addresses an issue where core-lro was incorrectly depending on core-http (#15880)  That has been fixed on 1.0.6 
and allows package owners to migrate to core-rest-pipeline and remove core-http without seeing build breaks.


Resolves #15522 
Resolves #14306
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] July
Development

Successfully merging a pull request may close this issue.

[KeyVault] - Migrate Key Vault Admin package to Core V2 maorleger/azure-sdk-for-js
2 participants
@sadasant @maorleger