Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests not executed in pipeline #20700

Merged
merged 4 commits into from
Apr 16, 2021
Merged

Fix tests not executed in pipeline #20700

merged 4 commits into from
Apr 16, 2021

Conversation

chenrujun
Copy link

  1. Fix tests not executed in azure-spring-boot-test-aad
  2. Fix tests not executed in azure-spring-boot-test-aad-b2c

@rujche
1. Fix tests not executed in azure-spring-boot-test-aad
c6d6ac0 
2. Fix tests not executed in azure-spring-boot-test-aad-b2c
@ghost ghost added the azure-spring All azure-spring related issues label Apr 15, 2021
@chenrujun
Copy link
Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link
Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun chenrujun added azure-spring-aad Spring active directory related issues. azure-spring-aad-b2c Spring active directory b2c related issues. Client This issue points to a problem in the data-plane of the library. labels Apr 15, 2021
@chenrujun chenrujun added this to the [2021] May milestone Apr 15, 2021
@chenrujun
Copy link
Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun chenrujun mentioned this pull request Apr 16, 2021
Merged
@chenrujun
Copy link
Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saragluna
Copy link
Member

Why is junit5 required here?

@chenrujun
Copy link
Author

chenrujun commented Apr 16, 2021 •
edited
Loading

@saragluna

After upgrade to spring-boot:2.4.0, the default junit is junit-5.
If we want to use junit-4, we need to add extra dependencies: junit-vintage-engine.
To make things simple and fit newest spring-boot, I prefer junit-5.

Refs: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.4-Release-Notes#junit-5s-vintage-engine-removed-from-spring-boot-starter-test

backwind1233
backwind1233 approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@backwind1233 backwind1233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenrujun chenrujun merged commit 859f357 into Azure:master Apr 16, 2021
@chenrujun chenrujun deleted the fix/aad-tests-are-not-executed-in-pipeline branch April 16, 2021 05:45
@backwind1233 backwind1233 mentioned this pull request Apr 16, 2021
Closed
@chenrujun chenrujun mentioned this pull request Apr 19, 2021
Merged
benbp pushed a commit that referenced this pull request Apr 28, 2021
@benbp
Fix tests not executed in pipeline (#20700)
634d42b
@saragluna saragluna mentioned this pull request May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@backwind1233 backwind1233 backwind1233 approved these changes

@jialindai jialindai Awaiting requested review from jialindai

@saragluna saragluna Awaiting requested review from saragluna

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees

@backwind1233 backwind1233

@chenrujun chenrujun

@saragluna saragluna

Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. azure-spring-aad-b2c Spring active directory b2c related issues. Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] May
Development

Successfully merging this pull request may close these issues.
4 participants
@chenrujun @saragluna @backwind1233 @rujche