Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Spring UT/IT to use JUnit 5 #21386

Closed
saragluna opened this issue May 13, 2021 · 2 comments
Closed

Upgrade Spring UT/IT to use JUnit 5 #21386

saragluna opened this issue May 13, 2021 · 2 comments
Assignees
@saragluna
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] June

Comments

@saragluna
Copy link
Member

Spring Boot 2.4 remove the Junit5's vintage engine from spring-boot-starter-test so if we still use Junit4 API in our test cases, these tests will not run in Maven build or IDEA, unless:

So we might need to upgrade all of our tests to JUnit 5.
@saragluna saragluna added Client This issue points to a problem in the data-plane of the library. azure-spring All azure-spring related issues labels May 13, 2021
@saragluna saragluna self-assigned this May 13, 2021
@saragluna saragluna added this to the [2021] June milestone May 13, 2021
@saragluna saragluna mentioned this issue May 13, 2021
Merged
@saragluna
Copy link
Member Author

@ZhuXiaoBing-cn please help with this issue.

@saragluna
Copy link
Member Author

Closing in #21670.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@saragluna saragluna

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] June
Development

No branches or pull requests
1 participant
@saragluna