ACS Chat: Swagger update #18744
Merged
ACS Chat: Swagger update #18744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danielgerlag
commented
Jan 21, 2021
danielgerlag
commented
- Updated the swagger for ACS Chat
- Ran autorest agiainst new swagger
- Removed ChatMessagePriority
- Recorded new test sessions
danielgerlag
requested review from
ankitarorabit,
JianpingChen,
minnieliu,
RezaJooyandeh and
a team
as code owners
ghost
added
the
angiurgiu
approved these changes
Jan 22, 2021
|
@danielgerlag For the coming work on identifiers, we will need to sync up with the changes in common. For instance: |
danielgerlag
added a commit
that referenced
this pull request
Jan 29, 2021
* refresh swagger.json * run autorest * embedme * remove ChatMessagePriority.java * hide implementation * record test sessions
danielgerlag
added a commit
that referenced
this pull request
Feb 4, 2021
* refresh swagger.json * run autorest * embedme * remove ChatMessagePriority.java * hide implementation * record test sessions
juancamilor
pushed a commit
that referenced
this pull request
Feb 6, 2021
* ACS Chat: Changes for API version: 2020-11-01-preview3 (#17790) * regen autorest rename ChatThreadMember -> ChatParticipant rename ReadReciept -> ChatMessageReadReciept * Update response code for non-existing thread * fix style errors * live test session records * SendMessage returns MessageId instead of SendChatMessageResult * update README.md with new namings * run embedme on README.md * pr feedback - system message names * pr feedback * ACS Chat - Preview 3 - Add single thread participant convenience method (#17800) * add methods for adding a single participant to a chat thread * add tests for new methods * add recorded test sessions for new tests * refactor `updateChatThread` to `updateTopic` (#17791) * ACS Chat: Preview 3 refactor (#17910) * use local swagger.json * fix AutoRest directive to match new swagger * run AutoRest, update wrapper code accordingly * more refactoring against new swagger generated code * correct actual vs. expected in assertions * update test session recordings * sync README.md * expose sync overloads * add tests * update README.md * pr feedback * ACS chat: Api changes jan 2021 (#18574) * run autorest against new swagger, fix what breaks * test for html message * record new live tests * update README.md * post-rebase fixes * update tests after rebase * adjust coverage on rebase * ACS Chat: Swagger update (#18744) * refresh swagger.json * run autorest * embedme * remove ChatMessagePriority.java * hide implementation * record test sessions * ACS-Chat: Default repeatability ID (#18833) * default repeatabilityRequestId * test sessions * post rebase fixes * test sessions * test sessions * run embedme * fix line number issue with readme snippets * style error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.