ACS chat: Api changes jan 2021 #18574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danielgerlag
commented
Jan 12, 2021
danielgerlag
commented
- Pulled in the latest swagger from the INT Api
- Ran AutoRest against the new swagger
- Updated breaking changes
- Added test for HTML content
- Recorded new test sessions for playback
danielgerlag
requested review from
ankitarorabit,
JianpingChen,
minnieliu,
RezaJooyandeh and
a team
as code owners
ghost
added
the
angiurgiu
requested changes
Jan 12, 2021
.../azure-communication-chat/src/main/java/com/azure/communication/chat/models/ChatMessage.java
Show resolved
Hide resolved
...re-communication-chat/src/main/java/com/azure/communication/chat/models/ChatMessageType.java
Outdated
Show resolved
Hide resolved
...unication-chat/src/main/java/com/azure/communication/chat/models/SendChatMessageOptions.java
Show resolved
Hide resolved
...on/azure-communication-chat/src/samples/java/com/azure/communication/chat/ReadmeSamples.java
Show resolved
Hide resolved
danielgerlag
added a commit
that referenced
this pull request
Jan 14, 2021
* run autorest against new swagger, fix what breaks * test for html message * record new live tests * update README.md
danielgerlag
added a commit
that referenced
this pull request
Jan 29, 2021
* run autorest against new swagger, fix what breaks * test for html message * record new live tests * update README.md
danielgerlag
added a commit
that referenced
this pull request
Feb 4, 2021
* run autorest against new swagger, fix what breaks * test for html message * record new live tests * update README.md
juancamilor
pushed a commit
that referenced
this pull request
Feb 6, 2021
* ACS Chat: Changes for API version: 2020-11-01-preview3 (#17790) * regen autorest rename ChatThreadMember -> ChatParticipant rename ReadReciept -> ChatMessageReadReciept * Update response code for non-existing thread * fix style errors * live test session records * SendMessage returns MessageId instead of SendChatMessageResult * update README.md with new namings * run embedme on README.md * pr feedback - system message names * pr feedback * ACS Chat - Preview 3 - Add single thread participant convenience method (#17800) * add methods for adding a single participant to a chat thread * add tests for new methods * add recorded test sessions for new tests * refactor `updateChatThread` to `updateTopic` (#17791) * ACS Chat: Preview 3 refactor (#17910) * use local swagger.json * fix AutoRest directive to match new swagger * run AutoRest, update wrapper code accordingly * more refactoring against new swagger generated code * correct actual vs. expected in assertions * update test session recordings * sync README.md * expose sync overloads * add tests * update README.md * pr feedback * ACS chat: Api changes jan 2021 (#18574) * run autorest against new swagger, fix what breaks * test for html message * record new live tests * update README.md * post-rebase fixes * update tests after rebase * adjust coverage on rebase * ACS Chat: Swagger update (#18744) * refresh swagger.json * run autorest * embedme * remove ChatMessagePriority.java * hide implementation * record test sessions * ACS-Chat: Default repeatability ID (#18833) * default repeatabilityRequestId * test sessions * post rebase fixes * test sessions * test sessions * run embedme * fix line number issue with readme snippets * style error
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Apr 20, 2022
Azure Networking 2021-08-01 release of monthly branch (Azure#18440) * Adds base for updating Microsoft.Network from version stable/2021-05-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * Add AppGw swagger changes for L4 proxy (Azure#17561) * Add AppGw swagger changes for L4 proxy * Fix Lint Errors * fix prettier checks * HubRoutingPreference in VirtualHub (Azure#17609) * commit1 * commit2 Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * MultipleApipa feature VpnSiteLinkConnection and VirtualNetworkGatewayConnection (Azure#17672) * VngConnection * VpnSiteLinkConnection * fixes * fixes * fix2 * fixes Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Virtual Wan P2S MultiPool feature swagger changes (Azure#17620) * Virtual Wan P2S MultiPool feature swagger changes * Fix Swagger LintDiff errors * Fix LintDiff errors * Fix errors * Fix spec * Fix spec * Fix spec * Fix LintDiff errors * Fix LintDiff errors * Fix SDK azure-sdk-for-net generation error * Remove suppression * Fix errors * Fix Lintdiff error * Fix PrettierCheck * changes (Azure#18002) * Revert "changes (Azure#18002)" (Azure#18014) This reverts commit 320ed6a6fc5a68e8af43da303f8e1caaacf24708. * Add nic auxiliary mode (Azure#17577) * Add nic auxiliary mode * fix spacing * Fixing prettier check * Restoring package-lock file * Restoring package json Co-authored-by: Prachi Bhavsar <prbhavsar@microsoft.com> * Connection Draining add new properties (Azure#18052) * merge * fix * fix * Adding express route port authorization apis (Azure#17582) * adding apis and updating resource to support ports auth * moving change to 2021-08-01 * minor: removing change from 2020-07-01 * lintdiff : adding type object * minor: fixing prettier * adding authorizations to ports property * fixing circuitResourceUri property name * fixing model validation * changing circuit resource uri type to string * removing authorizations child reosurce from parent property * Fix Azure Firewall Policy regressions. Back fix validation issues (Azure#18233) * Fix regressions in Firewall Policy Swagger / give firewallPolicy.json some love * Additional lint violations * remove breaking changes for next time. TO DO * Revert "remove breaking changes for next time. TO DO" This reverts commit 8f44a174c73c02d18d829f6dfb1d990488770b23. * Reintroduce api-version for idps signature based routes. Create better names for enums to be generated in SDKs * standardize enum names with FirewallPolicy prefix * Azure Firewall Support of Private IP Ranges in IDPS (Azure#18320) * Azure Firewall Support of Private IP Ranges in IDPS * make sure all arrays have x-ms-identifiers * FirewallPolicy not Firewall policy fix spellcheck validation * Ability to update tags on firewall policies (Azure#18322) * Support updating of Azure Firewall Policy Tags. Includes HTTP Patch example * Use common-types ErrorDetail * Ability to update tags for Firewall Policies * spell check fix for firewallpolicy * Use future release api-version for example * Added flush conn to nsg (Azure#18393) * Added flush conn to nsg * Updated flushConn to correct location * Updated description * Modified T/F to Enabled/Disabled * Refactoring so that null value appears first * Reverted FlushConnection to boolean value instead of string * Revert "Added flush conn to nsg (Azure#18393)" (Azure#18576) This reverts commit 6541d305880d1cf580496adc01f55197a01e992c. * Fixing typo in response of idps private ip range feature (Azure#18574) * Use common-type api version (Azure#18729) Co-authored-by: Ben Eshed <bewaters@microsoft.com> * fix (Azure#18417) Co-authored-by: Tianen <347142915@qq.com> Co-authored-by: gk-ms <97893166+gk-ms@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Nilambari <nilamd@microsoft.com> Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com> Co-authored-by: pracsb <78512712+pr-work@users.noreply.github.com> Co-authored-by: Prachi Bhavsar <prbhavsar@microsoft.com> Co-authored-by: Matthew Yang <79727592+matyang22@users.noreply.github.com> Co-authored-by: utbarn-ms <66377251+utbarn-ms@users.noreply.github.com> Co-authored-by: Ben Eshed <thebenwaters@users.noreply.github.com> Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com> Co-authored-by: bewaterspassover <103988461+bewaterspassover@users.noreply.github.com> Co-authored-by: Ben Eshed <bewaters@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.