Support java modules for azure-spring-data-cosmos #14636
Conversation
saragluna
requested review from
alzimmermsft,
chenrujun,
danieljurek,
David-Noble-at-work,
jialindai,
JimSuplizio,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
mitchdenny,
moderakh,
samvaity,
simplynaveen20,
xinlian12,
yiliuTo and
zhoufenqin
as code owners
There was a problem hiding this comment.
Overall looks good to me. @srnagar - can you please verify this PR to make sure spring-data-cosmos-core is now complying with java 11 support?
| @@ -32,7 +32,7 @@ | |||
| exports com.azure.cosmos.util; | |||
|
|
|||
| // exporting some packages specifically for Jackson | |||
| opens com.azure.cosmos to com.fasterxml.jackson.databind; | |||
| opens com.azure.cosmos to com.fasterxml.jackson.databind, org.apache.commons.lang3; | |||
There was a problem hiding this comment.
We use reflection to retrieve userAgentSuffix field of cosmosClient: https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/cosmos/azure-spring-data-cosmos-core/src/main/java/com/azure/spring/data/cosmos/CosmosFactory.java#L87
There was a problem hiding this comment.
But that code piece is in spring-data-cosmos-core and here we are exporting apache commons lang 3 to azure-cosmos module, which doesn't use this dependency at all. Let's discuss this offline today.
There was a problem hiding this comment.
Yes, cosmos package should have no dependency or reference to org.apache.commons.lang3.
saragluna
requested review from
anuchandy,
bsiegel,
conniey,
hemanttanwar,
jianghaolu,
JonathanGiles,
joshfree and
srnagar
as code owners
sdk/cosmos/azure-spring-data-cosmos-core/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
LGTM, thanks @saragluna
@srnagar - can you please confirm these changes ?
Support Java modules for azure-spring-data-cosmos: #14378.
module-info.java added to the core project azure-spring-data-cosmos-core and the name for this core module is
com.azure.spring.data.cosmos.For the two pom file projects,
azure-spring-data-2-3-cosmosandazure-spring-data-2-2-cosmos, anAutomatic-Module-Nameentry added to themaven-jar-pluginso these two could be automatic modules when used in Java modules. If we don't add such entry, the automatic module names for these two are likeazure.spring.data.2.2.cosmoswhich is not valid and will cause runtime exceptions.We could choose to add
module-info.javafor theazure-spring-data-2-3-cosmos, but themaven-compiler-pluginwould fail when it compiles this artifact against Java8, complaining it doesn't support Java module even though we exclude themodule-info.javain such execution.I also created a WIP PR to the sample project showing the changes users need to include when creating a modular application. Azure-Samples/azure-spring-data-cosmos-java-sql-api-getting-started#2