This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
Demo how to use Java modules in azure-spring-data-cosmos application #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushagraThapar
suggested changes
Aug 31, 2020
There was a problem hiding this comment.
@saragluna - thank you so much for working on this sample.
I am thinking instead of merging this PR as it is, should we create another module here which shows java 11 support instead of updating the existing azure-spring-data-2-2-cosmos sample module?
Let me know your thoughts.
|
@kushagraThapar yes, I could create a separate module to show how to use Java Modules with azure spring data cosmos. |
kushagraThapar
approved these changes
Sep 2, 2020
kushagraThapar
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Thank you @saragluna for implementing Java 11 samples. LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a demo PR showing changes users need to make when they want to build a modular application with azure-spring-data-cosmos.
version 3.0.0-beta.2 for azure-spring-data-2-2-cosmos and azure-spring-data-2-3-cosmos needed to be built locally since it's not released yet.