Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the previous change: remove the identity properties #4220

Merged
merged 3 commits into from
Oct 12, 2018

Conversation

xiadu94
Copy link
Contributor

@xiadu94 xiadu94 commented Oct 11, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Oct 11, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3467

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@djyou
Copy link
Member

djyou commented Oct 11, 2018

@jianghaolu This is to revert a previous PR that was merged before the server side is ready. #4074
/cc @sajayantony

Copy link
Member

@djyou djyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a meaningful title

@xiadu94 xiadu94 changed the title Xiadu/msi Revert the previous change: remove the identity properties Oct 11, 2018
@sajayantony
Copy link

LGTM

@AutorestCI
Copy link

AutorestCI commented Oct 12, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3864

@AutorestCI
Copy link

AutorestCI commented Oct 12, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3003

@sergey-shandar sergey-shandar added potential-sdk-breaking-change WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 12, 2018
@sergey-shandar
Copy link
Contributor

sergey-shandar commented Oct 12, 2018

@xiadu94 @djyou what's the reason to remove the properties? This's stable API and some SDKs could be already published as stable with the properties.

@djyou
Copy link
Member

djyou commented Oct 12, 2018

@sergey-shandar There is no breaking change yet.

This is to revert a previous PR that was merged before the server side is ready. #4074

@sergey-shandar
Copy link
Contributor

@djyou as I mentioned before, removing properties from master branch in a stable API is potential breaking changes. But if the server side is not ready, I will merge the PR.

@AutorestCI
Copy link

AutorestCI commented Oct 12, 2018

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#177

@sergey-shandar sergey-shandar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants