[ACR] Auto Build Swagger: Added identity to registry properties #4074

xiadu94 · 2018-10-04T18:04:04Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-10-04T18:05:03Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3467

azuresdkci · 2018-10-04T18:05:12Z

Can one of the admins verify this patch?

AutorestCI · 2018-10-04T18:05:52Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

djyou · 2018-10-04T18:09:29Z

...gistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json

@@ -1387,6 +1387,10 @@
          "$ref": "#/definitions/Sku",
          "description": "The SKU of the container registry."
        },
+        "identity": {
+          "$ref": "#/definitions/RegistryIdentity",
+          "description": "The Identity of the container registry."


The identity?

djyou · 2018-10-04T18:09:37Z

...gistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json

+          "type": "string"
+        },
+        "principalId": {
+          "description": "The principal id of registry identity.",


djyou · 2018-10-04T18:09:43Z

...gistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json

+          "type": "string"
+        },
+        "tenantId": {
+          "description": "The tenant id associated with the registry.",


AutorestCI · 2018-10-04T18:10:38Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1574

AutorestCI · 2018-10-04T18:11:06Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3780

AutorestCI · 2018-10-04T18:12:34Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2018-10-04T18:14:39Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2460

jianghaolu · 2018-10-05T23:47:14Z

SDK team signoff. Please approve if PR looks good to you @djyou - thanks!

djyou

LGTM

jhendrixMSFT · 2018-10-10T16:35:40Z

@AutorestCI regenerate azure-sdk-for-go

jhendrixMSFT · 2018-10-11T17:11:01Z

@AutorestCI regenerate azure-sdk-for-go

AutorestCI · 2018-10-11T22:49:51Z

Encountered a Subprocess error

Command: dep ensure
Finished with return code 1
and output:

grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export github.com/marstr/randname: failed to fetch source for https://github.com/marstr/randname: unable to get repository: Cloning into '/tmp/tmpe92a4r53/pkg/dep/sources/https---github.com-marstr-randname'...
POST git-upload-pack (215 bytes)
error: RPC failed; curl 28 SSL connection timeout
fatal: The remote end hung up unexpectedly
: command failed: [git clone --recursive -v --progress https://github.com/marstr/randname /tmp/tmpe92a4r53/pkg/dep/sources/https---github.com-marstr-randname]: exit status 128

jhendrixMSFT · 2018-10-15T16:17:46Z

@AutorestCI regenerate azure-sdk-for-go

Added identity to registry properties

a9ff5f3

azuresdkci assigned jianghaolu Oct 4, 2018

azuresdkci requested a review from jianghaolu October 4, 2018 18:04

AutorestCI mentioned this pull request Oct 4, 2018

[AutoPR containerregistry/resource-manager] [ACR] Auto Build Swagger: Added identity to registry properties Azure/azure-sdk-for-python#3491

Merged

djyou reviewed Oct 4, 2018

View reviewed changes

AutorestCI mentioned this pull request Oct 4, 2018

[AutoPR containerregistry/resource-manager] [ACR] Auto Build Swagger: Added identity to registry properties Azure/azure-sdk-for-ruby#1722

Closed

AutorestCI mentioned this pull request Oct 4, 2018

[AutoPR containerregistry/resource-manager] [ACR] Auto Build Swagger: Added identity to registry properties Azure/azure-sdk-for-node#3763

Merged

AutorestCI mentioned this pull request Oct 4, 2018

[AutoPR containerregistry/resource-manager] [ACR] Auto Build Swagger: Added identity to registry properties Azure/azure-sdk-for-go#2906

Closed

AutorestCI mentioned this pull request Oct 4, 2018

[AutoPR containerregistry/resource-manager] [ACR] Auto Build Swagger: Added identity to registry properties Azure/azure-sdk-for-java#2463

Merged

CR comments

454d0e1

jianghaolu approved these changes Oct 5, 2018

View reviewed changes

CR comments

185e2e9

djyou approved these changes Oct 6, 2018

View reviewed changes

jianghaolu merged commit fa75fec into Azure:master Oct 8, 2018

djyou mentioned this pull request Oct 11, 2018

Revert the previous change: remove the identity properties #4220

Merged

10 tasks

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

sync common types (#4074)

a9c0e39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ACR] Auto Build Swagger: Added identity to registry properties #4074

[ACR] Auto Build Swagger: Added identity to registry properties #4074

xiadu94 commented Oct 4, 2018 •

edited

Loading

AutorestCI commented Oct 4, 2018 •

edited

Loading

azuresdkci commented Oct 4, 2018

AutorestCI commented Oct 4, 2018 •

edited

Loading

djyou Oct 4, 2018

djyou Oct 4, 2018

djyou Oct 4, 2018

AutorestCI commented Oct 4, 2018 •

edited

Loading

AutorestCI commented Oct 4, 2018 •

edited

Loading

AutorestCI commented Oct 4, 2018 •

edited

Loading

AutorestCI commented Oct 4, 2018 •

edited

Loading

jianghaolu commented Oct 5, 2018

djyou left a comment

jhendrixMSFT commented Oct 10, 2018

jhendrixMSFT commented Oct 11, 2018

AutorestCI commented Oct 11, 2018

jhendrixMSFT commented Oct 15, 2018

[ACR] Auto Build Swagger: Added identity to registry properties #4074

[ACR] Auto Build Swagger: Added identity to registry properties #4074

Conversation

xiadu94 commented Oct 4, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented Oct 4, 2018 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Oct 4, 2018

AutorestCI commented Oct 4, 2018 • edited Loading

Automation for azure-sdk-for-js

djyou Oct 4, 2018

Choose a reason for hiding this comment

djyou Oct 4, 2018

Choose a reason for hiding this comment

djyou Oct 4, 2018

Choose a reason for hiding this comment

AutorestCI commented Oct 4, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Oct 4, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Oct 4, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Oct 4, 2018 • edited Loading

Automation for azure-sdk-for-java

jianghaolu commented Oct 5, 2018

djyou left a comment

Choose a reason for hiding this comment

jhendrixMSFT commented Oct 10, 2018

jhendrixMSFT commented Oct 11, 2018

AutorestCI commented Oct 11, 2018

jhendrixMSFT commented Oct 15, 2018

xiadu94 commented Oct 4, 2018 •

edited

Loading

AutorestCI commented Oct 4, 2018 •

edited

Loading

AutorestCI commented Oct 4, 2018 •

edited

Loading

AutorestCI commented Oct 4, 2018 •

edited

Loading

AutorestCI commented Oct 4, 2018 •

edited

Loading

AutorestCI commented Oct 4, 2018 •

edited

Loading

AutorestCI commented Oct 4, 2018 •

edited

Loading