Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACR] Auto Build Swagger: Add registry identity properties to response #4036

Closed
wants to merge 1 commit into from
Closed

[ACR] Auto Build Swagger: Add registry identity properties to response #4036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ...try/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1515,6 +1515,24 @@
}
}
},
"RegistryIdentity": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiadu94

  • This new type is not referenced anywhere else in the model.. what is its purpose?
    • If this is indeed an object created at the server side and returned to the user, you should mark the properties as readonly. example here
  • Is this meant to be returned from the server side or is it a config object that the user will create?

"description": "Identity of the container registry.",
"type": "object",
"properties": {
"identityType": {
"description": "The type of identity used for registry.",
"type": "string"
},
"identityPrincipalId": {
"description": "The principal ID of registry identity.",
"type": "string"
},
"tenantId": {
"description": "The tenant ID of registry.",
"type": "string"
}
}
},
"RegistryUpdateParameters": {
"description": "The parameters for updating a container registry.",
"type": "object",
Expand Down