-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACR] Auto Build Swagger: Add registry identity properties to response #4036
Conversation
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-nodeA PR has been created for you: |
Automation for azure-sdk-for-rubyA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Can one of the admins verify this patch? |
@sergey-shandar I and @praries880 can take over this one |
@praries880 take a look and let me know if you have any queries |
@@ -1515,6 +1515,24 @@ | |||
} | |||
} | |||
}, | |||
"RegistryIdentity": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This new type is not referenced anywhere else in the model.. what is its purpose?
- If this is indeed an object created at the server side and returned to the user, you should mark the properties as readonly. example here
- Is this meant to be returned from the server side or is it a config object that the user will create?
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger