Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RunCommands 2018-06-01 #3422

Merged
merged 2 commits into from
Jul 19, 2018
Merged

RunCommands 2018-06-01 #3422

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d08b9c
RunCommands 2018-06-01
lmazuel Jul 16, 2018
9c64257
Take examples from 2018-04-01
lmazuel Jul 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...source-manager/Microsoft.Compute/stable/2018-06-01/examples/VirtualMachineRunCommand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"resourceGroupName": "crptestar98131",
"vmName": "vm3036",
"$top": "1",
"api-version": "2017-12-01",
"api-version": "2018-06-01",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intended at that time, or it's just found as typo errors till now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was copied from 2017-12-01 to 2018-06-01 folder with no reasons, since the Swagger which was mentioning it didn't exist. This is correct then the correct content for the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it may be intended by the service API team. What if the RunCommand APIs (for some reason) don't work with this new API version? Swagger spec correctness is important, but we can't also expose something here that the service API is not ready to expose.

@hyonholee Can you help involve Atanas to help confirm? Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see prev version example when the API has changes:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/Microsoft.Compute/stable/2018-04-01/examples/VirtualMachineRunCommand.json

The output: [ ] become wrapped in json object
output: {value: [ ] }

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

"monitor": "true",
"parameters": {
"commandId": "RunPowerShellScript"
Expand Down
2 changes: 1 addition & 1 deletion ...rce-manager/Microsoft.Compute/stable/2018-06-01/examples/VirtualMachineRunCommandGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"subscriptionId": "24fb23e3-6ba3-41f0-9b6e-e41131d5d61e",
"location": "SoutheastAsia",
"commandId": "RunPowerShellScript",
"api-version": "2017-12-01"
"api-version": "2018-06-01"
},
"responses": {
"200": {
Expand Down
2 changes: 1 addition & 1 deletion ...ce-manager/Microsoft.Compute/stable/2018-06-01/examples/VirtualMachineRunCommandList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"parameters": {
"subscriptionId": "subid",
"location": "SoutheastAsia",
"api-version": "2017-12-01"
"api-version": "2018-06-01"
},
"responses": {
"200": {
Expand Down
Loading