RunCommands 2018-06-01 #3422
RunCommands 2018-06-01 #3422
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
|
@huangpf for review |
| @@ -4,7 +4,7 @@ | |||
| "resourceGroupName": "crptestar98131", | |||
| "vmName": "vm3036", | |||
| "$top": "1", | |||
| "api-version": "2017-12-01", | |||
| "api-version": "2018-06-01", | |||
There was a problem hiding this comment.
Was this intended at that time, or it's just found as typo errors till now?
There was a problem hiding this comment.
This file was copied from 2017-12-01 to 2018-06-01 folder with no reasons, since the Swagger which was mentioning it didn't exist. This is correct then the correct content for the file.
There was a problem hiding this comment.
But it may be intended by the service API team. What if the RunCommand APIs (for some reason) don't work with this new API version? Swagger spec correctness is important, but we can't also expose something here that the service API is not ready to expose.
@hyonholee Can you help involve Atanas to help confirm? Thanks.
There was a problem hiding this comment.
Please see prev version example when the API has changes:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/Microsoft.Compute/stable/2018-04-01/examples/VirtualMachineRunCommand.json
The output: [ ] become wrapped in json object
output: {value: [ ] }
| @@ -184,6 +184,7 @@ These settings apply only when `--tag=package-compute-only-2018-06` is specified | |||
| ``` yaml $(tag) == 'package-compute-only-2018-06' | |||
| input-file: | |||
| - Microsoft.Compute/stable/2018-06-01/compute.json | |||
| - Microsoft.Compute/stable/2018-06-01/runCommands.json | |||
There was a problem hiding this comment.
Please attach C# SDK test validation proof, because this is what we all do.
There was a problem hiding this comment.
I don't understand? This is a Swagger question, I don't do C# and I'm not in the C# team, I'm in the Swagger team. This PR is just a friendly reminder that this is needed in order to ship CLI with 2018-06-01 support.
There was a problem hiding this comment.
I can understand your workflow is to patch the specification, and SDK release is not your concern. But if you can waive the SDK proof part, can we also get a waiver onwards? @hyonholee
There was a problem hiding this comment.
Let's continue this by email, thank you
| "info": { | ||
| "title": "RunCommandsClient", | ||
| "description": "The Run Commands Client.", | ||
| "version": "2018-06-01" |
There was a problem hiding this comment.
Confirm that this file should be the same as
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/Microsoft.Compute/stable/2018-04-01/runCommands.json
and only the version number should be updated.
|
@lmazuel once this gets merged, please release python sdk of azure-mgmt-compute including everything |
* adding inventory item props * update
For Azure Profile to work properly, we need either:
However, "runCommands" plugs into the operation group
VirtualMachinesthe operationRunCommand. Being that latest VirtualMachines is 2018-06-01 and latestrunCommandsis 2018-04-01, this breaks the contract and creates Readme that cannot be used for Azure Profile.Discussed with @hyonholee the first time this occured that in theory when a new Compute is out, RunCommands is out at the same time and this just requires copying the file.
Note that the examples were copied without the Swagger, with the wrong api-version content.