Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing schema from string to file #3420

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Changing schema from string to file #3420

merged 1 commit into from
Jul 18, 2018

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Jul 16, 2018

Forgot to add this bit in the #3363. Reverting the change of body parameter schema to be of type:object/format file, as it was earlier.

@hovsepm Could you please take a look.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jul 16, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 16, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#1959

@AutorestCI
Copy link

AutorestCI commented Jul 16, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1476

@AutorestCI
Copy link

AutorestCI commented Jul 16, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2653

@AutorestCI
Copy link

AutorestCI commented Jul 16, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@annatisch
Copy link
Member

Thanks @vrdmr!
It seems that the model validation errors were already present in the previous PR - just for context, could you please let me know why they weren't resolved (e.g. are they errors in the validator?)

Additionally I see in the previous PR that @hovsepm already let you know about the breaking changes to the SDKs - do you know if any packages were published between the previous PR and this one?

@vrdmr
Copy link
Member Author

vrdmr commented Jul 17, 2018

Hi @annatisch, Validation errors were not removed as I don't know of a clear way to describe a body as file and not a string - especially for this issue: Expected type file but found type string.

And to answer your second question - No packages were published. This issue was caught during the tests for releasing a package.

@annatisch annatisch merged commit 40e3e99 into Azure:master Jul 18, 2018
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@vrdmr
Copy link
Member Author

vrdmr commented Jul 18, 2018

@jhendrixMSFT For Go, do you need something to be added to our readme.md for solving the Nothing to generate for azure-sdk-for-go issue?

@jhendrixMSFT
Copy link
Member

@vrdmr No it looks like this package is already current in the Go SDK which is why there was nothing to generate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants