Adding new github template files for PR and contributing guidelines #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hglkrijger
approved these changes
Jul 25, 2018
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| - [ ] New Unit tests were added for the changes made and Travis.CI is passing. | ||
|
|
||
| ### Quality of Code and Contribution Guidelines | ||
| - [ ] I have read the [contribution guidelines](https://github.com/Azure/Guest-Configuration-Extension/blob/master/.github/CONTRIBUTING.md). |
There was a problem hiding this comment.
Let's point this to our own guidelines
vrdmr
force-pushed
the
vameru-github-templates
branch
from
c4ea56d
to
43905ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hglkrijger @boumenot @narrieta Adding github templates and Contributing Guidelines. The template file populates a template whenever there is a new PR. We can generate a similar issues template as well, which can help the users logging in the bug. Example template use: Azure/azure-rest-api-specs#3420 (comment). Also created a simple Contributing.md file, as a way for people to know about how we can accept the PRs.
The contents of the template are in
.mdformat and can be changed while generating the PR. Please let me know if this useful or needs change.