Modify Gallery Swagger According To Feedback #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vanbasten2323/azure-rest-api-specs into dev/xiowei/addSwaggerForGallery
…the local validation.
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
This was referenced Jun 4, 2018
|
@AutorestCI regenerate azure-sdk-for-python |
yugangw-msft
reviewed
Jun 5, 2018
| "default": { | ||
| "description": "Error response describing why the operation failed.", | ||
| "schema": { | ||
| "$ref": "#/definitions/CloudError" | ||
| "$ref": "#/definitions/ApiError" |
sarangan12
approved these changes
Jun 11, 2018
|
@vanbasten23 Are you part of Compute service team? |
|
@sarangan12 Yes, I am part of Compute service team. |
hyonholee
reviewed
Jun 13, 2018
| @@ -34,7 +34,7 @@ These are the global settings for the Compute API. | |||
| title: ComputeManagementClient | |||
| description: Compute Client | |||
| openapi-type: arm | |||
| tag: package-2018-04-01 | |||
| tag: package-2018-06-01 | |||
There was a problem hiding this comment.
If you update this default tag to include gallery, it is very difficult to change later. If gallery is still preview, do not update default tag.
|
@hyonholee Please resolve the conflicts |
Automation for azure-sdk-for-javaEncountered an unknown error: (azure-sdk-for-java)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 32, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 167, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 182, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 237, in generate_sdk_from_git_object
raise ValueError("Unable to locate configuration in {}".format(branch_list))
ValueError: Unable to locate configuration in ['restapi_auto_compute/resource-manager', 'restapi_auto_3175', 'master'] |
|
LGTM, Thanks. |
|
@AutorestCI regenerate azure-sdk-for-python |
weidongxu-microsoft
pushed a commit
to weidongxu-microsoft/azure-rest-api-specs
that referenced
this pull request
Jan 31, 2024
added powershell and arm schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger