Skip to content

Commit

Permalink
Modify Gallery Swagger According To Feedback (#3175)
Browse files Browse the repository at this point in the history
* Added the swagger file for the new service Gallery.

* Fixed minor issues. Added an example.

* Added the example for creating a gallery.

* Gallery Python conf

* Make the tag name plural.

* Fixed description for 202 response.

* Changed the operationId to conform to naming convention.

* Fixed some typos.

* Add default error response. Make provisioningInfo a enum type.

* Fixed comments according to CR.

* Updated the readme.md

* Updated the example.

* do some experiments.

* Cleaned up unused files.

* added empty example file.

* Added example for GetGallery api.

* Added example for DeleteGallery api. Passed the local validation.

* Added example for PutGalleryImage api. Passed the local validation.

* Added example for GetGalleryImage api. Passed the local validation.

* Added example for DeleteGalleryImage api. Passed the local validation.

* Added example for PutGalleryImageVersion api. Passed the local validation.

* Added example for GetGalleryImageVersion api. Passed the local validation.

* Added example for DeleteGalleryImageVersion api. Passed the local validation.

* Added example for ListGalleriesInAResourceGroup api. Passed the local validation.

* Added example for ListGalleriesInASubscription api. Passed the local validation.

* Added example for ListGalleryImagesInGallery api. Passed the local validation.

* Added example for ListGalleryImageVersionsInGalleryImage api. Passed the local validation.

* Fixed typos in the example provided.

* Fixed typos in the example provided.

* Added the supression for gallery, gallery image, and gallery image version.

* Correct the suppression.

* modified the swagger.

* removed the python tag in readme

* Fixed some minor issues.

* Added the description to gallery unique name.

* Fixed the readme.md

* Improved gallery image version description.

* Uses CloudError to reference ApiError as Hyonho suggested.

* Revert the change of the default tag in Readme.md
  • Loading branch information
vanbasten23 authored and sarangan12 committed Jun 19, 2018
1 parent f4f3345 commit c242706
Show file tree
Hide file tree
Showing 16 changed files with 148 additions and 117 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,19 @@
"location": "West US",
"name": "myGalleryName"
}
},
"202": {
"body": {
"properties": {
"description": "This is the gallery description.",
"identifier": {
"uniqueName": "{subscription-id}-MYGALLERYNAME"
},
"provisioningState": "Updating"
},
"location": "West US",
"name": "myGalleryName"
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,22 @@
"location": "West US",
"name": "myGalleryImageName"
}
},
"202": {
"body": {
"properties": {
"osType": "Windows",
"osState": "Generalized",
"identifier": {
"publisher": "myPublisherName",
"offer": "myOfferName",
"sku": "mySkuName"
},
"provisioningState": "Updating"
},
"location": "West US",
"name": "myGalleryImageName"
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
"id": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/images/{imageName}"
}
},
"publishedDate": "2018-01-01"
"scaleTier": "S30",
"publishedDate": "2018-01-01T00:00:00Z"
},
"provisioningState": "Updating"
},
Expand All @@ -49,13 +50,33 @@
"id": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/images/{imageName}"
}
},
"publishedDate": "2018-01-01"
"scaleTier": "S30",
"publishedDate": "2018-01-01T00:00:00Z"
},
"provisioningState": "Creating"
},
"location": "West US",
"name": "1.0.0"
}
},
"202": {
"body": {
"properties": {
"publishingProfile": {
"regions": ["West US", "East US"],
"source": {
"managedImage": {
"id": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/images/{imageName}"
}
},
"scaleTier": "S30",
"publishedDate": "2018-01-01T00:00:00Z"
},
"provisioningState": "Updating"
},
"location": "West US",
"name": "1.0.0"
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,18 @@
"id": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/images/{imageName}"
}
},
"publishedDate": "2018-01-01"
"scaleTier": "S30",
"publishedDate": "2018-01-01T00:00:00Z"
},
"storageProfile": {
"osDiskImage": {
"sizedInGB": 10,
"sizeInGB": 10,
"hostCaching": "ReadOnly"
},
"dataDiskImages": [
{
"lun": 1,
"sizedInGB": 10,
"sizeInGB": 10,
"hostCaching": "None"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,18 @@
"id": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/images/{imageName}"
}
},
"publishedDate": "2018-01-01"
"scaleTier": "S30",
"publishedDate": "2018-01-01T00:00:00Z"
},
"storageProfile": {
"osDiskImage": {
"sizedInGB": 10,
"sizeInGB": 10,
"hostCaching": "ReadOnly"
},
"dataDiskImages": [
{
"lun": 1,
"sizedInGB": 10,
"sizeInGB": 10,
"hostCaching": "None"
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,18 @@
"id": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/images/{imageName}"
}
},
"publishedDate": "2018-01-01"
"scaleTier": "S30",
"publishedDate": "2018-01-01T00:00:00Z"
},
"storageProfile": {
"osDiskImage": {
"sizedInGB": 10,
"sizeInGB": 10,
"hostCaching": "ReadOnly"
},
"dataDiskImages": [
{
"lun": 1,
"sizedInGB": 10,
"sizeInGB": 10,
"hostCaching": "None"
}
]
Expand Down
Loading

0 comments on commit c242706

Please sign in to comment.