Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2018-05-01 version. Common fixes #3025

Merged

Conversation

EvgenyAgafonchikov
Copy link
Contributor

@EvgenyAgafonchikov EvgenyAgafonchikov commented May 7, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️0 new Warnings.(95 total)
0 new Errors.(78 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️0 new Warnings.(108 total)
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@lmazuel lmazuel merged commit b3f5a7a into Azure:Network-2018-05-01 May 7, 2018
@sarangan12 sarangan12 removed the review label May 7, 2018
@AutorestCI
Copy link

AutorestCI commented May 8, 2018

Automation for azure-libraries-for-java

Encountered a Subprocess error: (azure-libraries-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp8o3sm582/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmp8o3sm582/sdk', '--fluent', '--java', '--multiapi', '--verbose']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4275/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4275)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (~2.1.32->2.1.67)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Shutting Down

dsgouda pushed a commit that referenced this pull request May 17, 2018
* Added 2018-05-01 version. Common fixes (#3025)

* Created May folder. Updated version for exampls, commands

* Updated package to May version

* Returned NW examples

* Fixed API version; Fixed NetworkWatcher examples

* Fixed VPN Gateway/Connection examples

* Add changes from PR#2975
https://github.com/Azure/azure-rest-api-specs/pull/2975/files

* Adding optional traffic analytics config fields to network watcher config object for enhancing the Network Watcher cmdlets (#3023)

* Adding optional traffic analytics parameters with existing network watched flowlog configuration

* Updating the version

* Updating latest versoin in readme.md

* #AppGw Fundamentals Clean Up (#3046)

* Network 2018 05 01 (#3068)

* Adding optional traffic analytics parameters with existing network watched flowlog configuration

* Updating the version

* Updating latest versoin in readme.md

* Adding optional traffic analytics parameters with flowlog parameters

* Reverting old chnages

* Expose new SKUs for VMSS VPN and ER gateways (#3069)

Expose new SKUs for VMSS VPN and ER gateways

* Initial network error fixes and suppressions (#3051)

* Initial network error fixes and suppressions

* reworked exception to specified code blocks only

* Added express route fixes
@EvgenyAgafonchikov EvgenyAgafonchikov deleted the Network-2018-05-01 branch May 15, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants