Adding optional traffic analytics config fields to network watcher config object for enhancing the Network Watcher cmdlets #3023

sayghosh · 2018-05-06T15:38:03Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…tched flowlog configuration

azuresdkciprbot · 2018-05-06T15:44:39Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(95 total)

❌0 new Errors.(82 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-06T15:44:39Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(108 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-06T17:55:17Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

110 new Warnings.(110 total)

Code	Id	Source	Message
ListInOperationName	R1003	Link	Since operation 'ApplicationGateways_BackendHealth' response has model definition 'array', it should be of the form "_list". Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: '{devicepath}' in:'ExpressRouteCircuits_ListArpTable'. Consider updating the operationId
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: '{devicepath}' in:'ExpressRouteCircuits_ListRoutesTable'. Consider updating the operationId
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: '{devicepath}' in:'ExpressRouteCircuits_ListRoutesTableSummary'. Consider updating the operationId
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: '{devicepath}' in:'ExpressRouteCrossConnections_ListArpTable'. Consider updating the operationId
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: '{devicepath}' in:'ExpressRouteCrossConnections_ListRoutesTableSummary'. Consider updating the operationId
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: '{devicepath}' in:'ExpressRouteCrossConnections_ListRoutesTable'. Consider updating the operationId
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: 'ipflowverify' in:'NetworkWatchers_VerifyIPFlow'. Consider updating the operationId
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: 'securitygroupview' in:'NetworkWatchers_GetVMSecurityRules'. Consider updating the operationId
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: 'querystatus' in:'PacketCaptures_GetStatus'. Consider updating the operationId
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: 'querytroubleshootresult' in:'NetworkWatchers_GetTroubleshootingResult'. Consider updating the operationId
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: 'configureflowlog' in:'NetworkWatchers_SetFlowLogConfiguration'. Consider updating the operationId
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: 'queryflowlogstatus' in:'NetworkWatchers_GetFlowLogStatus'. Consider updating the operationId
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: 'connectivitycheck' in:'NetworkWatchers_CheckConnectivity'. Consider updating the operationId
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: 'availableproviderslist' in:'NetworkWatchers_ListAvailableProviders'. Consider updating the operationId
DescriptionAndTitleMissing	R4000	Link	'RedirectTypeEnum' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'AuthorizationPropertiesFormat' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'ExpressRouteCircuitPeeringPropertiesFormat' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'ExpressRouteCircuitConnectionPropertiesFormat' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'ExpressRouteCircuitReference' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'ExpressRouteCrossConnectionPeeringProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'ErrorDetails' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'Error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'backendAddressPools' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'protocol' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'protocol' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'protocol' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'code' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'target' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'message' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'code' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'message' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'target' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'details' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'innerError' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'resources' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'securityRuleAssociations' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'networkInterfaceAssociation' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'subnetAssociation' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'storageLocation' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'filters' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'etag' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'retentionPolicy' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'flowAnalyticsConfiguration' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'networkWatcherFlowAnalyticsConfiguration' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'destination' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'protocolConfiguration' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'HTTPConfiguration' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'providerLocation' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'providerLocation' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'destination' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'etag' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing	R4000	Link	'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
GetInOperationName	R1005	Link	'GET' operation 'CheckDnsNameAvailability' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ListInOperationName	R1003	Link	Since operation 'NetworkInterfaces_GetEffectiveRouteTable' response has model definition 'array', it should be of the form "_list". Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ListInOperationName	R1003	Link	Since operation 'NetworkWatchers_GetVMSecurityRules' response has model definition 'array', it should be of the form "_list". Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ListInOperationName	R1003	Link	Since operation 'ConnectionMonitors_Query' response has model definition 'array', it should be of the form "_list". Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
PutRequestResponseScheme	R2017	Link	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'ConnectionMonitors_CreateOrUpdate' Request Model: 'ConnectionMonitor' Response Model: 'ConnectionMonitorResult'
ListInOperationName	R1003	Link	Since operation 'VirtualNetworks_CheckIPAddressAvailability' response has model definition 'array', it should be of the form "_list". Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
GetInOperationName	R1005	Link	'GET' operation 'VirtualNetworks_CheckIPAddressAvailability' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ListInOperationName	R1003	Link	Since operation 'VirtualNetworkGateways_GetBgpPeerStatus' response has model definition 'array', it should be of the form "_list". Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ListInOperationName	R1003	Link	Since operation 'VirtualNetworkGateways_GetLearnedRoutes' response has model definition 'array', it should be of the form "_list". Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ListInOperationName	R1003	Link	Since operation 'VirtualNetworkGateways_GetAdvertisedRoutes' response has model definition 'array', it should be of the form "_list". Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
PutInOperationName	R1006	Link	'PUT' operation 'VirtualNetworkGatewayConnections_SetSharedKey' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounVerb	R1001	Link	Per the Noun_Verb convention for Operation Ids, the noun 'NetworkInterfaces' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounVerb	R1001	Link	Per the Noun_Verb convention for Operation Ids, the noun 'NetworkInterfaces' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounVerb	R1001	Link	Per the Noun_Verb convention for Operation Ids, the noun 'NetworkInterfaces' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ParameterNotDefinedInGlobalParameters	R2015	Link	Parameter "api-version" is referenced but not defined in the global parameters section of Service Definition
OperationIdNounVerb	R1001	Link	Per the Noun_Verb convention for Operation Ids, the noun 'PublicIPAddresses' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounVerb	R1001	Link	Per the Noun_Verb convention for Operation Ids, the noun 'PublicIPAddresses' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ParameterNotDefinedInGlobalParameters	R2015	Link	Parameter "api-version" is referenced but not defined in the global parameters section of Service Definition

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-06T17:55:17Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

72 new Warnings.(96 total)

Code	Id	Source	Message
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: pickHostNameFromBackendAddress
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: probeEnabled
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: requireServerNameIndication
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: pickHostNameFromBackendHttpSettings
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: includePath
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: includeQueryString
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableHttp2
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: requestBodyCheck
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableBgpRoutePropagation
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: primary
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableAcceleratedNetworking
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableIPForwarding
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableFloatingIP
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: primary
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: available
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowClassicOperations
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableFloatingIP
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableOutboundSnat
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableFloatingIP
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: autoStart
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableRegionalMdmAccount
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: fillGapWithZero
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isInternal
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isAuthorizedToUse
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowVirtualNetworkAccess
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowForwardedTraffic
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowGatewayTransit
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: useRemoteGateways
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableDdosProtection
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableVmProtection
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: available
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableBgp
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: activeActive
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableBgp
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: usePolicyBasedTrafficSelectors
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableBgp
EnumInsteadOfBoolean	R3018	Link	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: usePolicyBasedTrafficSelectors
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.
NonApplicationJsonType	R2004	Link	Only 'application/json' content-type is supported by ARM.

❌0 new Errors.(81 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

sergey-shandar · 2018-05-07T18:46:26Z

@ravbhatnagar changes in a stable API.

ravbhatnagar · 2018-05-08T08:56:22Z

@sayghosh - Do these changes exist on the service side in this api-version already and are only getting added to swagger now? If yes, @sergey-shandar - feel free to merge.

sayghosh · 2018-05-08T10:14:39Z

@ravbhatnagar Yes, the changes exist on service side.

sayghosh · 2018-05-10T04:55:52Z

@ravbhatnagar @sergey-shandar Are there any more comments which need to be addressed?

azuresdkciprbot · 2018-05-10T05:21:55Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(95 total)

❌0 new Errors.(78 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-10T05:21:55Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(108 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

* Added 2018-05-01 version. Common fixes (#3025) * Created May folder. Updated version for exampls, commands * Updated package to May version * Returned NW examples * Fixed API version; Fixed NetworkWatcher examples * Fixed VPN Gateway/Connection examples * Add changes from PR#2975 https://github.com/Azure/azure-rest-api-specs/pull/2975/files * Adding optional traffic analytics config fields to network watcher config object for enhancing the Network Watcher cmdlets (#3023) * Adding optional traffic analytics parameters with existing network watched flowlog configuration * Updating the version * Updating latest versoin in readme.md * #AppGw Fundamentals Clean Up (#3046) * Network 2018 05 01 (#3068) * Adding optional traffic analytics parameters with existing network watched flowlog configuration * Updating the version * Updating latest versoin in readme.md * Adding optional traffic analytics parameters with flowlog parameters * Reverting old chnages * Expose new SKUs for VMSS VPN and ER gateways (#3069) Expose new SKUs for VMSS VPN and ER gateways * Initial network error fixes and suppressions (#3051) * Initial network error fixes and suppressions * reworked exception to specified code blocks only * Added express route fixes

…dk-assistant Testing with spec change

sayghosh added 2 commits May 6, 2018 21:01

Adding optional traffic analytics parameters with existing network wa…

a8b493d

…tched flowlog configuration

Updating the version

dbd95cb

sayghosh requested review from DeepakRajendranMsft and MikhailTryakhov as code owners May 6, 2018 15:38

azuresdkci assigned sergey-shandar May 6, 2018

sayghosh changed the title ~~Network 2018 05 01~~ Adding optional traffic analytics config fields to network watcher config object for enhancing the Network Watcher cmdlets May 6, 2018

azuresdkci requested a review from sergey-shandar May 6, 2018 15:39

Updating latest versoin in readme.md

4572481

MikhailTryakhov approved these changes May 7, 2018

View reviewed changes

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 7, 2018

Resolving conflicts in readme.md

1c52e0b

sergey-shandar added the potential-sdk-breaking-change label May 10, 2018

sergey-shandar merged commit 4fd254a into Azure:Network-2018-05-01 May 10, 2018

sayghosh mentioned this pull request May 15, 2018

SDK changes for traffic analytics parameters added to existing networkwatcher flowlog parameters Azure/azure-sdk-for-net#4320

Closed

9 tasks

sayghosh mentioned this pull request May 18, 2018

Adding test file for optional traffic analytics config parameters added to existing network watcher flowlog config parameters Azure/azure-sdk-for-net#4341

Merged

9 tasks

konrad-jamrozik pushed a commit to dhung-msft/azure-rest-api-specs that referenced this pull request Dec 4, 2023

Merge pull request Azure#3023 from test-repo-billy/user/raych1/test-s…

7df9bd5

…dk-assistant Testing with spec change

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding optional traffic analytics config fields to network watcher config object for enhancing the Network Watcher cmdlets #3023

Adding optional traffic analytics config fields to network watcher config object for enhancing the Network Watcher cmdlets #3023

sayghosh commented May 6, 2018 •

edited by azuresdkci

Loading

azuresdkciprbot commented May 6, 2018

azuresdkciprbot commented May 6, 2018

azuresdkciprbot commented May 6, 2018

azuresdkciprbot commented May 6, 2018

sergey-shandar commented May 7, 2018

ravbhatnagar commented May 8, 2018

sayghosh commented May 8, 2018

sayghosh commented May 10, 2018 •

edited

Loading

azuresdkciprbot commented May 10, 2018

azuresdkciprbot commented May 10, 2018

Adding optional traffic analytics config fields to network watcher config object for enhancing the Network Watcher cmdlets #3023

Adding optional traffic analytics config fields to network watcher config object for enhancing the Network Watcher cmdlets #3023

Conversation

sayghosh commented May 6, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

azuresdkciprbot commented May 6, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 6, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 6, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 6, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

sergey-shandar commented May 7, 2018

ravbhatnagar commented May 8, 2018

sayghosh commented May 8, 2018

sayghosh commented May 10, 2018 • edited Loading

azuresdkciprbot commented May 10, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 10, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

sayghosh commented May 6, 2018 •

edited by azuresdkci

Loading

sayghosh commented May 10, 2018 •

edited

Loading