Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGRP S360 Vuln #22832

Merged
merged 8 commits into from
Apr 6, 2023
Merged

MGRP S360 Vuln #22832

merged 8 commits into from
Apr 6, 2023

Conversation

ramoka178
Copy link
Contributor

This PR is a follow up on the previous PRs.

#22270 was made on 2021-04-01 ApiVersion. Making the same change for 2020-05-01 and 2020-10-01.

#19538 was made adding the fields in Swagger. However this is not needed and reverting the changes of 2020-10-01 and 2021-04-01. These values were always null and will be null. So, fixing the API response body to not have null values of the params.

@openapi-workflow-bot
Copy link

Hi, @ramoka178 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 28, 2023

    Swagger Validation Report

    ️❌BreakingChange: 16 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    management.json 2020-05-01(c2c63f5) 2020-05-01(main)
    management.json 2020-10-01(c2c63f5) 2020-10-01(main)
    management.json 2021-04-01(c2c63f5) 2021-04-01(main)
    Rule Message
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.Management/stable/2020-10-01/management.json#L1174:9
    Old: Microsoft.Management/stable/2020-10-01/management.json#L1174:9
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.Management/stable/2021-04-01/management.json#L1177:9
    Old: Microsoft.Management/stable/2021-04-01/management.json#L1177:9
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.Management/stable/2020-10-01/management.json#L1174:9
    Old: Microsoft.Management/stable/2020-10-01/management.json#L1174:9
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.Management/stable/2021-04-01/management.json#L1177:9
    Old: Microsoft.Management/stable/2021-04-01/management.json#L1177:9
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'nextLink' renamed or removed?
    New: Microsoft.Management/stable/2020-05-01/management.json#L1059:7
    Old: Microsoft.Management/stable/2020-05-01/management.json#L1054:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'nextLink' renamed or removed?
    New: Microsoft.Management/stable/2020-05-01/management.json#L1431:7
    Old: Microsoft.Management/stable/2020-05-01/management.json#L1426:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'nextLink' renamed or removed?
    New: Microsoft.Management/stable/2020-10-01/management.json#L1065:7
    Old: Microsoft.Management/stable/2020-10-01/management.json#L1065:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'name' renamed or removed?
    New: Microsoft.Management/stable/2020-10-01/management.json#L1575:7
    Old: Microsoft.Management/stable/2020-10-01/management.json#L1585:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'displayName' renamed or removed?
    New: Microsoft.Management/stable/2020-10-01/management.json#L1575:7
    Old: Microsoft.Management/stable/2020-10-01/management.json#L1585:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'nextLink' renamed or removed?
    New: Microsoft.Management/stable/2020-10-01/management.json#L1445:7
    Old: Microsoft.Management/stable/2020-10-01/management.json#L1445:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'name' renamed or removed?
    New: Microsoft.Management/stable/2021-04-01/management.json#L1604:7
    Old: Microsoft.Management/stable/2021-04-01/management.json#L1614:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'displayName' renamed or removed?
    New: Microsoft.Management/stable/2021-04-01/management.json#L1604:7
    Old: Microsoft.Management/stable/2021-04-01/management.json#L1614:7
    1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property '@nextlink' in response that was not found in the old version.
    New: Microsoft.Management/stable/2020-05-01/management.json#L1059:7
    Old: Microsoft.Management/stable/2020-05-01/management.json#L1054:7
    1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property '@nextlink' in response that was not found in the old version.
    New: Microsoft.Management/stable/2020-05-01/management.json#L1431:7
    Old: Microsoft.Management/stable/2020-05-01/management.json#L1426:7
    1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property '@nextlink' in response that was not found in the old version.
    New: Microsoft.Management/stable/2020-10-01/management.json#L1065:7
    Old: Microsoft.Management/stable/2020-10-01/management.json#L1065:7
    1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property '@nextlink' in response that was not found in the old version.
    New: Microsoft.Management/stable/2020-10-01/management.json#L1445:7
    Old: Microsoft.Management/stable/2020-10-01/management.json#L1445:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2021-04 package-2021-04(c2c63f5) package-2021-04(main)
    package-2020-10 package-2020-10(c2c63f5) package-2020-10(main)
    package-2020-05 package-2020-05(c2c63f5) package-2020-05(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    GetCollectionResponseSchema The response in the GET collection operation 'ManagementGroups_List' does not match the response definition in the individual GET operation 'ManagementGroups_Get' .
    Location: Microsoft.Management/stable/2020-05-01/management.json#L51
    PathForPutOperation The path for 'put' operation must be under a subscription and resource group.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L93
    CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L166
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L173
    ConsistentPatchProperties The property 'displayName' in the request body either not apppear in the resource model or has the wrong level.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L222
    ConsistentPatchProperties The property 'parentGroupId' in the request body either not apppear in the resource model or has the wrong level.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L222
    DeleteOperationAsyncResponseValidation An async DELETE operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Management/stable/2020-05-01/management.json#L246
    PathForPutOperation The path for 'put' operation must be under a subscription and resource group.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L346
    GetCollectionResponseSchema The response in the GET collection operation 'HierarchySettings_List' does not match the response definition in the individual GET operation 'HierarchySettings_Get' .
    Location: Microsoft.Management/stable/2020-05-01/management.json#L510
    PathForPutOperation The path for 'put' operation must be under a subscription and resource group.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L546
    DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Management/stable/2020-05-01/management.json#L669
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Management/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L702
    MissingTypeObject The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L890
    MissingTypeObject The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L899
    MissingTypeObject The schema 'OperationDisplayProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L931
    MissingTypeObject The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L956
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.Management/stable/2020-05-01/management.json#L959
    MissingTypeObject The schema 'CheckNameAvailabilityResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L974
    MissingTypeObject The schema 'TenantBackfillStatusResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L1010
    MissingTypeObject The schema 'ManagementGroupListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L1057
    MissingTypeObject The schema 'ManagementGroupInfo' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L1074
    MissingTypeObject The schema 'ListSubscriptionUnderManagementGroup' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L1113
    MissingTypeObject The schema 'SubscriptionUnderManagementGroup' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L1130
    MissingTypeObject The schema 'ManagementGroup' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L1179
    TopLevelResourcesListBySubscription The top-level resource 'ManagementGroup' does not have list by subscription operation, please add it.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L1179
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.Management/stable/2020-05-01/management.json#L1253
    MissingTypeObject The schema 'ManagementGroupChildInfo' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L1263
    MissingTypeObject The schema 'ManagementGroupPathElement' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L1292
    MissingTypeObject The schema 'ParentGroupInfo' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L1305
    XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Management/stable/2020-05-01/management.json#L1322
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 28, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking



    azure-sdk-for-js - @azure/arm-managementgroups - 3.0.0
    +	Interface EntitiesListNextOptionalParams no longer has parameter filter
    +	Interface EntitiesListNextOptionalParams no longer has parameter groupName
    +	Interface EntitiesListNextOptionalParams no longer has parameter search
    +	Interface EntitiesListNextOptionalParams no longer has parameter select
    +	Interface EntitiesListNextOptionalParams no longer has parameter skip
    +	Interface EntitiesListNextOptionalParams no longer has parameter skiptoken
    +	Interface EntitiesListNextOptionalParams no longer has parameter top
    +	Interface EntitiesListNextOptionalParams no longer has parameter view
    +	Interface ManagementGroupSubscriptionsGetSubscriptionsUnderManagementGroupNextOptionalParams no longer has parameter skiptoken
    +	Interface ManagementGroupsGetDescendantsNextOptionalParams no longer has parameter skiptoken
    +	Interface ManagementGroupsGetDescendantsNextOptionalParams no longer has parameter top
    +	Interface ManagementGroupsListNextOptionalParams no longer has parameter skiptoken
    +	Type of parameter expand of interface ManagementGroupsGetOptionalParams is changed from Enum0 to ManagementGroupExpandType
    +	Type of parameter search of interface EntitiesListOptionalParams is changed from Enum2 to EntitySearchType
    +	Type of parameter view of interface EntitiesListOptionalParams is changed from Enum3 to EntityViewParameterType
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7ef6c70. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/managementgroups/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.ManagementGroups [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7ef6c70. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.4` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-managementgroups [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added model EntitySearchType
      info	[Changelog]   - Added model EntityViewParameterType
      info	[Changelog]   - Added model ManagementGroupExpandType
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7ef6c70. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/managementgroups/armmanagementgroups [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7ef6c70. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-managementgroups [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Type Alias EntitySearchType
      info	[Changelog]   - Added Type Alias EntityViewParameterType
      info	[Changelog]   - Added Type Alias ManagementGroupExpandType
      info	[Changelog]   - Added Enum KnownEntitySearchType
      info	[Changelog]   - Added Enum KnownEntityViewParameterType
      info	[Changelog]   - Added Enum KnownManagementGroupExpandType
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface EntitiesListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface EntitiesListNextOptionalParams no longer has parameter groupName
      info	[Changelog]   - Interface EntitiesListNextOptionalParams no longer has parameter search
      info	[Changelog]   - Interface EntitiesListNextOptionalParams no longer has parameter select
      info	[Changelog]   - Interface EntitiesListNextOptionalParams no longer has parameter skip
      info	[Changelog]   - Interface EntitiesListNextOptionalParams no longer has parameter skiptoken
      info	[Changelog]   - Interface EntitiesListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface EntitiesListNextOptionalParams no longer has parameter view
      info	[Changelog]   - Interface ManagementGroupsGetDescendantsNextOptionalParams no longer has parameter skiptoken
      info	[Changelog]   - Interface ManagementGroupsGetDescendantsNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface ManagementGroupsListNextOptionalParams no longer has parameter skiptoken
      info	[Changelog]   - Interface ManagementGroupSubscriptionsGetSubscriptionsUnderManagementGroupNextOptionalParams no longer has parameter skiptoken
      info	[Changelog]   - Type of parameter search of interface EntitiesListOptionalParams is changed from Enum2 to EntitySearchType
      info	[Changelog]   - Type of parameter view of interface EntitiesListOptionalParams is changed from Enum3 to EntityViewParameterType
      info	[Changelog]   - Type of parameter expand of interface ManagementGroupsGetOptionalParams is changed from Enum0 to ManagementGroupExpandType
      info	[Changelog]   - Removed Enum KnownEnum0
      info	[Changelog]   - Removed Enum KnownEnum2
      info	[Changelog]   - Removed Enum KnownEnum3
      info	[Changelog]   - Removed Enum KnownManagementGroupChildType
      info	[Changelog]   - Removed Enum KnownPermissions
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7ef6c70. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️managementgroups [View full logs
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7ef6c70. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.managementgroups.DefaultTag [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 28, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/managementgroups/armmanagementgroups https://apiview.dev/Assemblies/Review/6ddbbe87651e47d199242dfba7bfa5ee
    Java azure-resourcemanager-managementgroups Create ApiView failed. Please ask PR assignee for help
    JavaScript @azure/arm-managementgroups https://apiview.dev/Assemblies/Review/7822e4c852d2455e8c87337846ed384b

    @openapi-workflow-bot
    Copy link

    Hi @ramoka178, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @ramoka178, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @ramoka178
    Copy link
    Contributor Author

    Created a breaking change review at https://msazure.visualstudio.com/One/_workitems/edit/17392463

    @ghost
    Copy link

    ghost commented Mar 19, 2023

    Hi, @ramoka178. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Mar 19, 2023
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 3, 2023
    @XiaofeiCao XiaofeiCao merged commit 7ef6c70 into Azure:main Apr 6, 2023
    fnuarnav added a commit that referenced this pull request Apr 7, 2023
    …23473)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    fnuarnav added a commit that referenced this pull request Apr 7, 2023
    …23483)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    * use management.auzre.com endpoint
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    fnuarnav added a commit that referenced this pull request Apr 7, 2023
    …23484)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    * add codeowners for Compute Instance swagger (#23437)
    
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    
    * [Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview (#22828)
    
    * Adds base for updating Microsoft.DevHub from version preview/2022-04-01-preview to version 2022-10-11-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * start 10-11 preview
    
    * add words
    
    * fix readme version
    
    * update swagger version
    
    * add second putworkflow example
    
    * fix generatepreviewartifactsresponse
    
    * align generate preview artifacts example
    
    * update param locations that got changed
    
    * add x-ms-client-flatten for artifact properties
    
    * Adding WorkflowRunStatus
    
    * Fixing enum name
    
    * add namespace to example
    
    ---------
    
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    
    * Update readme.python.md (#23208)
    
    * fixing async response type for machinelearningservices-2023-02-01-preview (#23105)
    
    * fixing regex pattern and async response type
    
    * remove update to regex
    
    * Fix lint error for Datadog RP (#23477)
    
    * Fix link error for Datadog RP
    
    * Fix version
    
    * merging billing fix to public repo (#23424)
    
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    
    * use management.auzre.com endpoint
    
    * fix package version in readme
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    Co-authored-by: Naman Agarwal <namanag16@gmail.com>
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    Co-authored-by: David Gamero <david340804@gmail.com>
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
    Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
    Co-authored-by: Gaurav <bang.gourav@gmail.com>
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    fnuarnav added a commit that referenced this pull request Apr 11, 2023
    …23513)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    * add codeowners for Compute Instance swagger (#23437)
    
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    
    * [Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview (#22828)
    
    * Adds base for updating Microsoft.DevHub from version preview/2022-04-01-preview to version 2022-10-11-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * start 10-11 preview
    
    * add words
    
    * fix readme version
    
    * update swagger version
    
    * add second putworkflow example
    
    * fix generatepreviewartifactsresponse
    
    * align generate preview artifacts example
    
    * update param locations that got changed
    
    * add x-ms-client-flatten for artifact properties
    
    * Adding WorkflowRunStatus
    
    * Fixing enum name
    
    * add namespace to example
    
    ---------
    
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    
    * Update readme.python.md (#23208)
    
    * fixing async response type for machinelearningservices-2023-02-01-preview (#23105)
    
    * fixing regex pattern and async response type
    
    * remove update to regex
    
    * Fix lint error for Datadog RP (#23477)
    
    * Fix link error for Datadog RP
    
    * Fix version
    
    * merging billing fix to public repo (#23424)
    
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    
    * use management.auzre.com endpoint
    
    * fix package version in readme
    
    * fix tag in readme
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    Co-authored-by: Naman Agarwal <namanag16@gmail.com>
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    Co-authored-by: David Gamero <david340804@gmail.com>
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
    Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
    Co-authored-by: Gaurav <bang.gourav@gmail.com>
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    tadelesh pushed a commit that referenced this pull request Apr 13, 2023
    …2023-05-01 (#23485)
    
    * Adds base for updating Microsoft.ContainerInstance from version preview/2022-10-01-preview to version 2023-05-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23166)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23169)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23170)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23452)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * use old api versionf or operations
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23453)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * use old api versionf or operations
    
    * revert Operations example api version
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23471)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * use old api versionf or operations
    
    * revert Operations example api version
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23473)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * use management.auzre.com endpoint
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23483)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    * use management.auzre.com endpoint
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * fix package version in readme
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23484)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    * add codeowners for Compute Instance swagger (#23437)
    
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    
    * [Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview (#22828)
    
    * Adds base for updating Microsoft.DevHub from version preview/2022-04-01-preview to version 2022-10-11-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * start 10-11 preview
    
    * add words
    
    * fix readme version
    
    * update swagger version
    
    * add second putworkflow example
    
    * fix generatepreviewartifactsresponse
    
    * align generate preview artifacts example
    
    * update param locations that got changed
    
    * add x-ms-client-flatten for artifact properties
    
    * Adding WorkflowRunStatus
    
    * Fixing enum name
    
    * add namespace to example
    
    ---------
    
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    
    * Update readme.python.md (#23208)
    
    * fixing async response type for machinelearningservices-2023-02-01-preview (#23105)
    
    * fixing regex pattern and async response type
    
    * remove update to regex
    
    * Fix lint error for Datadog RP (#23477)
    
    * Fix link error for Datadog RP
    
    * Fix version
    
    * merging billing fix to public repo (#23424)
    
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    
    * use management.auzre.com endpoint
    
    * fix package version in readme
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    Co-authored-by: Naman Agarwal <namanag16@gmail.com>
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    Co-authored-by: David Gamero <david340804@gmail.com>
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
    Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
    Co-authored-by: Gaurav <bang.gourav@gmail.com>
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    
    * fix tag in readme
    
    * update example with capabilities example
    
    * fix typo
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    Co-authored-by: Naman Agarwal <namanag16@gmail.com>
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    Co-authored-by: David Gamero <david340804@gmail.com>
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
    Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
    Co-authored-by: Gaurav <bang.gourav@gmail.com>
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    …2023-05-01 (Azure#23485)
    
    * Adds base for updating Microsoft.ContainerInstance from version preview/2022-10-01-preview to version 2023-05-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23166)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23169)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23170)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23452)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * use old api versionf or operations
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23453)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * use old api versionf or operations
    
    * revert Operations example api version
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23471)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * use old api versionf or operations
    
    * revert Operations example api version
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23473)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (Azure#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (Azure#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (Azure#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (Azure#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * use management.auzre.com endpoint
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23483)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (Azure#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (Azure#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (Azure#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (Azure#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    * use management.auzre.com endpoint
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * fix package version in readme
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23484)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (Azure#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (Azure#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (Azure#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (Azure#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    * add codeowners for Compute Instance swagger (Azure#23437)
    
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    
    * [Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview (Azure#22828)
    
    * Adds base for updating Microsoft.DevHub from version preview/2022-04-01-preview to version 2022-10-11-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * start 10-11 preview
    
    * add words
    
    * fix readme version
    
    * update swagger version
    
    * add second putworkflow example
    
    * fix generatepreviewartifactsresponse
    
    * align generate preview artifacts example
    
    * update param locations that got changed
    
    * add x-ms-client-flatten for artifact properties
    
    * Adding WorkflowRunStatus
    
    * Fixing enum name
    
    * add namespace to example
    
    ---------
    
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    
    * Update readme.python.md (Azure#23208)
    
    * fixing async response type for machinelearningservices-2023-02-01-preview (Azure#23105)
    
    * fixing regex pattern and async response type
    
    * remove update to regex
    
    * Fix lint error for Datadog RP (Azure#23477)
    
    * Fix link error for Datadog RP
    
    * Fix version
    
    * merging billing fix to public repo (Azure#23424)
    
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    
    * use management.auzre.com endpoint
    
    * fix package version in readme
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    Co-authored-by: Naman Agarwal <namanag16@gmail.com>
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    Co-authored-by: David Gamero <david340804@gmail.com>
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
    Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
    Co-authored-by: Gaurav <bang.gourav@gmail.com>
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    
    * fix tag in readme
    
    * update example with capabilities example
    
    * fix typo
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    Co-authored-by: Naman Agarwal <namanag16@gmail.com>
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    Co-authored-by: David Gamero <david340804@gmail.com>
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
    Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
    Co-authored-by: Gaurav <bang.gourav@gmail.com>
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-JavaScript resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants